Skip to content

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Feb 25, 2025

  • Always treat ? as escaped ?. Suggest * to match any character.
  • Dropped support for char sets [...]. [ and ] are treated same as escaped \[ and \]. We didn't find any use of it on GitHub and it just complicates the code.

Fixes #34915

This comment has been minimized.

This comment has been minimized.

@yury-s yury-s marked this pull request as ready for review February 25, 2025 22:48

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
❌ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18

5 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:215:5 › should watch component via util @macos-latest-node18-1
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node18-1
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

38640 passed, 793 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit cd437c9 into microsoft:main Feb 28, 2025
28 of 29 checks passed
@yury-s yury-s deleted the glob-relative-url branch February 28, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect behavior of '?' in the url glob pattern

3 participants