Skip to content

fix: allow matching against about:blank and other custom URLs #36180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025
Merged

fix: allow matching against about:blank and other custom URLs #36180

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd109e3
fix: allow matching against `about:blank` and other custom URLs
agg23 Jun 3, 2025
2eaa9d2
Only handle special colon path if there is no baseURL
agg23 Jun 3, 2025
9cf9b14
Still tokenize colon containing path, while also disabling baseURL
agg23 Jun 4, 2025
6ef6b0c
Switch to specifically special casing the `about:` prefix
agg23 Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/playwright-core/src/utils/isomorphic/urlMatch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ function resolveGlobBase(baseURL: string | undefined, match: string): string {
}
// Escaped `\\?` behaves the same as `?` in our glob patterns.
match = match.replaceAll(/\\\\\?/g, '?');
// Node URL constructors automatically uses colon as an indicator of a base URL, such as with `about:blank`
// Only perform special handling if we have a specified base URL
const splitScheme = match.split('://');
const schemelessPath = splitScheme.length === 1 ? splitScheme[0] : splitScheme[1];
if (schemelessPath !== undefined && baseURL !== undefined && schemelessPath.indexOf(':') !== -1)
return match;
// Glob symbols may be escaped in the URL and some of them such as ? affect resolution,
// so we replace them with safe components first.
const relativePath = match.split('/').map((token, index) => {
Expand Down
6 changes: 6 additions & 0 deletions tests/page/interception.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,12 @@ it('should work with glob', async () => {
expect(urlMatches('http://playwright.dev/foo', 'http://playwright.dev/foo?bar', '\\\\?bar')).toBeTruthy();
expect(urlMatches('http://first.host/', 'http://second.host/foo', '**/foo')).toBeTruthy();
expect(urlMatches('http://playwright.dev/', 'http://localhost/', '*//localhost/')).toBeTruthy();

expect(urlMatches('http://playwright.dev/', 'about:blank', 'about:blank')).toBeTruthy();
expect(urlMatches('http://playwright.dev/', 'about:blank', 'http://playwright.dev/')).toBeFalsy();
expect(urlMatches(undefined, 'about:blank', 'about:blank')).toBeTruthy();
expect(urlMatches(undefined, 'about:blank', 'about:*')).toBeTruthy();
expect(urlMatches(undefined, 'notabout:blank', 'about:*')).toBeFalsy();
});

it('should intercept by glob', async function({ page, server, isAndroid }) {
Expand Down
Loading