Skip to content

Revert "Merge dev to master for 7.1.3 preview release" #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ulvii merged 22 commits into from
Dec 1, 2018
Merged

Revert "Merge dev to master for 7.1.3 preview release" #895

ulvii merged 22 commits into from
Dec 1, 2018

Conversation

@ulvii
Copy link
Contributor

@ulvii ulvii commented Nov 30, 2018

Reverts #894 to cancel rebase

ulvii added 22 commits November 30, 2018 15:40
@ulvii
Revert "Release | Changes for 7.1.3preview release (#893)"
5e4b1ae 
This reverts commit 5b5a06f.
@ulvii
Revert "Revert "removed redundant check of logger level (#883)" (#891)"
d05c148 
This reverts commit bdcc6f1.
@ulvii
Revert "Add SQLServerMetadata constructor to set precision for string…
925dd16 
… types (#876)"

This reverts commit 60aaca7.
@ulvii
Revert "Fix | Intermittent BulkCopyResultSetCursorTest error (#854)"
b638471 
This reverts commit 12e4e49.
@ulvii
Revert "Address TODOs in tests (#873)"
60e879a 
This reverts commit c3cb562.
@ulvii
Revert "removed redundant check of logger level (#883)"
e6b63d5 
This reverts commit 5e36e29.
@ulvii
Revert "Fix Geography.point method (#853)"
b48a76e 
This reverts commit 123abb0.
@ulvii
Revert "Improved retry logic for intermittent TLS1.2 issue (#882)"
3366159 
This reverts commit 5dfeaab.
@ulvii
Revert "Fix | Removed populating Lobs when calling wasNull()"
9f6d4e4 
This reverts commit a2b669f.
@ulvii
Revert "Fix | Fix random issues for SQLFloat type and improved TVPAll…
4a68057 
…TypesTest for possible errors. (#888)"

This reverts commit 7b1ca05.
@ulvii
Revert "Enhancement | one thread for timers"
dac5f0d 
This reverts commit f041460.
@ulvii
Revert "Fix | Fix issue with setAutoCommit leaving an open transactio…
38f88ae 
…n behind in Azure DW (#881)"

This reverts commit 3c687d6.
@ulvii
Revert "Change scope of Connection/Statement in TVPAllTypesTest to pr…
b83cca5 
…event random failures (#862)"

This reverts commit 53eb3df.
@ulvii
Revert "Simplify boolean expressions (#857)"
24749ed 
This reverts commit c8fc626.
@ulvii
Revert "Enable Appveyor with Java 11 updates (#886)"
37c0ff6 
This reverts commit 7ffb0d3.
@ulvii
Revert "Update survey image link"
f63b23f 
This reverts commit dc62db0.
@ulvii
Revert "Improvements | Remove unnecessary code where variable 'typeDe…
64304c8 
…finition' is assigned to itself (#858)"

This reverts commit e6afeb1.
@ulvii
Revert "Improvements | Remove unnecessary semicolons (#856)"
71a33a8 
This reverts commit 493759a.
@ulvii
Revert "Improvement | Replace string concatenation with StringBuilder (…
4155941 
…#861)"

This reverts commit d7a7ce2.
@ulvii
Revert "Remove "country" from changelog (#868)"
cea5946 
This reverts commit e3baf20.
@ulvii
Revert "removed obsolete comment (#866)"
e971c0e 
This reverts commit ac77a73.
@ulvii
Revert "Update snapshot for 7.1.3 (#871)"
abee62d 
This reverts commit dd80534.
@codecov-io
Copy link

codecov-io commented Nov 30, 2018

Codecov Report

Merging #895 into master will increase coverage by 0.02%.
The diff coverage is 58.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #895      +/-   ##
============================================
+ Coverage      48.7%   48.72%   +0.02%     
+ Complexity     2818     2801      -17     
============================================
  Files           118      116       -2     
  Lines         27877    27875       -2     
  Branches       4642     4650       +8     
============================================
+ Hits          13578    13583       +5     
+ Misses        12105    12090      -15     
- Partials       2194     2202       +8
Flag Coverage Δ Complexity Δ
#JDBC42 48.28% <58.38%> (+0.12%) 2760 <7> (-10) ⬇️
#JDBC43 48.64% <58.38%> (+0.01%) 2795 <7> (-20) ⬇️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/TVP.java 44.12% <ø> (ø) 27 <0> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerMetaData.java 24% <ø> (+2.18%) 0 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.29% <ø> (-0.48%) 107 <0> (-3)
...oft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java 56.25% <ø> (ø) 5 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.48% <ø> (-0.4%) 5 <0> (-1)
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 24.62% <0%> (+0.05%) 31 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.51% <0%> (-0.06%) 135 <0> (ø)
...microsoft/sqlserver/jdbc/FailOverMapSingleton.java 13.79% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/com/microsoft/sqlserver/jdbc/Column.java 34.73% <0%> (ø) 35 <0> (ø) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b5a06f...abee62d. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Nov 30, 2018 •
edited
Loading

Codecov Report

Merging #895 into master will increase coverage by 0.02%.
The diff coverage is 58.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #895      +/-   ##
============================================
+ Coverage      48.7%   48.72%   +0.02%     
+ Complexity     2818     2801      -17     
============================================
  Files           118      116       -2     
  Lines         27877    27875       -2     
  Branches       4642     4650       +8     
============================================
+ Hits          13578    13583       +5     
+ Misses        12105    12090      -15     
- Partials       2194     2202       +8
Flag Coverage Δ Complexity Δ
#JDBC42 48.28% <58.38%> (+0.12%) 2760 <7> (-10) ⬇️
#JDBC43 48.64% <58.38%> (+0.01%) 2795 <7> (-20) ⬇️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/TVP.java 44.12% <ø> (ø) 27 <0> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerMetaData.java 24% <ø> (+2.18%) 0 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.29% <ø> (-0.48%) 107 <0> (-3)
...oft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java 56.25% <ø> (ø) 5 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.48% <ø> (-0.4%) 5 <0> (-1)
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 24.62% <0%> (+0.05%) 31 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.51% <0%> (-0.06%) 135 <0> (ø)
...microsoft/sqlserver/jdbc/FailOverMapSingleton.java 13.79% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/com/microsoft/sqlserver/jdbc/Column.java 34.73% <0%> (ø) 35 <0> (ø) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b5a06f...abee62d. Read the comment docs.

@ulvii ulvii merged commit 14d0139 into master Dec 1, 2018
@ulvii ulvii deleted the revert-894-dev branch December 1, 2018 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ulvii @codecov-io @cheenamalhotra