Fix issue with setAutoCommit leaving a transaction behind in Azure DW#881
Merged
cheenamalhotra merged 1 commit intomicrosoft:devfrom Nov 22, 2018
Merged
Fix issue with setAutoCommit leaving a transaction behind in Azure DW#881cheenamalhotra merged 1 commit intomicrosoft:devfrom
cheenamalhotra merged 1 commit intomicrosoft:devfrom
Conversation
odelpozo-denodo
approved these changes
Nov 16, 2018
Codecov Report
@@ Coverage Diff @@
## dev #881 +/- ##
============================================
+ Coverage 48.71% 48.71% +<.01%
- Complexity 2797 2801 +4
============================================
Files 116 116
Lines 27877 27877
Branches 4650 4650
============================================
+ Hits 13579 13581 +2
- Misses 12093 12094 +1
+ Partials 2205 2202 -3
Continue to review full report at Codecov.
|
cheenamalhotra
approved these changes
Nov 20, 2018
ulvii
approved these changes
Nov 20, 2018
ulvii
pushed a commit
that referenced
this pull request
Nov 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #872.
Currently, when we call setAutoCommit(), we execute this query:
This still leaves a transaction open in Azure DW, according to MSDN documents.
To fix this issue, we're going to execute this query instead:
Which should do the same thing except it fixes the aforementioned issue in Azure DW.