Add SQLServerMetadata constructor to set precision for string types#876
Merged
lilgreenbird merged 5 commits intomicrosoft:devfrom Nov 29, 2018
Merged
Add SQLServerMetadata constructor to set precision for string types#876lilgreenbird merged 5 commits intomicrosoft:devfrom
lilgreenbird merged 5 commits intomicrosoft:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #876 +/- ##
===========================================
- Coverage 48.74% 48.6% -0.14%
+ Complexity 2813 2810 -3
===========================================
Files 118 118
Lines 27863 27877 +14
Branches 4637 4642 +5
===========================================
- Hits 13582 13551 -31
- Misses 12086 12134 +48
+ Partials 2195 2192 -3
Continue to review full report at Codecov.
|
ulvii
reviewed
Nov 21, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerMetaData.java
Outdated
Show resolved
Hide resolved
peterbae
reviewed
Nov 28, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerMetaData.java
Outdated
Show resolved
Hide resolved
ulvii
approved these changes
Nov 28, 2018
rene-ye
approved these changes
Nov 28, 2018
peterbae
approved these changes
Nov 28, 2018
ulvii
pushed a commit
that referenced
this pull request
Nov 30, 2018
…876) * added contructor for string length * added comments * updated javadoc * updated javadoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #846