Skip to content

Conversation

@rene-ye
Copy link
Member

@rene-ye rene-ye commented Nov 29, 2018

This reverts commit 25028fb.

@rene-ye rene-ye added this to the 7.1.3 milestone Nov 29, 2018
@codecov-io
Copy link

codecov-io commented Nov 29, 2018

Codecov Report

Merging #891 into dev will decrease coverage by 1.47%.
The diff coverage is 18.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #891      +/-   ##
============================================
- Coverage     50.16%   48.69%   -1.48%     
- Complexity     2815     2819       +4     
============================================
  Files           118      118              
  Lines         27027    27877     +850     
  Branches       4241     4642     +401     
============================================
+ Hits          13559    13574      +15     
- Misses        11531    12110     +579     
- Partials       1937     2193     +256
Flag Coverage Δ Complexity Δ
#JDBC42 48.17% <18.34%> (-1.51%) 2773 <118> (+2)
#JDBC43 48.58% <18.41%> (-1.52%) 2812 <122> (ø)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.74% <ø> (-2.47%) 256 <0> (+3)
...om/microsoft/sqlserver/jdbc/AuthenticationJNI.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerXAResource.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...microsoft/sqlserver/jdbc/FailOverMapSingleton.java 13.79% <0%> (-0.5%) 0 <0> (ø)
...m/microsoft/sqlserver/jdbc/KerbAuthentication.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...icrosoft/sqlserver/jdbc/SQLServerXAConnection.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...microsoft/sqlserver/jdbc/SQLServerADAL4JUtils.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...icrosoft/sqlserver/jdbc/SQLServerXADataSource.java 6.25% <0%> (-2.09%) 2 <0> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.33% <0%> (+0.89%) 109 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 80.22% <0%> (-0.37%) 25 <0> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd89a10...9790b66. Read the comment docs.

@lilgreenbird lilgreenbird merged commit 47d6eb4 into microsoft:dev Nov 29, 2018
ulvii pushed a commit that referenced this pull request Nov 30, 2018
ulvii added a commit that referenced this pull request Nov 30, 2018
@rene-ye rene-ye deleted the revertPR branch October 10, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants