ComboBox: Fix submit pending value#5048
Merged
jspurlin merged 4 commits intomicrosoft:masterfrom May 31, 2018
Merged
Conversation
…ue to take into account if the aria-label is used as text. This line was missed in the initial change
Contributor
Author
|
@kysedate as an fyi |
christiango
reviewed
May 31, 2018
| // Check to see if the user typed an exact match | ||
| if (this._indexWithinBounds(currentOptions, currentPendingValueValidIndex)) { | ||
| const pendingOptionText: string = currentOptions[currentPendingValueValidIndex].text.toLocaleLowerCase(); | ||
| const pendingOptionText: string = this._getPreviewText(currentOptions[currentPendingValueValidIndex]).toLocaleLowerCase(); // jeremy |
Member
There was a problem hiding this comment.
nit: remove the comment here
christiango
approved these changes
May 31, 2018
Contributor
|
Looks good to me once the comment is removed |
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 1, 2018
* master: (95 commits) Applying package updates. Experiments/Nav component: display "show more" link only if there is atleast one hidden link (microsoft#5057) Add pointerup listener to exit keytip mode (microsoft#5051) Update PULL_REQUEST_TEMPLATE.md Update ISSUE_TEMPLATE.md Shimmer: resolve conflicts (microsoft#5034) Invalid ARIA attributes: Fix empty values (microsoft#5040) ComboBox: Correct invalid ARIA attributes. (microsoft#4873) (microsoft#5001) ComboBox: Fix submit pending value (microsoft#5048) FocusTrapZone - restore last focused descendant element (microsoft#4897) Applying package updates. Take 2 of the require.resolve change. This time using the "resolve" pkg (microsoft#5031) fixing webpack config to allow rush build to complete on a small VM (microsoft#5037) MessageBar: change color of X close button so that it is accessible (microsoft#5039) Theming: improve accessibility (microsoft#5038) Applying package updates. Added 'made with fabric' to readme (microsoft#5018) HoverCard: example accessibility fix. (microsoft#5027) Dropdown caret (microsoft#5016) Applying package updates. ...
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 2, 2018
* master: (274 commits) Demo Page Refactor Part 1 (microsoft#5055) SplitButton: Add aria-roledescription (microsoft#5062) Add addins sketch toolkit link (microsoft#5052) Dropdown title (microsoft#4983) Allow for more control over event handling for keytips (microsoft#5064) Build time speed improvements (microsoft#4965) Coachmark: Positioning fixes (microsoft#4995) Applying package updates. Experiments/Nav component: display "show more" link only if there is atleast one hidden link (microsoft#5057) Add pointerup listener to exit keytip mode (microsoft#5051) Update PULL_REQUEST_TEMPLATE.md Update ISSUE_TEMPLATE.md Shimmer: resolve conflicts (microsoft#5034) Invalid ARIA attributes: Fix empty values (microsoft#5040) ComboBox: Correct invalid ARIA attributes. (microsoft#4873) (microsoft#5001) ComboBox: Fix submit pending value (microsoft#5048) FocusTrapZone - restore last focused descendant element (microsoft#4897) Applying package updates. Take 2 of the require.resolve change. This time using the "resolve" pkg (microsoft#5031) fixing webpack config to allow rush build to complete on a small VM (microsoft#5037) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
There was a prop added a little while ago to use the ariaLabel as the text for an option but the check in submitPendingValue was missed causing options that might be displayed with a different string than what should be matched to not get matched.
This PR fixes the value that is checked when submitting a pending value to take into account if the aria-label is used as text. This line was missed in the initial change
Focus areas to test
Verified that autocomplete pending matches now sumbit as expected
Microsoft Reviewers: Open in CodeFlow