Skip to content

Theming: improve accessibility#5038

Merged
phkuo merged 3 commits intomicrosoft:masterfrom
phkuo:phkuo/themeAccessibility
May 30, 2018
Merged

Theming: improve accessibility#5038
phkuo merged 3 commits intomicrosoft:masterfrom
phkuo:phkuo/themeAccessibility

Conversation

@phkuo
Copy link
Copy Markdown
Contributor

@phkuo phkuo commented May 30, 2018

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

  1. Generate more accessible colors for the themeLighter slot.
  2. Add more accessibility pairs to the contrast checker in the theme generator tool.

image

Focus areas to test

(optional)

@phkuo phkuo merged commit bc4fcf6 into microsoft:master May 30, 2018
@betrue-final-final
Copy link
Copy Markdown
Member

I'd love to understand exactly what this change means.

Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Jun 1, 2018
* master: (95 commits)
  Applying package updates.
  Experiments/Nav component: display "show more" link only if there is atleast one hidden link (microsoft#5057)
  Add pointerup listener to exit keytip mode (microsoft#5051)
  Update PULL_REQUEST_TEMPLATE.md
  Update ISSUE_TEMPLATE.md
  Shimmer: resolve conflicts (microsoft#5034)
  Invalid ARIA attributes: Fix empty values (microsoft#5040)
  ComboBox: Correct invalid ARIA attributes. (microsoft#4873) (microsoft#5001)
  ComboBox: Fix submit pending value (microsoft#5048)
  FocusTrapZone - restore last focused descendant element (microsoft#4897)
  Applying package updates.
  Take 2 of the require.resolve change. This time using the "resolve" pkg (microsoft#5031)
  fixing webpack config to allow rush build to complete on a small VM (microsoft#5037)
  MessageBar: change color of X close button so that it is accessible (microsoft#5039)
  Theming: improve accessibility (microsoft#5038)
  Applying package updates.
  Added 'made with fabric' to readme (microsoft#5018)
  HoverCard: example accessibility fix. (microsoft#5027)
  Dropdown caret (microsoft#5016)
  Applying package updates.
  ...
@phkuo phkuo deleted the phkuo/themeAccessibility branch June 7, 2018 21:55
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants