Skip to content

ComboBox: Fix submit pending value #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jspurlin merged 4 commits into from
May 31, 2018
Merged

ComboBox: Fix submit pending value #5048

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
222e687
ComboBox: Fix the value that is checked when submitting a pending val…
jspurlin May 31, 2018
b217c2e
rush change
jspurlin May 31, 2018
c65a774
remove unneeded debugging comment
jspurlin May 31, 2018
3d36b12
Merge branch 'master' into jspurlin/ComboBoxFixSubmitPendingValue
jspurlin May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...anges/office-ui-fabric-react/jspurlin-ComboBoxFixSubmitPendingValue_2018-05-31-16-16.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "ComboBox: Fix the value that is checked when submitting a pending value to take into account if the aria-label is used as text. This line was missed in the initial change",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "jspurlin@microsoft.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ export class ComboBox extends BaseComponent<IComboBoxProps, IComboBoxState> {

// Check to see if the user typed an exact match
if (this._indexWithinBounds(currentOptions, currentPendingValueValidIndex)) {
const pendingOptionText: string = currentOptions[currentPendingValueValidIndex].text.toLocaleLowerCase();
const pendingOptionText: string = this._getPreviewText(currentOptions[currentPendingValueValidIndex]).toLocaleLowerCase(); // jeremy

@christiango christiango May 31, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the comment here


// By exact match, that means: our pending value is the same as the the pending option text OR
// the pending option starts with the pending value and we have an "autoComplete" selection
Expand Down