Allow for more control over event handling for keytips#5064
Merged
jspurlin merged 5 commits intomicrosoft:masterfrom Jun 1, 2018
Merged
Allow for more control over event handling for keytips#5064jspurlin merged 5 commits intomicrosoft:masterfrom
jspurlin merged 5 commits intomicrosoft:masterfrom
Conversation
- Pass through event to onExitKeytipMode - Don't automatically cancel the event on exit key, leave up to the developer
jspurlin
approved these changes
Jun 1, 2018
changing to a minor change since this extends a few existing APIs
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 2, 2018
* master: (274 commits) Demo Page Refactor Part 1 (microsoft#5055) SplitButton: Add aria-roledescription (microsoft#5062) Add addins sketch toolkit link (microsoft#5052) Dropdown title (microsoft#4983) Allow for more control over event handling for keytips (microsoft#5064) Build time speed improvements (microsoft#4965) Coachmark: Positioning fixes (microsoft#4995) Applying package updates. Experiments/Nav component: display "show more" link only if there is atleast one hidden link (microsoft#5057) Add pointerup listener to exit keytip mode (microsoft#5051) Update PULL_REQUEST_TEMPLATE.md Update ISSUE_TEMPLATE.md Shimmer: resolve conflicts (microsoft#5034) Invalid ARIA attributes: Fix empty values (microsoft#5040) ComboBox: Correct invalid ARIA attributes. (microsoft#4873) (microsoft#5001) ComboBox: Fix submit pending value (microsoft#5048) FocusTrapZone - restore last focused descendant element (microsoft#4897) Applying package updates. Take 2 of the require.resolve change. This time using the "resolve" pkg (microsoft#5031) fixing webpack config to allow rush build to complete on a small VM (microsoft#5037) ...
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 3, 2018
* master: (111 commits) Moving a variable to be defined sooner so that it is there when failures occur. Fix icon imports (microsoft#5069) MessageBar: More visible HC color for dismiss and expand buttons (microsoft#5061) Fix DetailsList accessibility and add more ARIA hooks (microsoft#5066) Update jest (microsoft#5068) Demo Page Refactor Part 1 (microsoft#5055) SplitButton: Add aria-roledescription (microsoft#5062) Add addins sketch toolkit link (microsoft#5052) Dropdown title (microsoft#4983) Allow for more control over event handling for keytips (microsoft#5064) Build time speed improvements (microsoft#4965) Coachmark: Positioning fixes (microsoft#4995) Applying package updates. Experiments/Nav component: display "show more" link only if there is atleast one hidden link (microsoft#5057) Add pointerup listener to exit keytip mode (microsoft#5051) Update PULL_REQUEST_TEMPLATE.md Update ISSUE_TEMPLATE.md Shimmer: resolve conflicts (microsoft#5034) Invalid ARIA attributes: Fix empty values (microsoft#5040) ComboBox: Correct invalid ARIA attributes. (microsoft#4873) (microsoft#5001) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run change: yesDescription of changes
For the onExecute and onReturn callback methods for Keytips we will now pass through both relevant marked elements (the ones marked with data-ktp-execute-target and data-ktp-target). Previously we were just passing through the one marked with data-ktp-execute-target. This comes into play mostly when those two elements are different; for example, a Split Button should execute the secondary button but when dealing with focus the correct behavior is to focus the entire container (which is element marked with data-ktp-target). This change allows a developer to more easily implement their desired behavior when a keytip has been executed or has been returned to
The other change is to not automatically preventDefault any keys that trigger a keytip exit call (Tab, arrow keys, etc). Instead, the event triggering the exit is now passed through to onExitKeytipMode so that if the developer wishes to cancel that event manually they can. This allows the event by default to propagate so regular keyboarding actions will happen when a user hits those keys. This event will be undefined if the exit was called manually from KeytipManager
Focus areas to test
Tested for general functionality to ensure that nothing was broken. Tested that events propagate after exiting (hitting Tab will move to the next focused element)
Microsoft Reviewers: Open in CodeFlow