Improvements for auto-select opt-in mode#4914
Merged
ThomasMichon merged 3 commits intomicrosoft:masterfrom May 23, 2018
Merged
Conversation
dzearing
reviewed
May 18, 2018
| <button id='invoke1' data-selection-invoke={ true }>Invoke</button> | ||
| <button id='noSelect1'>No Select</button> | ||
| <button id='select1' data-selection-select={ true }>Select First</button> | ||
| <button id='select1' data-selection-auto-select={ true }>Select First</button> |
Member
There was a problem hiding this comment.
this is too verbose. Why this change?
Member
There was a problem hiding this comment.
I also think selection-select is redundant with no obvious reasoning, though
Member
There was a problem hiding this comment.
I spoke with David now and am agreeing with him now.. it's a select type like toggle. 😆
JasonGore
reviewed
May 18, 2018
| onItemInvoked={ onItemInvoked } | ||
| onItemContextMenu={ onItemContextMenu } | ||
| enterModalOnTouch={ this.props.enterModalSelectionOnTouch } | ||
| { ...(selectionZoneProps || {}) } |
Member
There was a problem hiding this comment.
Is {} needed? Spreading undefined object should be ok
Member
Author
There was a problem hiding this comment.
According to ES6, {} is needed because otherwise it would fail. TypeScript's implementation just doesn't fail, though.
Edit: clarified language.
JasonGore
reviewed
May 18, 2018
| } else if ( | ||
| (target === itemRoot || | ||
| this._hasAttribute(target, SELECTION_AUTO_SELECT_ATTRIBUTE_NAME) || | ||
| this._hasAttribute(target, SELECTION_SELECT_ATTRIBUTE_NAME)) |
Member
There was a problem hiding this comment.
Should this check for the new attribute be in _onKeyDown too?
JasonGore
approved these changes
May 23, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 29, 2018
* master: Applying package updates. Shimmer: refactor in preparation for migration to OUFR (microsoft#4958) Applying package updates. Theming: fix error colors (microsoft#4969) MaskedTextField: Added event callback passthrough (microsoft#4956) Experiments/Nav component: Enable auto expand until the next manual expand disables the auto expand (microsoft#4996) Applying package updates. Experiments/Nav component: Auto select/expand based on the selectedKey prop (microsoft#4984) StickyPane: fix Array.from in Ie (microsoft#4982) ContextualMenu has aria-labelledBy referencing element not in DOM (microsoft#4963) Keyboard support for the slim version of experiments/Nav component and added aria attributes (microsoft#4981) Move ghdocs to wiki (microsoft#4977) Remove build artifacts (microsoft#4976) Revisited the Multi-select Combo box initial state selection fix (microsoft#4884) Applying package updates. readme cleanup (microsoft#4972) Theming: add the bodyBackgroundDarker semantic slot (microsoft#4957) Improvements for auto-select opt-in mode (microsoft#4914)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 29, 2018
* master: (85 commits) Applying package updates. Shimmer: refactor in preparation for migration to OUFR (microsoft#4958) Applying package updates. Theming: fix error colors (microsoft#4969) MaskedTextField: Added event callback passthrough (microsoft#4956) Experiments/Nav component: Enable auto expand until the next manual expand disables the auto expand (microsoft#4996) Applying package updates. Experiments/Nav component: Auto select/expand based on the selectedKey prop (microsoft#4984) StickyPane: fix Array.from in Ie (microsoft#4982) ContextualMenu has aria-labelledBy referencing element not in DOM (microsoft#4963) Keyboard support for the slim version of experiments/Nav component and added aria attributes (microsoft#4981) Move ghdocs to wiki (microsoft#4977) Remove build artifacts (microsoft#4976) Revisited the Multi-select Combo box initial state selection fix (microsoft#4884) Applying package updates. readme cleanup (microsoft#4972) Theming: add the bodyBackgroundDarker semantic slot (microsoft#4957) Improvements for auto-select opt-in mode (microsoft#4914) Applying package updates. Revert ChoiceGroup change in 5.0 to minimize potential partner impact. (microsoft#4962) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change adds non-breaking improvements to #4907:
selectionZonePropsthroughDetailsListto avoid having to pass each prop individually.data-selection-auto-selectas a preferred alias fordata-selection-selectto match original proposal in Hyperlink clicks aren't selecting items in SelectionZone (Disabled in PR 4544) #4866.