Skip to content

readme cleanup#4972

Merged
micahgodbolt merged 1 commit intomicrosoft:masterfrom
micahgodbolt:readme-cleanup
May 24, 2018
Merged

readme cleanup#4972
micahgodbolt merged 1 commit intomicrosoft:masterfrom
micahgodbolt:readme-cleanup

Conversation

@micahgodbolt
Copy link
Copy Markdown
Member

@micahgodbolt micahgodbolt commented May 24, 2018

i'm doing some more updates to the readme, but I found a number of issues and small tweaks to do first.

Issues include a number of broken links, unnecessary documentation (moved to wiki) and other simplifications.

Microsoft Reviewers: Open in CodeFlow

@JasonGore
Copy link
Copy Markdown
Member

Wouldn't it be easier to consolidate with Wiki before doing cleanup and changes?

@micahgodbolt
Copy link
Copy Markdown
Member Author

But these are broken now :)

@micahgodbolt
Copy link
Copy Markdown
Member Author

is a changefile necessary (or even desired) for an update to the site's readme? No packages got bumped.

@JasonGore
Copy link
Copy Markdown
Member

JasonGore commented May 24, 2018

Yeah but we're just going to have to change all the links AGAIN when we bring them over to the wiki...

@micahgodbolt micahgodbolt merged commit 83af6fb into microsoft:master May 24, 2018
@micahgodbolt micahgodbolt deleted the readme-cleanup branch May 24, 2018 16:24
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request May 29, 2018
* master:
  Applying package updates.
  Shimmer: refactor in preparation for migration to OUFR (microsoft#4958)
  Applying package updates.
  Theming: fix error colors (microsoft#4969)
  MaskedTextField: Added event callback passthrough (microsoft#4956)
  Experiments/Nav component: Enable auto expand until the next manual expand disables the auto expand (microsoft#4996)
  Applying package updates.
  Experiments/Nav component: Auto select/expand based on the selectedKey prop (microsoft#4984)
  StickyPane: fix Array.from in Ie (microsoft#4982)
  ContextualMenu has aria-labelledBy referencing element not in DOM (microsoft#4963)
  Keyboard support for the slim version of experiments/Nav component and added aria attributes (microsoft#4981)
  Move ghdocs to wiki (microsoft#4977)
  Remove build artifacts (microsoft#4976)
  Revisited the Multi-select Combo box initial state selection fix (microsoft#4884)
  Applying package updates.
  readme cleanup (microsoft#4972)
  Theming: add the bodyBackgroundDarker semantic slot (microsoft#4957)
  Improvements for auto-select opt-in mode (microsoft#4914)
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request May 29, 2018
* master: (85 commits)
  Applying package updates.
  Shimmer: refactor in preparation for migration to OUFR (microsoft#4958)
  Applying package updates.
  Theming: fix error colors (microsoft#4969)
  MaskedTextField: Added event callback passthrough (microsoft#4956)
  Experiments/Nav component: Enable auto expand until the next manual expand disables the auto expand (microsoft#4996)
  Applying package updates.
  Experiments/Nav component: Auto select/expand based on the selectedKey prop (microsoft#4984)
  StickyPane: fix Array.from in Ie (microsoft#4982)
  ContextualMenu has aria-labelledBy referencing element not in DOM (microsoft#4963)
  Keyboard support for the slim version of experiments/Nav component and added aria attributes (microsoft#4981)
  Move ghdocs to wiki (microsoft#4977)
  Remove build artifacts (microsoft#4976)
  Revisited the Multi-select Combo box initial state selection fix (microsoft#4884)
  Applying package updates.
  readme cleanup (microsoft#4972)
  Theming: add the bodyBackgroundDarker semantic slot (microsoft#4957)
  Improvements for auto-select opt-in mode (microsoft#4914)
  Applying package updates.
  Revert ChoiceGroup change in 5.0 to minimize potential partner impact. (microsoft#4962)
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants