SelectionZone: Fix 'select-on-click' behavior to be opt-out for buttons#4907
Merged
dzearing merged 3 commits intomicrosoft:masterfrom May 17, 2018
Merged
SelectionZone: Fix 'select-on-click' behavior to be opt-out for buttons#4907dzearing merged 3 commits intomicrosoft:masterfrom
dzearing merged 3 commits intomicrosoft:masterfrom
Conversation
dzearing
approved these changes
May 17, 2018
Member
This was referenced May 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A previous PR, #4544, caused a breaking change in the behavior of
SelectionZone, because teams were relying on the select-on-mouse-down behavior before input elements were clicked within selectable regions.This PR fixes that issue by putting the 'disable-auto-select' behavior behind a prop, and then adds a per-element
data-selection-selectattribute to enable the auto-select-on-mousedown for target elements if that prop is also set.Added unit tests and documentations for the new behaviors, with examples.