Merged
Conversation
Contributor
Author
|
@dzearing what do I do for screener changes? These are our official error colors @betrue-final-final |
Member
|
@phkuo, you let the screener person check it out. |
Member
|
Looks like the new critical error color is too dark. I assume that it's for dark theme. Let me check and see if there was some work we did to balance between light and dark theme. |
Member
|
|
Contributor
Author
|
@betrue-final-final |
Member
|
Yes, I wondered. You're correct. Ok I'll ok screener. |
MBSilverstein
approved these changes
May 24, 2018
joschect
approved these changes
May 25, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 29, 2018
* master: Applying package updates. Shimmer: refactor in preparation for migration to OUFR (microsoft#4958) Applying package updates. Theming: fix error colors (microsoft#4969) MaskedTextField: Added event callback passthrough (microsoft#4956) Experiments/Nav component: Enable auto expand until the next manual expand disables the auto expand (microsoft#4996) Applying package updates. Experiments/Nav component: Auto select/expand based on the selectedKey prop (microsoft#4984) StickyPane: fix Array.from in Ie (microsoft#4982) ContextualMenu has aria-labelledBy referencing element not in DOM (microsoft#4963) Keyboard support for the slim version of experiments/Nav component and added aria attributes (microsoft#4981) Move ghdocs to wiki (microsoft#4977) Remove build artifacts (microsoft#4976) Revisited the Multi-select Combo box initial state selection fix (microsoft#4884) Applying package updates. readme cleanup (microsoft#4972) Theming: add the bodyBackgroundDarker semantic slot (microsoft#4957) Improvements for auto-select opt-in mode (microsoft#4914)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 29, 2018
* master: (85 commits) Applying package updates. Shimmer: refactor in preparation for migration to OUFR (microsoft#4958) Applying package updates. Theming: fix error colors (microsoft#4969) MaskedTextField: Added event callback passthrough (microsoft#4956) Experiments/Nav component: Enable auto expand until the next manual expand disables the auto expand (microsoft#4996) Applying package updates. Experiments/Nav component: Auto select/expand based on the selectedKey prop (microsoft#4984) StickyPane: fix Array.from in Ie (microsoft#4982) ContextualMenu has aria-labelledBy referencing element not in DOM (microsoft#4963) Keyboard support for the slim version of experiments/Nav component and added aria attributes (microsoft#4981) Move ghdocs to wiki (microsoft#4977) Remove build artifacts (microsoft#4976) Revisited the Multi-select Combo box initial state selection fix (microsoft#4884) Applying package updates. readme cleanup (microsoft#4972) Theming: add the bodyBackgroundDarker semantic slot (microsoft#4957) Improvements for auto-select opt-in mode (microsoft#4914) Applying package updates. Revert ChoiceGroup change in 5.0 to minimize potential partner impact. (microsoft#4962) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The old error color slots were sharing names with the new semantic ones, but had different default values. So an unthemed site would have the old colors, but theming it to the default theme should leave them the same, but instead updated them to the new semantic slot's values.
For the fix, I've updated the theme overrides to use the new semantic token names so that they will update correctly in the future.
Focus areas to test
MessageBar
Microsoft Reviewers: Open in CodeFlow