Adding option for focus on tags in disabled picker#4833
Merged
mdahamiwal merged 3 commits intomicrosoft:masterfrom May 21, 2018
Merged
Adding option for focus on tags in disabled picker#4833mdahamiwal merged 3 commits intomicrosoft:masterfrom
mdahamiwal merged 3 commits intomicrosoft:masterfrom
Conversation
joschect
reviewed
May 10, 2018
| onItemChange?: (item: T, index: number) => void; | ||
| key?: string | number; | ||
| removeButtonAriaLabel?: string; | ||
| enableTagFocusInDisabledPicker?: boolean; |
Contributor
There was a problem hiding this comment.
Since this is the generic PickerItem, name this something more generic.
Contributor
Author
There was a problem hiding this comment.
I could name it something generic like enableItemFocusInDisabledPicker.
But this prop is only being used in tagItem and a generic name could be misleading.
Shall I update it then?
Contributor
There was a problem hiding this comment.
If it's only used in tagItem, then it should be passed through the tag item props. If it's something that all picker items should have, then it should be added here. The picker is meant to be extensible. PickerItemProps is the base that all items have access to.
Contributor
Author
|
I have made the required changes. |
joschect
approved these changes
May 17, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 23, 2018
* master: (67 commits) Applying package updates. Revert ChoiceGroup change in 5.0 to minimize potential partner impact. (microsoft#4962) Applying package updates. ChoiceGroup: getStyles conversion (microsoft#4852) Export SASS variables and mixins (microsoft#4959) Variants: update algorithm (microsoft#4949) Allow for customization of keycodes that cause the focus rect to appear (microsoft#4948) Mergestyles facepile (microsoft#4950) Fixing circular dependency and non-AMD references in ContextualMenu (microsoft#4946) Clean up semantic slots (microsoft#4932) Added missing merge-styles background-size typing (microsoft#4935) Applying package updates. Split menu button styles (microsoft#4922) Experimental Chiclet Component (microsoft#4678) Remove hover and pressed background colors (microsoft#4908) Remove @cschleiden as Rating code owner (microsoft#4929) Addressing Issue microsoft#3691 - SplitButton: In Safari, the SplitButton has mismatched heights (microsoft#4797) Applying package updates. Adding option for focus on tags in disabled picker (microsoft#4833) Jest merge-styles serialization fix for animation-name (microsoft#4927) ...
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Added an additional optional prop for allowing focus on tagitem when the picker is disabled.
Focus areas to test