Fixing circular dependency and non-AMD references in ContextualMenu#4946
Merged
joschect merged 2 commits intomicrosoft:masterfrom May 22, 2018
serkan-inci:master
Merged
Fixing circular dependency and non-AMD references in ContextualMenu#4946joschect merged 2 commits intomicrosoft:masterfrom serkan-inci:master
joschect merged 2 commits intomicrosoft:masterfrom
serkan-inci:master
Conversation
joschect
approved these changes
May 22, 2018
Contributor
|
Thanks! |
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 23, 2018
* master: (67 commits) Applying package updates. Revert ChoiceGroup change in 5.0 to minimize potential partner impact. (microsoft#4962) Applying package updates. ChoiceGroup: getStyles conversion (microsoft#4852) Export SASS variables and mixins (microsoft#4959) Variants: update algorithm (microsoft#4949) Allow for customization of keycodes that cause the focus rect to appear (microsoft#4948) Mergestyles facepile (microsoft#4950) Fixing circular dependency and non-AMD references in ContextualMenu (microsoft#4946) Clean up semantic slots (microsoft#4932) Added missing merge-styles background-size typing (microsoft#4935) Applying package updates. Split menu button styles (microsoft#4922) Experimental Chiclet Component (microsoft#4678) Remove hover and pressed background colors (microsoft#4908) Remove @cschleiden as Rating code owner (microsoft#4929) Addressing Issue microsoft#3691 - SplitButton: In Safari, the SplitButton has mismatched heights (microsoft#4797) Applying package updates. Adding option for focus on tags in disabled picker (microsoft#4833) Jest merge-styles serialization fix for animation-name (microsoft#4927) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
There were problematic references under ContextualMenu:
Files under ContextualMenu were referencing root file which is causing circular dependent references. I believe, references like "OfficeFabric/Component" should only be used outside of the component itself.
There were references to the component folders which is causing issues for AMD since there is no corresponding file (fine for node module resolution since it resolves to Componet/index).
The fix just uses more specific references.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow