Skip to content

Adding option for focus on tags in disabled picker #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdahamiwal merged 3 commits into from
May 21, 2018
Merged

Adding option for focus on tags in disabled picker #4833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
872270a
Adding option for focus on tags in disabled picker
veloiya May 10, 2018
c6ab0be
Adding change request file
veloiya May 10, 2018
8561595
Moving the prop to ITagItemProps from IPickerItemProps
veloiya May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/focusTagItemOnDisabledPicker_2018-05-10-06-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Added an addtional prop in IPickerItemProps for allowing focus on tagItem when picker is disabled",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "veloiya@microsoft.com"
}
8 changes: 6 additions & 2 deletions packages/office-ui-fabric-react/src/components/pickers/TagPicker/TagItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ import { ITag } from './TagPicker';
import * as stylesImport from './TagItem.scss';
const styles: any = stylesImport;

export const TagItem = (props: IPickerItemProps<ITag>) => (
export interface ITagItemProps extends IPickerItemProps<ITag> {
enableTagFocusInDisabledPicker?: boolean;
}

export const TagItem = (props: ITagItemProps) => (
<div
className={ css('ms-TagItem',
styles.root,
Expand All @@ -17,7 +21,7 @@ export const TagItem = (props: IPickerItemProps<ITag>) => (
role={ 'listitem' }
key={ props.index }
data-selection-index={ props.index }
data-is-focusable={ !props.disabled && true }
data-is-focusable={ (props.enableTagFocusInDisabledPicker || !props.disabled) && true }
>
<span className={ css('ms-TagItem-text', styles.tagItemText) } aria-label={ props.children as string }>{ props.children }</span>
{ !props.disabled &&
Expand Down
5 changes: 2 additions & 3 deletions packages/office-ui-fabric-react/src/components/pickers/TagPicker/TagPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ import {
/* tslint:enable */
import { BasePicker } from '../BasePicker';
import { IBasePickerProps } from '../BasePicker.types';
import { TagItem } from './TagItem';
import { IPickerItemProps } from '../PickerItem.types';
import { TagItem, ITagItemProps } from './TagItem';
import * as stylesImport from './TagItem.scss';
const styles: any = stylesImport;

Expand All @@ -21,7 +20,7 @@ export interface ITagPickerProps extends IBasePickerProps<ITag> {

export class TagPicker extends BasePicker<ITag, ITagPickerProps> {
protected static defaultProps = {
onRenderItem: (props: IPickerItemProps<ITag>) => { return <TagItem { ...props }>{ props.item.name }</TagItem>; },
onRenderItem: (props: ITagItemProps) => { return <TagItem { ...props }>{ props.item.name }</TagItem>; },
onRenderSuggestionsItem: (props: ITag) => <div className={ css('ms-TagItem-TextOverflow', styles.tagItemTextOverflow) }> { props.name } </div>
};
}