Added className to Calendar component #4563
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishgarg1
reviewed
Apr 16, 2018
| */ | ||
| componentRef?: (component: ICalendar | null) => void; | ||
|
|
||
| /** Optional class name to add to the root element. */ |
Collaborator
There was a problem hiding this comment.
/** [](start = 2, length = 3)
Please make the comment to be multi line. Like
/**
- blah blah blah...
*/
Collaborator
|
Otherwise looks good to me. @dzearing any concerns? |
Contributor
Author
|
Fixed comment (however, I copied that comment from another component in the Office UI React Framework... 😄) |
* Do not call onMenuClick on every keyDown * Add change file * Simplify if condition * Don't ignore default key down handling
manishgarg1
approved these changes
Apr 16, 2018
jordandrako
suggested changes
Apr 17, 2018
| dateRangeType={ DateRangeType.Week } | ||
| autoNavigateOnSelection={ true } | ||
| onSelectDate={ onSelectDate() } | ||
| className="CalendarTestClass" |
Contributor
There was a problem hiding this comment.
Travis is failing due to the double quote marks. Change all " to ' for it to pass.
…icrosoft#4574) * Async registration of styling. * Adding change file.
* Fixing build. * Updating sass because of load order differences. * more visual bug fixes. * Tweaking css.
* Make titles on GetStarted page clickable * Added change file
* Fixed improper imports from index files * Update change output
* Mark Panel content element as scrollable * Update change output
…osoft#4512) * Convert getting started page and status page. * First wave of MD files. * Use markdown in example page wave 1 * Wave 2 * Initial code owners * Wave 3 * changes * Fix Persona owners * Add link to Icon docs to IconButton * Use component page for Theme page * Better themes documentation. * remove commented code * clean * nit * Add opt-in for @deprecated comments for documentation. * Add section on loading themes to Overview. * Fix mutating state to get rid of console error * Switch to getTheme from loadTheme, add not for deprecated colors. * changes * remove console.logs * Fix code block line height * changes
* Fixes some imports in NavPage causing some build errors. * Rush change.
… set to avoid item is undefined in handler (microsoft#4568) * Invoke CommandBar's onItemClick vs item onClick when href set * Append anchor element type to end of union type * + changelog
* ContextualMenu: Update mousemove to only do anything if there is not another pending mouse enter/move/leave to improve the snappiness of the updates * rush change * change spacing * Make sure we are clearing the enterTimerId after executing in the settimeout * fix missing line to set enterTimerId back to undefined if the item does not have a submenu
* Scaffold styles file * Split to base file. * Scaffold types file. * Export base
* Updating how style elements are injected (to preserve the location in head in which they're inserted.) * adding change file * Adding nit fixes.
Contributor
|
Hello @lafe, could you resolve the merge conflict and let's see if CI passes this time so we can get this merged in? :) |
…ers firing twice (microsoft#4662) * Gate calendar month, year, and today keydowns for only ENTER as onClick handles space with button nodes. * + changefile
* Revert "FocusTrapZone does not correctly trap focus when last child is FocusZone (microsoft#4172)" This reverts commit 699fa69. * minor picker fixes * adding change file * Undo change to examples * Fix typo * remove space
* Utilize typescript's no_unused_vars rather than tslint's + cleanup * Change file * Change the way the "demo" code is preserved
* Fix props validation for Breadcrumb and add unit tests for default props * Update snapshot output * Update change output * Fix Breadcrumb validation
* Scaffold styles file * Split to base file. * Scaffold types file. * Export base * Add `animation` to `IRawStyleBase` * Convert sass to js. Add barHeight prop. * Use classNames instead of scss in base * Delete sass file * let styles default barHeight * Fix RTL keyframes * changes * Update snapshots * Fix more conflicts * Switch to private _classNames set in constructor to prevent tag spam * Remove smoothTransition style prop * Remove unused variables * Update snapshot * simplify * Fix classNames being called with keyframes. * update snapshot
lafe
requested review from
Jahnp,
KatherineThayerMicrosoft,
ThomasMichon,
aditima,
atneik,
cschleiden,
dzearing,
joschect,
micahgodbolt,
mikewheaton,
phkuo,
srideshpande and
yiminwu
as code owners
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
This change adds an optional "
className" property to theICalendarPropsinterface. If a class is specified, it will be added to the root element of theCalendarcomponent.