-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Added className to Calendar component #4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
a113dcd
Added className to Calendar root (see #4514)
lafe 7df10cd
Added Change Request File
lafe 526f93d
Applying package updates.
68d99e2
Adding scss temp files to the clean script to avoid surprises when sy…
dzearing 5131956
Changed single line comment to multi line comment
lafe 5ab4612
Fix for onMenuClick firing on every keyDown (#4557)
Markionium 98c5903
Applying package updates.
68acb9b
mergeStyles: asynchronously reset the next style element being used (…
dzearing 08644fa
Changed double quotes to single quotes
lafe cc4d585
Missed one double quotation
lafe 3c5e9c9
Fixing build. (#4579)
dzearing 8829b1f
Website: Make titles on GetStarted page clickable (#4570)
lynamemi 5867a69
Disable bundlesize in Travis workflow to unblock PRs.
dzearing 4dc9071
Fix improper imports from index files (#4585)
ThomasMichon 7ed1f9d
Mark Panel content as scrollable (#4577)
ThomasMichon b6c7ac2
Applying package updates.
4efff92
Docs: Convert document Overviews and Best Practices to markdown (#4512)
jordandrako 7dabb13
Experiments: fix bad imports (#4580)
Vitalius1 9e838b8
Invoke CommandBar's onItemClick vs item onClick when item has an href…
KevinTCoughlin e176966
Applying package updates.
9cc47f5
ContextualMenu: Update mousemove behavior (#4589)
jspurlin 1b45279
ProgressIndicator: convert to mergeStyles - part 1 (#4592)
jordandrako c49c51c
Applying package updates.
7c592e9
Choicegroup: Improved states for focus, HC focus, HC hover (#4572)
lynamemi 5f6ae67
Searchbox: Clicking in front of input text puts cursor at the start o…
lynamemi 7d06629
ActivityItem: add pulsing beacon animation (#4553)
lynamemi 9686b87
Fixes invalid aria-owns/ activedescendant attributes on BasePicker (#…
rfballantyne dfc9c2c
Fix more index imports (#4604)
ThomasMichon 9a47213
Reenable bundlesize in yaml (#4590)
erichdev 5610079
Applying package updates.
775e1f5
Add optional overflowIndex prop to Breadcrumb (#4609)
samuelmtimbo 5954ea4
Remove unused variables and enable no-unused-variable (#4608)
Markionium 6c70a9e
Fix minor typos (#4607)
cliffkoh 88c0a7c
Update Breadcrumb.base.tsx
dzearing e77a31b
Update createRef to match the new React 16.3 api (#4598)
Markionium c86fc5b
Remove usage of Number.NaN (#4615)
christiango 02b098f
ComboBox: Add any event as additional parameter to onChanged callback…
chang47 88a6620
Applying package updates.
bd2e7b1
[TextField] Implemented masking (#3783)
lambertwang b6c5fde
DetailsRow: Flexshrink fix (#4622)
dzearing ef0cfe4
Revert unintended changes in Dropdown from #4512 (#4625)
jordandrako 365de61
Remove tslint ignore of React (#4614)
Markionium f2dc9cb
Addressing Issue #4349 - Data attributes on Pivot Item (#4461)
oengusmacinog-zz ffd046e
Addressing Issue #3634 - Accessibility: Panel should have aria-labell…
oengusmacinog-zz 5cab1cf
add onRenderDescription to TextField (#4588)
chrismohr 9c95e9b
Typedef tslint rule fixes (ready to merge) (#4573)
Markionium 0496c5f
Applying package updates.
1c60fae
Propagate onRenderInitials correctly from Persona to PersonaCoin (#4…
ivdijan bcfcbd3
Addressing Issue #4454 - Readonly rating control with null rating sho…
oengusmacinog-zz 65c2b22
Added changefile for inputmask utility change (#4641)
lambertwang 5ee5b00
CalloutExample: Fix basic callout example so it correctly positions. …
joschect d8c8e6f
ContexualMenuItem: Add onRenderIcon prop to allow override icon rende…
yiminwu 703efd3
Shimmer: adding new props. (#4596)
Vitalius1 602a5b9
Add selected item add/delete callback, expose item methods (#4636)
amyngu 54ae9f9
Applying package updates.
0a91cdc
Route ARIA label for 'remove suggestion' button (#4543)
ThomasMichon 15ac345
Fix a typo in NewComponent.md (#4633)
cliffkoh edf4590
Fix tslint issues in experiment - make it consistent with the product…
cliffkoh af62e60
focusTrapZone stealing focus on close when focus wasn't inside of it …
lorejoh12 cf2fcbc
Fix index import for CommandBar (#4645)
ThomasMichon 2bbc795
Removing the ms-Fabric classname from being added to body (#4628)
dzearing 57d14eb
ContextualMenu: setting font to theme font (#4646)
dzearing bf655ce
Jest snapshots: classes in animations should autoexpand. (#4647)
dzearing 6f66dfa
Remove unused iconClassName prop from Nav.types (#4634)
KevinTCoughlin 6909a93
Applying package updates.
8d297e2
Use the `data-is-scrollable` attribute on the correct ScrollablePane …
elliottsj 707e538
Pivot: convert to mergeStyles - part 1 (#4656)
jordandrako a15bb06
Remove wordWrap setting. (#4657)
jordandrako 829a526
Jolore/calendar updates (#4643)
lorejoh12 6648a74
Applying package updates.
802a2c0
Fix theme slots for DetailsList header colors (#4658)
ThomasMichon 56c4cfb
Fix input type for Tile ARIA label prop (#4668)
ThomasMichon 127d4d9
Addressing Issue #3707 - OverflowSet: Add the ability to set aria-lab…
oengusmacinog-zz 6bfddc1
Fabric component: revert class change and make it backwards compatibl…
dzearing 1d305b5
Merge styles order (#4664)
dzearing fee79fb
Applying package updates.
0ee2136
Fix Calendar component PREV/NEXT month, year, and "Go to today" handl…
KevinTCoughlin a59edf9
Picker/Autofill: fixes several minor bugs. (#4569)
joschect ea79638
No unused vars part of ts (#4670)
cliffkoh 5e99f2d
Fix props validation for Breadcrumb (#4666)
ThomasMichon b9f6e84
ProgressIndicator: Finish conversion to mergeStyles (#4595)
jordandrako 48e8681
Added className to Calendar root (see #4514)
lafe 2f38861
Added Change Request File
lafe d63880d
Changed single line comment to multi line comment
lafe 0bed016
Changed double quotes to single quotes
lafe a173eba
Missed one double quotation
lafe e53c5fb
Merge branch 'ClassName' of https://github.com/lafe/office-ui-fabric-…
lafe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
common/changes/office-ui-fabric-react/ClassName_2018-04-16-07-21.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Added optional className property to Calendar", | ||
| "type": "minor" | ||
| } | ||
| ], | ||
| "packageName": "office-ui-fabric-react", | ||
| "email": "aur@gmx.de" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,9 @@ export interface ICalendarProps extends React.Props<Calendar> { | |
| */ | ||
| componentRef?: (component: ICalendar | null) => void; | ||
|
|
||
| /** Optional class name to add to the root element. */ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Please make the comment to be multi line. Like /**
|
||
| className?: string; | ||
|
|
||
| /** | ||
| * Callback issued when a date is selected | ||
| * @param date - The date the user selected | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis is failing due to the double quote marks. Change all
"to'for it to pass.