Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
a113dcd
Added className to Calendar root (see #4514)
lafe Apr 16, 2018
7df10cd
Added Change Request File
lafe Apr 16, 2018
526f93d
Applying package updates.
Apr 16, 2018
68d99e2
Adding scss temp files to the clean script to avoid surprises when sy…
dzearing Apr 16, 2018
5131956
Changed single line comment to multi line comment
lafe Apr 16, 2018
5ab4612
Fix for onMenuClick firing on every keyDown (#4557)
Markionium Apr 16, 2018
98c5903
Applying package updates.
Apr 16, 2018
68acb9b
mergeStyles: asynchronously reset the next style element being used (…
dzearing Apr 17, 2018
08644fa
Changed double quotes to single quotes
lafe Apr 17, 2018
cc4d585
Missed one double quotation
lafe Apr 17, 2018
3c5e9c9
Fixing build. (#4579)
dzearing Apr 17, 2018
8829b1f
Website: Make titles on GetStarted page clickable (#4570)
lynamemi Apr 17, 2018
5867a69
Disable bundlesize in Travis workflow to unblock PRs.
dzearing Apr 17, 2018
4dc9071
Fix improper imports from index files (#4585)
ThomasMichon Apr 17, 2018
7ed1f9d
Mark Panel content as scrollable (#4577)
ThomasMichon Apr 17, 2018
b6c7ac2
Applying package updates.
Apr 17, 2018
4efff92
Docs: Convert document Overviews and Best Practices to markdown (#4512)
jordandrako Apr 17, 2018
7dabb13
Experiments: fix bad imports (#4580)
Vitalius1 Apr 17, 2018
9e838b8
Invoke CommandBar's onItemClick vs item onClick when item has an href…
KevinTCoughlin Apr 17, 2018
e176966
Applying package updates.
Apr 18, 2018
9cc47f5
ContextualMenu: Update mousemove behavior (#4589)
jspurlin Apr 18, 2018
1b45279
ProgressIndicator: convert to mergeStyles - part 1 (#4592)
jordandrako Apr 18, 2018
c49c51c
Applying package updates.
Apr 18, 2018
7c592e9
Choicegroup: Improved states for focus, HC focus, HC hover (#4572)
lynamemi Apr 18, 2018
5f6ae67
Searchbox: Clicking in front of input text puts cursor at the start o…
lynamemi Apr 18, 2018
7d06629
ActivityItem: add pulsing beacon animation (#4553)
lynamemi Apr 18, 2018
9686b87
Fixes invalid aria-owns/ activedescendant attributes on BasePicker (#…
rfballantyne Apr 18, 2018
dfc9c2c
Fix more index imports (#4604)
ThomasMichon Apr 18, 2018
9a47213
Reenable bundlesize in yaml (#4590)
erichdev Apr 18, 2018
5610079
Applying package updates.
Apr 19, 2018
775e1f5
Add optional overflowIndex prop to Breadcrumb (#4609)
samuelmtimbo Apr 19, 2018
5954ea4
Remove unused variables and enable no-unused-variable (#4608)
Markionium Apr 19, 2018
6c70a9e
Fix minor typos (#4607)
cliffkoh Apr 19, 2018
88c0a7c
Update Breadcrumb.base.tsx
dzearing Apr 19, 2018
e77a31b
Update createRef to match the new React 16.3 api (#4598)
Markionium Apr 19, 2018
c86fc5b
Remove usage of Number.NaN (#4615)
christiango Apr 19, 2018
02b098f
ComboBox: Add any event as additional parameter to onChanged callback…
chang47 Apr 19, 2018
88a6620
Applying package updates.
Apr 19, 2018
bd2e7b1
[TextField] Implemented masking (#3783)
lambertwang Apr 19, 2018
b6c5fde
DetailsRow: Flexshrink fix (#4622)
dzearing Apr 19, 2018
ef0cfe4
Revert unintended changes in Dropdown from #4512 (#4625)
jordandrako Apr 20, 2018
365de61
Remove tslint ignore of React (#4614)
Markionium Apr 20, 2018
f2dc9cb
Addressing Issue #4349 - Data attributes on Pivot Item (#4461)
oengusmacinog-zz Apr 20, 2018
ffd046e
Addressing Issue #3634 - Accessibility: Panel should have aria-labell…
oengusmacinog-zz Apr 20, 2018
5cab1cf
add onRenderDescription to TextField (#4588)
chrismohr Apr 20, 2018
9c95e9b
Typedef tslint rule fixes (ready to merge) (#4573)
Markionium Apr 20, 2018
0496c5f
Applying package updates.
Apr 20, 2018
1c60fae
Propagate onRenderInitials correctly from Persona to PersonaCoin (#4…
ivdijan Apr 20, 2018
bcfcbd3
Addressing Issue #4454 - Readonly rating control with null rating sho…
oengusmacinog-zz Apr 20, 2018
65c2b22
Added changefile for inputmask utility change (#4641)
lambertwang Apr 20, 2018
5ee5b00
CalloutExample: Fix basic callout example so it correctly positions. …
joschect Apr 20, 2018
d8c8e6f
ContexualMenuItem: Add onRenderIcon prop to allow override icon rende…
yiminwu Apr 20, 2018
703efd3
Shimmer: adding new props. (#4596)
Vitalius1 Apr 20, 2018
602a5b9
Add selected item add/delete callback, expose item methods (#4636)
amyngu Apr 20, 2018
54ae9f9
Applying package updates.
Apr 20, 2018
0a91cdc
Route ARIA label for 'remove suggestion' button (#4543)
ThomasMichon Apr 20, 2018
15ac345
Fix a typo in NewComponent.md (#4633)
cliffkoh Apr 21, 2018
edf4590
Fix tslint issues in experiment - make it consistent with the product…
cliffkoh Apr 21, 2018
af62e60
focusTrapZone stealing focus on close when focus wasn't inside of it …
lorejoh12 Apr 21, 2018
cf2fcbc
Fix index import for CommandBar (#4645)
ThomasMichon Apr 21, 2018
2bbc795
Removing the ms-Fabric classname from being added to body (#4628)
dzearing Apr 22, 2018
57d14eb
ContextualMenu: setting font to theme font (#4646)
dzearing Apr 23, 2018
bf655ce
Jest snapshots: classes in animations should autoexpand. (#4647)
dzearing Apr 23, 2018
6f66dfa
Remove unused iconClassName prop from Nav.types (#4634)
KevinTCoughlin Apr 23, 2018
6909a93
Applying package updates.
Apr 23, 2018
8d297e2
Use the `data-is-scrollable` attribute on the correct ScrollablePane …
elliottsj Apr 23, 2018
707e538
Pivot: convert to mergeStyles - part 1 (#4656)
jordandrako Apr 23, 2018
a15bb06
Remove wordWrap setting. (#4657)
jordandrako Apr 24, 2018
829a526
Jolore/calendar updates (#4643)
lorejoh12 Apr 24, 2018
6648a74
Applying package updates.
Apr 24, 2018
802a2c0
Fix theme slots for DetailsList header colors (#4658)
ThomasMichon Apr 24, 2018
56c4cfb
Fix input type for Tile ARIA label prop (#4668)
ThomasMichon Apr 25, 2018
127d4d9
Addressing Issue #3707 - OverflowSet: Add the ability to set aria-lab…
oengusmacinog-zz Apr 25, 2018
6bfddc1
Fabric component: revert class change and make it backwards compatibl…
dzearing Apr 25, 2018
1d305b5
Merge styles order (#4664)
dzearing Apr 25, 2018
fee79fb
Applying package updates.
Apr 25, 2018
0ee2136
Fix Calendar component PREV/NEXT month, year, and "Go to today" handl…
KevinTCoughlin Apr 25, 2018
a59edf9
Picker/Autofill: fixes several minor bugs. (#4569)
joschect Apr 25, 2018
ea79638
No unused vars part of ts (#4670)
cliffkoh Apr 25, 2018
5e99f2d
Fix props validation for Breadcrumb (#4666)
ThomasMichon Apr 25, 2018
b9f6e84
ProgressIndicator: Finish conversion to mergeStyles (#4595)
jordandrako Apr 25, 2018
48e8681
Added className to Calendar root (see #4514)
lafe Apr 16, 2018
2f38861
Added Change Request File
lafe Apr 16, 2018
d63880d
Changed single line comment to multi line comment
lafe Apr 16, 2018
0bed016
Changed double quotes to single quotes
lafe Apr 17, 2018
a173eba
Missed one double quotation
lafe Apr 17, 2018
e53c5fb
Merge branch 'ClassName' of https://github.com/lafe/office-ui-fabric-…
lafe Apr 26, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
57 changes: 56 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ OverflowSet/ @micahgodbolt
# Overlay/
# Panel/
# Persona/
Persona/PersonaCoin.tsx @mtennoe @jakob101
Persona/PersonaCoin/ @mtennoe @jakob101
Persona/PersonaConsts.tsx @mtennoe @jakob101
pickers/ @joschect
# Pivot/
Expand All @@ -105,4 +105,59 @@ TeachingBubble/ @micahgodbolt
Toggle/ @phkuo
Tooltip/ @micahgodbolt

## Docs
# ActivityItem/docs/
# Breadcrumb/docs/
# Button/docs/
Calendar/docs/ @lorejoh12 @sathi23
Callout/docs/ @joschect
# Check/docs/
# Checkbox/docs/
ChoiceGroup/docs/ @srideshpande
# ColorPicker/docs/
# ComboBox/docs/
CommandBar/docs/ @micahgodbolt
ContextualMenu/docs/ @joschect
DatePicker/docs/ @lorejoh12 @sathi23
# DetailsList/docs/
# Dialog/docs/
DocumentCard/docs/ @yiminwu @mikewheaton
# Dropdown/docs/
# Fabric/docs/
# FacePile/docs/
# FocusTrapZone/docs/
# FocusZone/docs/
GroupedList/docs/ @aditima
HoverCard/docs/ @atneik @Jahnp
# Icon/docs/
# Image/docs/
# Label/docs/
Layer/docs/ @ThomasMichon
# Link/docs/
List/docs/ @cschleiden
# MarqueeSelection/docs/
# MessageBar/docs/
# Modal/docs/
# Nav/docs/
OverflowSet/docs/ @micahgodbolt
# Overlay/docs/
# Panel/docs/
# Persona/docs/
pickers/docs/ @joschect
# Pivot/docs/
# Popup/docs/
# ProgressIndicator/docs/
Rating/docs/ @cschleiden
ResizeGroup/docs/ @micahgodbolt
# SearchBox/docs/
# Slider/docs/
# SpinButton/docs/
# Spinner/docs/
# SwatchColorPicker/docs/
TeachingBubble/docs/ @micahgodbolt
# TextField/docs/
# Theme/docs/
Toggle/docs/ @phkuo
Tooltip/docs/ @micahgodbolt


2 changes: 1 addition & 1 deletion .npm-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.x
5.6.0
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ script:
fi
- npm run buildfast
- npm run bundlesize
- npm run vrtest
- npm run vrtest
23 changes: 16 additions & 7 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,22 @@
{
"version": "0.1.0",
"command": "gulp",
"isShellCommand": true,
"version": "2.0.0",
"tasks": [
{
"taskName": "bundle",
"isBuildCommand": true,
"showOutput": "always",
"isWatching": true
"label": "Typescript (oufr) watch",
"type": "process",
"command": "node",
"args": [
"./scripts/node_modules/typescript/bin/tsc",
"-p",
"packages/office-ui-fabric-react/tsconfig.json",
"-w",
"--noEmit"
],
"problemMatcher": "$tsc",
"group": {
"kind": "build",
"isDefault": true
}
}
]
}
38 changes: 38 additions & 0 deletions apps/fabric-website/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,44 @@
{
"name": "@uifabric/fabric-website",
"entries": [
{
"version": "5.7.0",
"tag": "@uifabric/fabric-website_v5.7.0",
"date": "Tue, 17 Apr 2018 18:47:11 GMT",
"comments": {
"minor": [
{
"author": "lynamemi <[email protected]>",
"commit": "8829b1fde1bbe2e6920b5e619727835184a15b45",
"comment": "GetStarted page: Give titles links to their corresponding pages."
}
],
"dependency": [
{
"comment": "Updating dependency \"office-ui-fabric-react\" from `>=5.82.1 <6.0.0` to `>=5.82.2 <6.0.0`"
}
]
}
},
{
"version": "5.6.1",
"tag": "@uifabric/fabric-website_v5.6.1",
"date": "Mon, 16 Apr 2018 10:23:26 GMT",
"comments": {
"patch": [
{
"author": "David Zearing <[email protected]>",
"commit": "6f8a180ae2ecca66d09be97e48e8e03cc17d4d9e",
"comment": "Updating build to React 16.3.1."
}
],
"dependency": [
{
"comment": "Updating dependency \"office-ui-fabric-react\" from `>=5.81.1 <6.0.0` to `>=5.82.0 <6.0.0`"
}
]
}
},
{
"version": "5.6.0",
"tag": "@uifabric/fabric-website_v5.6.0",
Expand Down
16 changes: 15 additions & 1 deletion apps/fabric-website/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
# Change Log - @uifabric/fabric-website

This log was last generated on Thu, 05 Apr 2018 10:15:39 GMT and should not be manually modified.
This log was last generated on Tue, 17 Apr 2018 18:47:11 GMT and should not be manually modified.

## 5.7.0
Tue, 17 Apr 2018 18:47:11 GMT

### Minor changes

- GetStarted page: Give titles links to their corresponding pages.

## 5.6.1
Mon, 16 Apr 2018 10:23:26 GMT

### Patches

- Updating build to React 16.3.1.

## 5.6.0
Thu, 05 Apr 2018 10:15:39 GMT
Expand Down
4 changes: 2 additions & 2 deletions apps/fabric-website/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@uifabric/fabric-website",
"version": "5.6.0",
"version": "5.7.0",
"description": "Reusable React components for building experiences for Office 365.",
"main": "lib/index.js",
"typings": "lib/index.d.ts",
Expand Down Expand Up @@ -39,7 +39,7 @@
"@microsoft/load-themed-styles": "^1.7.13",
"color-functions": "1.1.0",
"json-loader": "^0.5.7",
"office-ui-fabric-react": ">=5.81.1 <6.0.0",
"office-ui-fabric-react": ">=5.89.0 <6.0.0",
"tslib": "^1.7.1"
}
}
6 changes: 3 additions & 3 deletions apps/fabric-website/src/components/App/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,20 @@ export class App extends React.Component<IAppProps, any> {
};
}

public componentDidMount() {
public componentDidMount(): void {
window.addEventListener('scroll', this._handleNavPositioning);
window.addEventListener('resize', this._handleNavPositioning);

this._attachedScrollThreshold = AttachedScrollUtility.calculateAttachedScrollThreshold();
this._handleNavPositioning();
}

public componentWillUnmount() {
public componentWillUnmount(): void {
window.removeEventListener('scroll', this._handleNavPositioning);
window.removeEventListener('resize', this._handleNavPositioning);
}

public render() {
public render(): JSX.Element {
let { navHeight } = this.state;
let navPosition: 'fixed' | 'absolute' = this.state.isAttached ? 'fixed' : 'absolute';
let navStyle = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class CodeBlock extends React.Component<ICodeBlockProps, ICodeBlockState>
this._onToggleClicked = this._onToggleClicked.bind(this);
}

public render() {
public render(): JSX.Element {
let { language, isCollapsible, isLightTheme, children } = this.props;
let { isOpen } = this.state;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export interface IColorTableState {
}

export class ColorTable extends React.Component<IColorTableProps, IColorTableState> {
public render() {
public render(): JSX.Element {
let { content } = this.props;

return (
Expand Down
2 changes: 1 addition & 1 deletion apps/fabric-website/src/components/DOIcon/DOIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export class DOIcon extends React.Component<IDOIconProps, {}> {
ariaHidden: true
};

public render() {
public render(): JSX.Element {
return (
<i
className={ 'od-Icon od-Icon--' + this.props.iconClass + ' ms-bgColor-' + this.props.bgColor }
Expand Down
20 changes: 10 additions & 10 deletions apps/fabric-website/src/components/DONavigation/DONavigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
private headerel;
private navcontainerel;

public componentDidMount() {
public componentDidMount(): void {
let currentButton;
let submenu;
let currentContainer;
Expand Down Expand Up @@ -76,7 +76,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
this._processResize();
}

public render() {
public render(): JSX.Element {
return (
<div className='od-Navigation'>
<div className='od-Navigation-searchContainer'>
Expand Down Expand Up @@ -174,7 +174,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
return linkElements;
}

private _mouseMoveHandler(e) {
private _mouseMoveHandler(e): void {
let linkContainer = document.querySelector(this.OPEN_LINK_CONTAINER);
let subMenuContainer;
let targetHeight;
Expand Down Expand Up @@ -240,7 +240,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _processHamburger(e, isKeyEvent?: boolean) {
private _processHamburger(e, isKeyEvent?: boolean): void {
let linkEL: HTMLElement;
if (!this.hbuttonel.classList.contains(this.HAMBURGER_OPEN_STATE)) {
this.hbuttonel.classList.add(this.HAMBURGER_OPEN_STATE);
Expand All @@ -256,7 +256,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _closeDropdownHandler(e) {
private _closeDropdownHandler(e): void {
if (!this._isDescendant(this.headerel, document.activeElement)) {
this._removeDropdown();
}
Expand All @@ -278,7 +278,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _hamburgerHandler(e: any) {
private _hamburgerHandler(e: any): void {
if (e.keyCode) {
if (e.keyCode === 13) {
this._processHamburger(e, true);
Expand All @@ -290,7 +290,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _processMenuToggle(e) {
private _processMenuToggle(e): void {
let ancestor;
if (e.target.classList.contains(this.CONTAINER_CLASS)) {

Expand All @@ -316,7 +316,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _toggleMenuHandler(e) {
private _toggleMenuHandler(e): void {
if (e.keyCode) {
if (e.keyCode === 13) {
this._processMenuToggle(e);
Expand All @@ -328,7 +328,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _isDescendant(parent, child) {
private _isDescendant(parent, child): boolean {
let node = child.parentNode;
while (node) {
if (node === parent) {
Expand All @@ -345,7 +345,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _findAncestor(el, cls) {
private _findAncestor(el, cls): void {
let newCLS = cls.replace('.', '');
let newEL = el;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@ export interface IDONavigationLinkState {
}

export class DONavigationLink extends React.Component<IDONavigationLinkProps, IDONavigationLinkState> {
public static defaultProps = {
role: 'menuitem'
};
public static defaultProps = {
role: 'menuitem'
};

public render() {
return (
<a className='od-Navigation-subMenuItem' href={ this.props.href } role={ this.props.role }>
{ this._getIcon() }
{ this.props.label }
</a>
);
}
public render(): JSX.Element {
return (
<a className='od-Navigation-subMenuItem' href={ this.props.href } role={ this.props.role }>
{ this._getIcon() }
{ this.props.label }
</a>
);
}

private _getIcon() {
if (this.props.icon) {
return <DOIcon iconClass={ this.props.icon.iconClass } bgColor={ this.props.icon.bgColor } />;
}
private _getIcon() {
if (this.props.icon) {
return <DOIcon iconClass={ this.props.icon.iconClass } bgColor={ this.props.icon.bgColor } />;
}
}
}
Loading