breaking(react-drawer): open now only accepts a boolean instead of MotionShorthand #29736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 622 | 631 | 5000 | |
| Button | mount | 315 | 328 | 5000 | |
| Field | mount | 1142 | 1165 | 5000 | |
| FluentProvider | mount | 724 | 707 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 86 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 66 | 61 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 76 | 10 | |
| MakeStyles | mount | 847 | 863 | 50000 | |
| Persona | mount | 1754 | 1748 | 5000 | |
| SpinButton | mount | 1394 | 1379 | 5000 |
marcosmoura
commented
Nov 2, 2023
packages/react-components/react-drawer/stories/Drawer/DrawerMotionCustom.stories.tsx
Show resolved
Hide resolved
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9fe7016:
|
ValentinaKozlova
approved these changes
Nov 2, 2023
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 526abab76556f7f0440acc89fa55a768d1956237 (build) |
marcosmoura
deleted the
feat/react-drawer/open-prop-to-only-accepts-boolean
branch
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 2, 2023
* master: breaking(react-drawer): open now only accepts a boolean instead of MotionShorthand (microsoft#29736) fix (breadcrumb): Overflow examples refactoring (microsoft#29723) refactor(tools): replace deprecated apis (microsoft#29624) [Part 3] Update documentation content for all charts (microsoft#29727) chore: throws if FlatTree is used as a subtree (microsoft#29729) feat(react-storybook-addon-export-to-sandbox): make addon generic so it can be published and use by others (microsoft#29674) chore(TimePicker-compat): add bundle size fixture (microsoft#29717) applying package updates Move CredScanSuppression file to root so 1ESPT output task picks it up (microsoft#29722) fix(CI): increase pipeline agent timeout threshold to 90 minutes (microsoft#29710) fix(breadcrumb): examples and styles (microsoft#29679) chore(react-tree): stop unnecessary re-rendering when no actions are available (microsoft#29694) applying package updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a Breaking Change, but as the package is still in preview, we can have that happening.
This change makes the
openprop on all the main Drawer components to only accept abooleanvalue. Previously it was accepting a MotionShorthand type as well. This will be added back in the future when the react-motion package becomes stable.For more information: #29711