Skip to content

refactor(tools): replace deprecated apis #29624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hotell merged 2 commits into from
Nov 2, 2023
Merged

refactor(tools): replace deprecated apis #29624

Hotell merged 2 commits into from
Nov 2, 2023

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 24, 2023 •
edited
Loading

Previous Behavior

New Behavior

removes @nx/devkit deprecated apis that will no longer work with nx 17

-readWorkspaceConfiguration
+readNxJson

-WorkspaceConfiguration
+NxJsonConfiguration

Related Issue(s)

@Hotell Hotell changed the title Hotell/nx/migrate from deprecated apis refactor(tools): replace deprecated apis Oct 24, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 24, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4ef5545:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2023

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 125 110 1.14:1
AlertMinimalPerf.default 164 147 1.12:1
ButtonMinimalPerf.default 90 82 1.1:1
AttachmentMinimalPerf.default 82 75 1.09:1
RefMinimalPerf.default 113 104 1.09:1
FormMinimalPerf.default 224 207 1.08:1
RosterPerf.default 1608 1520 1.06:1
RadioGroupMinimalPerf.default 264 250 1.06:1
ChatWithPopoverPerf.default 199 189 1.05:1
InputMinimalPerf.default 548 521 1.05:1
LayoutMinimalPerf.default 205 195 1.05:1
PortalMinimalPerf.default 85 81 1.05:1
TreeWith60ListItems.default 84 80 1.05:1
ChatMinimalPerf.default 427 409 1.04:1
ListMinimalPerf.default 311 298 1.04:1
TableMinimalPerf.default 233 225 1.04:1
AttachmentSlotsPerf.default 640 624 1.03:1
LabelMinimalPerf.default 218 212 1.03:1
ListNestedPerf.default 318 310 1.03:1
PopupMinimalPerf.default 357 348 1.03:1
SegmentMinimalPerf.default 192 187 1.03:1
IconMinimalPerf.default 400 390 1.03:1
TableManyItemsPerf.default 1118 1089 1.03:1
ToolbarMinimalPerf.default 530 516 1.03:1
TreeMinimalPerf.default 475 462 1.03:1
AnimationMinimalPerf.default 293 288 1.02:1
ChatDuplicateMessagesPerf.default 151 148 1.02:1
DropdownMinimalPerf.default 1418 1389 1.02:1
EmbedMinimalPerf.default 1925 1889 1.02:1
HeaderSlotsPerf.default 461 451 1.02:1
ProviderMinimalPerf.default 205 201 1.02:1
ButtonSlotsPerf.default 318 316 1.01:1
DatepickerMinimalPerf.default 3544 3505 1.01:1
DialogMinimalPerf.default 439 435 1.01:1
DividerMinimalPerf.default 205 203 1.01:1
GridMinimalPerf.default 183 182 1.01:1
LoaderMinimalPerf.default 176 174 1.01:1
SkeletonMinimalPerf.default 197 195 1.01:1
TooltipMinimalPerf.default 1293 1284 1.01:1
VideoMinimalPerf.default 425 419 1.01:1
ButtonOverridesMissPerf.default 682 680 1:1
HeaderMinimalPerf.default 208 207 1:1
ItemLayoutMinimalPerf.default 696 694 1:1
ListCommonPerf.default 388 388 1:1
ListWith60ListItems.default 359 360 1:1
SplitButtonMinimalPerf.default 2233 2234 1:1
TextAreaMinimalPerf.default 282 281 1:1
BoxMinimalPerf.default 188 190 0.99:1
CarouselMinimalPerf.default 258 260 0.99:1
FlexMinimalPerf.default 155 156 0.99:1
ProviderMergeThemesPerf.default 636 645 0.99:1
ReactionMinimalPerf.default 203 206 0.99:1
StatusMinimalPerf.default 387 391 0.99:1
TextMinimalPerf.default 185 187 0.99:1
CardMinimalPerf.default 298 304 0.98:1
CheckboxMinimalPerf.default 1110 1138 0.98:1
ImageMinimalPerf.default 223 228 0.98:1
MenuMinimalPerf.default 473 482 0.98:1
MenuButtonMinimalPerf.default 935 964 0.97:1
SliderMinimalPerf.default 726 747 0.97:1
CustomToolbarPrototype.default 1435 1473 0.97:1
AccordionMinimalPerf.default 79 85 0.93:1
DropdownManyItemsPerf.default 372 406 0.92:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 646 684 5000
Button mount 315 323 5000
Field mount 1144 1105 5000
FluentProvider mount 719 739 5000
FluentProviderWithTheme mount 84 88 10
FluentProviderWithTheme virtual-rerender 74 78 10
FluentProviderWithTheme virtual-rerender-with-unmount 82 82 10
MakeStyles mount 835 869 50000
Persona mount 1785 1799 5000
SpinButton mount 1439 1414 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2023

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 26e7bd757ab3d6547506da7100c72f6ef5e43c06

@size-auditor
Copy link

size-auditor bot commented Oct 24, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 26e7bd757ab3d6547506da7100c72f6ef5e43c06 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2023

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 630 621 5000
Breadcrumb mount 1656 1656 1000
Checkbox mount 1672 1652 5000
CheckboxBase mount 1473 1477 5000
ChoiceGroup mount 2907 2874 5000
ComboBox mount 661 654 1000
CommandBar mount 6189 6177 1000
ContextualMenu mount 12145 11958 1000
DefaultButton mount 749 768 5000
DetailsRow mount 2183 2173 5000
DetailsRowFast mount 2193 2233 5000
DetailsRowNoStyles mount 1971 2021 5000
Dialog mount 2765 2642 1000
DocumentCardTitle mount 220 218 1000
Dropdown mount 1974 1981 5000
FocusTrapZone mount 1160 1170 5000
FocusZone mount 1062 1101 5000
GroupedList mount 41844 41892 2
GroupedList virtual-rerender 19938 19988 2
GroupedList virtual-rerender-with-unmount 50379 50708 2
GroupedListV2 mount 218 226 2
GroupedListV2 virtual-rerender 207 199 2
GroupedListV2 virtual-rerender-with-unmount 238 228 2
IconButton mount 1079 1090 5000
Label mount 332 335 5000
Layer mount 2692 2712 5000
Link mount 379 397 5000
MenuButton mount 972 921 5000
MessageBar mount 21204 21245 5000
Nav mount 1952 1929 1000
OverflowSet mount 783 801 5000
Panel mount 2020 1778 1000
Persona mount 740 746 1000
Pivot mount 856 885 1000
PrimaryButton mount 844 845 5000
Rating mount 4604 4641 5000
SearchBox mount 935 905 5000
Shimmer mount 1859 1829 5000
Slider mount 1342 1327 5000
SpinButton mount 2909 2841 5000
Spinner mount 385 401 5000
SplitButton mount 1875 1832 5000
Stack mount 412 400 5000
StackWithIntrinsicChildren mount 845 846 5000
StackWithTextChildren mount 2602 2562 5000
SwatchColorPicker mount 6125 6104 5000
TagPicker mount 1479 1464 5000
Text mount 379 380 5000
TextField mount 919 939 5000
ThemeProvider mount 818 824 5000
ThemeProvider virtual-rerender 585 583 5000
ThemeProvider virtual-rerender-with-unmount 1268 1277 5000
Toggle mount 596 614 5000
buttonNative mount 192 198 5000

@Hotell Hotell force-pushed the hotell/nx/migrate-from-deprecated-apis branch from 45fb66f to 1816105 Compare October 26, 2023 11:06
@Hotell Hotell marked this pull request as ready for review October 26, 2023 12:16
@Hotell Hotell requested a review from a team as a code owner October 26, 2023 12:16
@marcosmoura marcosmoura self-requested a review October 31, 2023 13:13
TristanWatanabe
TristanWatanabe reviewed Nov 2, 2023
View reviewed changes
@Hotell Hotell enabled auto-merge (squash) November 2, 2023 14:18
@Hotell Hotell merged commit 526abab into microsoft:master Nov 2, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Nov 2, 2023
@marcosmoura
Merge branch 'master' into feat/react-drawer/release-to-stable
9bca8b3 
* master:
  breaking(react-drawer): open now only accepts a boolean instead of MotionShorthand (microsoft#29736)
  fix (breadcrumb): Overflow examples refactoring (microsoft#29723)
  refactor(tools): replace deprecated apis (microsoft#29624)
  [Part 3] Update documentation content for all charts (microsoft#29727)
  chore: throws if FlatTree is used as a subtree (microsoft#29729)
  feat(react-storybook-addon-export-to-sandbox): make addon generic so it can be published and use by others (microsoft#29674)
  chore(TimePicker-compat): add bundle size fixture (microsoft#29717)
  applying package updates
  Move CredScanSuppression file to root so 1ESPT output task picks it up (microsoft#29722)
  fix(CI): increase pipeline agent timeout threshold to 90 minutes (microsoft#29710)
  fix(breadcrumb): examples and styles (microsoft#29679)
  chore(react-tree): stop unnecessary re-rendering when no actions are available (microsoft#29694)
  applying package updates
@Hotell Hotell deleted the hotell/nx/migrate-from-deprecated-apis branch November 3, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TristanWatanabe TristanWatanabe TristanWatanabe left review comments

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees

No one assigned

Labels

Area: Build System NX: workspace generators

Projects

None yet

Milestone

November Project Cycle Q1 2023

Development

Successfully merging this pull request may close these issues.

4 participants

@Hotell @fabricteam @marcosmoura @TristanWatanabe