Skip to content

Conversation

@ValentinaKozlova
Copy link
Contributor

Previous Behavior

  • BreadcrumbButton by default was semantically button
  • Current breadcrumb with icon had hover styles
  • BreadcrumbButton had role and type button

New Behavior

  • Added link behavior as a default one to BreadcrumbButton
  • Removed hover styles for current breadcrumb with icon
  • Removed role and type from BreadcrumbButton

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 27, 2023

📊 Bundle size report

🤖 This report was generated against ecb1b8aafb16bb992010ca480f0c40e4dbb76960

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3d323d6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 27, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Oct 30, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ecb1b8aafb16bb992010ca480f0c40e4dbb76960 (build)

@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review October 30, 2023 14:21
@ValentinaKozlova ValentinaKozlova requested a review from a team as a code owner October 30, 2023 14:21
@marcosmoura marcosmoura self-requested a review October 31, 2023 13:13
@ValentinaKozlova ValentinaKozlova merged commit 877aa55 into microsoft:master Nov 1, 2023
@ValentinaKozlova ValentinaKozlova deleted the fix/breadcrumb-examples branch November 1, 2023 14:20
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Nov 2, 2023
* master:
  breaking(react-drawer): open now only accepts a boolean instead of MotionShorthand (microsoft#29736)
  fix (breadcrumb): Overflow examples refactoring (microsoft#29723)
  refactor(tools): replace deprecated apis (microsoft#29624)
  [Part 3] Update documentation content for all charts (microsoft#29727)
  chore: throws if FlatTree is used as a subtree (microsoft#29729)
  feat(react-storybook-addon-export-to-sandbox): make addon generic so it can be published and use by others (microsoft#29674)
  chore(TimePicker-compat): add bundle size fixture (microsoft#29717)
  applying package updates
  Move CredScanSuppression file to root so 1ESPT output task picks it up (microsoft#29722)
  fix(CI): increase pipeline agent timeout threshold to 90 minutes (microsoft#29710)
  fix(breadcrumb): examples and styles (microsoft#29679)
  chore(react-tree): stop unnecessary re-rendering when no actions are available (microsoft#29694)
  applying package updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants