chore(react-tree): throws if FlatTree is used as a subtree #29729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 590 | 641 | 5000 | |
| Button | mount | 325 | 317 | 5000 | |
| Field | mount | 1129 | 1122 | 5000 | |
| FluentProvider | mount | 693 | 708 | 5000 | |
| FluentProviderWithTheme | mount | 85 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 72 | 69 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 82 | 77 | 10 | |
| MakeStyles | mount | undefined | err | 50000 | |
| Persona | mount | 1762 | 1690 | 5000 | |
| SpinButton | mount | 1354 | 1392 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a8454b4:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
bsunderhus
force-pushed
the
react-tree/feat--throws-in-erroneous-use-cases-of-FlatTree
branch
from
83fda12 to
acc1706
Compare
bsunderhus
force-pushed
the
react-tree/feat--throws-in-erroneous-use-cases-of-FlatTree
branch
from
acc1706 to
a8454b4
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3129d7868082c057cc01ad860a45a9ffc8072a7b (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
approved these changes
Nov 2, 2023
bsunderhus
deleted the
react-tree/feat--throws-in-erroneous-use-cases-of-FlatTree
branch
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 2, 2023
* master: breaking(react-drawer): open now only accepts a boolean instead of MotionShorthand (microsoft#29736) fix (breadcrumb): Overflow examples refactoring (microsoft#29723) refactor(tools): replace deprecated apis (microsoft#29624) [Part 3] Update documentation content for all charts (microsoft#29727) chore: throws if FlatTree is used as a subtree (microsoft#29729) feat(react-storybook-addon-export-to-sandbox): make addon generic so it can be published and use by others (microsoft#29674) chore(TimePicker-compat): add bundle size fixture (microsoft#29717) applying package updates Move CredScanSuppression file to root so 1ESPT output task picks it up (microsoft#29722) fix(CI): increase pipeline agent timeout threshold to 90 minutes (microsoft#29710) fix(breadcrumb): examples and styles (microsoft#29679) chore(react-tree): stop unnecessary re-rendering when no actions are available (microsoft#29694) applying package updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
FlatTree just console error about the fact user should not be using a FlatTree as a subtree
New Behavior
As multiple clients were detected using FlatTree as a subtree, this PR ensure that in development FlatTree will throw if used as a subtree
Related Issue(s)