fix(react-drawer): regression with mountNode prop not available after refactoring #29524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 615 | 647 | 5000 | |
| Button | mount | 311 | 329 | 5000 | |
| Field | mount | 1161 | 1123 | 5000 | |
| FluentProvider | mount | 715 | 697 | 5000 | |
| FluentProviderWithTheme | mount | 79 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 63 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 80 | 10 | |
| InfoButton | mount | 13 | 11 | 5000 | |
| MakeStyles | mount | 862 | 862 | 50000 | |
| Persona | mount | 1769 | 1742 | 5000 | |
| SpinButton | mount | 1359 | 1385 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1a0a585:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 28adeae63d705f0be6bce291738dad7fe586e9a8 (build) |
ValentinaKozlova
approved these changes
Oct 13, 2023
Hotell
approved these changes
Oct 13, 2023
Hotell
reviewed
Oct 13, 2023
...react-drawer/src/components/DrawerOverlay/DrawerOverlaySurface/DrawerOverlaySurface.types.ts
Show resolved
Hide resolved
marcosmoura
changed the title
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 24, 2023
* master: (48 commits) fix(react-drawer): regression with mountNode prop not available after refactoring (microsoft#29524) feat(react-storybook-addon-codesandbox): support various providers for "export to" functionality (microsoft#29536) feat(TimePicker-compat): call onTimeSelect on blur (microsoft#29597) feat: (breadcrumb) Removed appearance prop (microsoft#29554) chore(deps): bump fsevents from 1.2.9 to 1.2.13 (microsoft#29476) Adding comment in Hovercard that we support cumulative area chart currently (microsoft#29395) applying package updates applying package updates chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app (microsoft#29603) docs: Add guidance for modifying textarea's height. (microsoft#29601) fix(react-calendar-compat): Classnames removed and added to day cells need to be split instead of providing a string with spaces (microsoft#29611) [Part 2] Changes to onboard charting to fluent docsite (microsoft#29608) chore: bump jest to 29.7.0 (microsoft#29298) applying package updates feat(react-infolabel, react-components): Release InfoLabel to stable (microsoft#29585) feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat (microsoft#29587) feat: adds motion to DialogSurface (microsoft#29391) fix: Use correct target windows for ResizeObserver (microsoft#29551) chg (microsoft#29592) Fix missing x callout custom callout (microsoft#29547) ...
marcosmoura
deleted the
fix/react-drawer/regression-with-mountNode-prop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
In the last release, the Drawer got on a huge code refactor and one property was missing after that (mountNode).
New Behavior
Restores the property by synchronizing with the Dialog component props
Related Issue(s)