Skip to content

fix(react-drawer): regression with mountNode prop not available after refactoring #29524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcosmoura merged 4 commits into from
Oct 24, 2023
Merged

fix(react-drawer): regression with mountNode prop not available after refactoring #29524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5cebd3
fix(react-drawer): regression with mountNode prop not available after…
marcosmoura Oct 13, 2023
ecea06a
Merge branch 'master' into fix/react-drawer/regression-with-mountNode…
marcosmoura Oct 13, 2023
1803380
Merge branch 'master' into fix/react-drawer/regression-with-mountNode…
marcosmoura Oct 13, 2023
1a0a585
Merge branch 'master' into fix/react-drawer/regression-with-mountNode…
marcosmoura Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-drawer-48e12c53-cba7-4acf-a7c7-8b7a3002fbbd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: regression with mountNode prop not available after refactor",
"packageName": "@fluentui/react-drawer",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react-components/react-drawer/etc/react-drawer.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import type { ComponentProps } from '@fluentui/react-utilities';
import type { ComponentState } from '@fluentui/react-utilities';
import type { DialogProps } from '@fluentui/react-dialog';
import type { DialogSurfaceProps } from '@fluentui/react-dialog';
import type { DialogSurfaceSlots } from '@fluentui/react-dialog';
import type { ForwardRefComponent } from '@fluentui/react-utilities';
import { MotionShorthand } from '@fluentui/react-motion-preview';
Expand Down
6 changes: 3 additions & 3 deletions ...ct-drawer/src/components/DrawerOverlay/DrawerOverlaySurface/DrawerOverlaySurface.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { DialogSurfaceSlots, DialogSurfaceState } from '@fluentui/react-dialog';
import type { ComponentProps, ComponentState } from '@fluentui/react-utilities';
import type { DialogSurfaceProps, DialogSurfaceSlots, DialogSurfaceState } from '@fluentui/react-dialog';
import type { ComponentState } from '@fluentui/react-utilities';

/**
* DrawerOverlaySurface slots
Expand All @@ -9,7 +9,7 @@ export type DrawerOverlaySurfaceSlots = DialogSurfaceSlots;
/**
* DrawerOverlaySurface Props
*/
export type DrawerOverlaySurfaceProps = ComponentProps<DrawerOverlaySurfaceSlots>;
export type DrawerOverlaySurfaceProps = DialogSurfaceProps;

/**
* State used in rendering DrawerOverlaySurface
Expand Down