feat(react-dialog): adds motion to DialogSurface
#29391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 624 | 620 | 5000 | |
| Button | mount | 320 | 317 | 5000 | |
| Field | mount | 1112 | 1107 | 5000 | |
| FluentProvider | mount | 818 | 714 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 66 | 57 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 72 | 10 | |
| InfoButton | mount | 16 | 13 | 5000 | |
| MakeStyles | mount | 853 | 840 | 50000 | |
| Persona | mount | 1712 | 1696 | 5000 | |
| SpinButton | mount | 1345 | 1336 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d773dc7:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8f2eb85fcde38ad239b1defcb0914263d01c2534 (build) |
bsunderhus
force-pushed
the
react-dialog/feature--adds-motion-to-dialog
branch
2 times, most recently
from
47c4cad to
a920460
Compare
packages/react-components/react-dialog/src/contexts/dialogContext.ts
Outdated
Show resolved
Hide resolved
.../react-components/react-dialog/src/components/DialogSurface/useDialogSurfaceStyles.styles.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-dialog/feature--adds-motion-to-dialog
branch
2 times, most recently
from
016b85f to
8fac463
Compare
Contributor
Author
|
blocked by #29394 |
bsunderhus
force-pushed
the
react-dialog/feature--adds-motion-to-dialog
branch
2 times, most recently
from
e1f7056 to
b70dd97
Compare
ling1726
reviewed
Oct 10, 2023
ling1726
reviewed
Oct 10, 2023
packages/react-components/react-dialog/src/contexts/dialogContext.ts
Outdated
Show resolved
Hide resolved
.../react-components/react-dialog/src/components/DialogSurface/useDialogSurfaceStyles.styles.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-dialog/feature--adds-motion-to-dialog
branch
5 times, most recently
from
eaeeaae to
7ee83c4
Compare
bsunderhus
force-pushed
the
react-dialog/feature--adds-motion-to-dialog
branch
from
7ee83c4 to
0420705
Compare
2 tasks
bsunderhus
force-pushed
the
react-dialog/feature--adds-motion-to-dialog
branch
from
0420705 to
0e45c89
Compare
bsunderhus
force-pushed
the
react-dialog/feature--adds-motion-to-dialog
branch
from
0e45c89 to
7111dc4
Compare
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
reviewed
Oct 19, 2023
packages/react-components/react-dialog/src/components/Dialog/renderDialog.tsx
Show resolved
Hide resolved
ling1726
approved these changes
Oct 19, 2023
bsunderhus
force-pushed
the
react-dialog/feature--adds-motion-to-dialog
branch
from
e088350 to
d773dc7
Compare
Member
|
/azp run Visual Regression Tool - PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
robertpenner
added a commit
to robertpenner/fluentui
that referenced
this pull request
Oct 24, 2023
This reverts commit 4ac68a6.
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 24, 2023
* master: (48 commits) fix(react-drawer): regression with mountNode prop not available after refactoring (microsoft#29524) feat(react-storybook-addon-codesandbox): support various providers for "export to" functionality (microsoft#29536) feat(TimePicker-compat): call onTimeSelect on blur (microsoft#29597) feat: (breadcrumb) Removed appearance prop (microsoft#29554) chore(deps): bump fsevents from 1.2.9 to 1.2.13 (microsoft#29476) Adding comment in Hovercard that we support cumulative area chart currently (microsoft#29395) applying package updates applying package updates chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app (microsoft#29603) docs: Add guidance for modifying textarea's height. (microsoft#29601) fix(react-calendar-compat): Classnames removed and added to day cells need to be split instead of providing a string with spaces (microsoft#29611) [Part 2] Changes to onboard charting to fluent docsite (microsoft#29608) chore: bump jest to 29.7.0 (microsoft#29298) applying package updates feat(react-infolabel, react-components): Release InfoLabel to stable (microsoft#29585) feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat (microsoft#29587) feat: adds motion to DialogSurface (microsoft#29391) fix: Use correct target windows for ResizeObserver (microsoft#29551) chg (microsoft#29592) Fix missing x callout custom callout (microsoft#29547) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
react-transition-groupRelated Issue(s)