Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 10, 2023

Bumps fsevents from 1.2.9 to 1.2.13.

Release notes

Sourced from fsevents's releases.

Release v1.2.13

Only build on Mac-OSX

Release v1.2.11

Removing node-pre-gyp so that building fsevents becomes easier and enabled without the download of binaries.

The credentials to the AWS store have been lost. Releasing to AWS is both insecure and no longer possible due to the lost credentials.

Intermediate Release

No release notes provided.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot requested a review from a team as a code owner October 10, 2023 07:39
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 10, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c805c9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

Bumps [fsevents](https://github.com/fsevents/fsevents) from 1.2.9 to 1.2.13.
- [Release notes](https://github.com/fsevents/fsevents/releases)
- [Commits](fsevents/fsevents@v1.2.9...v1.2.13)

---
updated-dependencies:
- dependency-name: fsevents
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/fsevents-1.2.13 branch from dc29a1f to 7c805c9 Compare October 11, 2023 07:31
@Hotell
Copy link
Contributor

Hotell commented Oct 17, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 623 614 5000
Button mount 317 309 5000
Field mount 1105 1090 5000
FluentProvider mount 724 694 5000
FluentProviderWithTheme mount 81 80 10
FluentProviderWithTheme virtual-rerender 62 59 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 78 10
InfoButton mount 16 11 5000
MakeStyles mount 852 847 50000
Persona mount 1730 1677 5000
SpinButton mount 1370 1350 5000

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 89 80 1.11:1
AccordionMinimalPerf.default 83 77 1.08:1
FlexMinimalPerf.default 160 150 1.07:1
ListWith60ListItems.default 369 349 1.06:1
AvatarMinimalPerf.default 109 104 1.05:1
ListMinimalPerf.default 302 287 1.05:1
TreeMinimalPerf.default 485 460 1.05:1
ListCommonPerf.default 373 357 1.04:1
MenuButtonMinimalPerf.default 962 929 1.04:1
SkeletonMinimalPerf.default 196 189 1.04:1
StatusMinimalPerf.default 399 383 1.04:1
CarouselMinimalPerf.default 268 261 1.03:1
DialogMinimalPerf.default 443 430 1.03:1
ProviderMinimalPerf.default 207 201 1.03:1
TooltipMinimalPerf.default 1298 1264 1.03:1
VideoMinimalPerf.default 427 415 1.03:1
CheckboxMinimalPerf.default 1129 1111 1.02:1
EmbedMinimalPerf.default 1872 1831 1.02:1
LayoutMinimalPerf.default 197 194 1.02:1
RadioGroupMinimalPerf.default 254 250 1.02:1
SegmentMinimalPerf.default 195 191 1.02:1
AnimationMinimalPerf.default 289 286 1.01:1
ButtonOverridesMissPerf.default 645 639 1.01:1
ChatWithPopoverPerf.default 194 192 1.01:1
DatepickerMinimalPerf.default 3551 3504 1.01:1
DropdownManyItemsPerf.default 389 385 1.01:1
DropdownMinimalPerf.default 1425 1406 1.01:1
GridMinimalPerf.default 194 192 1.01:1
TableManyItemsPerf.default 1092 1079 1.01:1
TextAreaMinimalPerf.default 280 277 1.01:1
BoxMinimalPerf.default 187 187 1:1
ChatMinimalPerf.default 417 418 1:1
PopupMinimalPerf.default 339 340 1:1
ToolbarMinimalPerf.default 534 536 1:1
ButtonSlotsPerf.default 304 306 0.99:1
CardMinimalPerf.default 296 298 0.99:1
HeaderSlotsPerf.default 457 463 0.99:1
InputMinimalPerf.default 517 523 0.99:1
ItemLayoutMinimalPerf.default 699 703 0.99:1
LoaderMinimalPerf.default 170 172 0.99:1
SliderMinimalPerf.default 731 741 0.99:1
TableMinimalPerf.default 222 224 0.99:1
TextMinimalPerf.default 185 187 0.99:1
AttachmentSlotsPerf.default 662 677 0.98:1
LabelMinimalPerf.default 208 213 0.98:1
ListNestedPerf.default 314 321 0.98:1
MenuMinimalPerf.default 466 475 0.98:1
ProviderMergeThemesPerf.default 635 650 0.98:1
SplitButtonMinimalPerf.default 2196 2231 0.98:1
CustomToolbarPrototype.default 1454 1489 0.98:1
DividerMinimalPerf.default 192 197 0.97:1
FormMinimalPerf.default 211 218 0.97:1
HeaderMinimalPerf.default 193 199 0.97:1
ImageMinimalPerf.default 212 218 0.97:1
RefMinimalPerf.default 109 112 0.97:1
ReactionMinimalPerf.default 210 218 0.96:1
RosterPerf.default 1475 1546 0.95:1
TreeWith60ListItems.default 83 87 0.95:1
AlertMinimalPerf.default 153 162 0.94:1
ButtonMinimalPerf.default 84 89 0.94:1
ChatDuplicateMessagesPerf.default 140 149 0.94:1
PortalMinimalPerf.default 81 86 0.94:1
IconMinimalPerf.default 374 399 0.94:1

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
4.162 kB
1.735 kB
react-accordion
Accordion (including children components)
93.227 kB
28.402 kB
react-alert
Alert
84.293 kB
23.456 kB
react-avatar
Avatar
50.534 kB
15.923 kB
react-avatar
AvatarGroup
20.064 kB
7.894 kB
react-avatar
AvatarGroupItem
65.19 kB
20.259 kB
react-badge
Badge
27.264 kB
8.808 kB
react-badge
CounterBadge
28.165 kB
9.101 kB
react-badge
PresenceBadge
25.67 kB
9.313 kB
react-button
Button
40.074 kB
11.292 kB
react-button
CompoundButton
47.43 kB
12.787 kB
react-button
MenuButton
44.848 kB
12.668 kB
react-button
SplitButton
52.862 kB
14.254 kB
react-button
ToggleButton
57.122 kB
13.194 kB
react-card
Card - All
93.032 kB
26.934 kB
react-card
Card
87.856 kB
25.435 kB
react-card
CardFooter
13.423 kB
5.481 kB
react-card
CardHeader
15.666 kB
6.235 kB
react-card
CardPreview
14.374 kB
5.854 kB
react-checkbox
Checkbox
37.505 kB
12.327 kB
react-combobox
Combobox (including child components)
91.84 kB
29.937 kB
react-combobox
Dropdown (including child components)
90.282 kB
29.595 kB
react-components
react-components: Button, FluentProvider & webLightTheme
70.061 kB
20.164 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.809 kB
59.71 kB
react-components
react-components: FluentProvider & webLightTheme
42.345 kB
13.999 kB
react-datepicker-compat
DatePicker Compat
212.163 kB
59.148 kB
react-dialog
Dialog (including children components)
89.781 kB
26.759 kB
react-divider
Divider
21.179 kB
7.839 kB
react-field
Field
22.788 kB
8.639 kB
react-image
Image
16.096 kB
6.317 kB
react-infobutton
InfoButton
130.581 kB
41.108 kB
react-infobutton
InfoLabel
134.265 kB
42.271 kB
react-input
Input
27.247 kB
9.194 kB
react-jsx-runtime
Classic Pragma
1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime
4.14 kB
1.741 kB
react-jsx-runtime
JSX Runtime
4.734 kB
1.983 kB
react-label
Label
14.508 kB
5.857 kB
react-link
Link
17.4 kB
6.977 kB
react-menu
Menu (including children components)
140.404 kB
43.358 kB
react-menu
Menu (including selectable components)
143.09 kB
43.871 kB
react-message-bar
MessageBar (all components)
25.54 kB
9.102 kB
react-overflow
hooks only
12.419 kB
4.687 kB
react-persona
Persona
57.425 kB
17.798 kB
react-popover
Popover
119.313 kB
37.636 kB
react-portal
Portal
12.458 kB
4.537 kB
react-portal-compat
PortalCompatProvider
6.706 kB
2.25 kB
react-positioning
usePositioning
25.305 kB
9.162 kB
react-progress
ProgressBar
17.788 kB
6.986 kB
react-provider
FluentProvider
22.89 kB
8.428 kB
react-radio
Radio
31.266 kB
10.267 kB
react-radio
RadioGroup
15.704 kB
6.35 kB
react-select
Select
28.968 kB
10.269 kB
react-slider
Slider
38.349 kB
12.595 kB
react-spinbutton
SpinButton
37.133 kB
11.856 kB
react-spinner
Spinner
23.762 kB
8.556 kB
react-switch
Switch
33.731 kB
10.899 kB
react-table
DataGrid
157.173 kB
43.847 kB
react-table
Table (Primitives only)
44 kB
13.758 kB
react-table
Table as DataGrid
130.468 kB
35.186 kB
react-table
Table (Selection only)
75.836 kB
20.473 kB
react-table
Table (Sort only)
74.443 kB
20.073 kB
react-tags
InteractionTag
15.618 kB
6.152 kB
react-tags
Tag
30.341 kB
9.505 kB
react-tags
TagGroup
74.06 kB
22.091 kB
react-text
Text - Default
17.065 kB
6.645 kB
react-text
Text - Wrappers
20.237 kB
6.965 kB
react-textarea
Textarea
31.306 kB
10.549 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
34.611 kB
7.295 kB
react-theme
Teams: Light theme
19.282 kB
5.486 kB
react-toast
Toast (including Toaster)
92.681 kB
27.76 kB
react-tooltip
Tooltip
52.525 kB
18.46 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 4dc9e5be60b6ce6f3f6c72c6da39bf19a504f524

@size-auditor
Copy link

size-auditor bot commented Oct 17, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4dc9e5be60b6ce6f3f6c72c6da39bf19a504f524 (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 608 630 5000
Breadcrumb mount 1694 1723 1000
Checkbox mount 1676 1673 5000
CheckboxBase mount 1462 1504 5000
ChoiceGroup mount 2858 2960 5000
ComboBox mount 639 654 1000
CommandBar mount 6182 6188 1000
ContextualMenu mount 13080 12985 1000
DefaultButton mount 754 760 5000
DetailsRow mount 2150 2140 5000
DetailsRowFast mount 2161 2141 5000
DetailsRowNoStyles mount 2003 2041 5000
Dialog mount 2580 2622 1000
DocumentCardTitle mount 218 228 1000
Dropdown mount 2004 1973 5000
FocusTrapZone mount 1127 1156 5000
FocusZone mount 1043 1103 5000
GroupedList mount 40932 41370 2
GroupedList virtual-rerender 19734 19631 2
GroupedList virtual-rerender-with-unmount 52437 50240 2
GroupedListV2 mount 233 241 2
GroupedListV2 virtual-rerender 213 220 2
GroupedListV2 virtual-rerender-with-unmount 243 239 2
IconButton mount 1077 1064 5000
Label mount 338 329 5000
Layer mount 2746 2745 5000
Link mount 383 395 5000
MenuButton mount 915 935 5000
MessageBar mount 21313 21347 5000
Nav mount 1913 1938 1000
OverflowSet mount 764 789 5000
Panel mount 2042 1758 1000
Persona mount 713 722 1000
Pivot mount 864 867 1000
PrimaryButton mount 859 837 5000
Rating mount 4590 4511 5000
SearchBox mount 927 907 5000
Shimmer mount 1839 1874 5000
Slider mount 1307 1317 5000
SpinButton mount 2852 2842 5000
Spinner mount 380 386 5000
SplitButton mount 1833 1840 5000
Stack mount 407 405 5000
StackWithIntrinsicChildren mount 831 845 5000
StackWithTextChildren mount 2557 2580 5000
SwatchColorPicker mount 6090 6173 5000
TagPicker mount 1453 1434 5000
Text mount 378 359 5000
TextField mount 966 941 5000
ThemeProvider mount 843 826 5000
ThemeProvider virtual-rerender 594 585 5000
ThemeProvider virtual-rerender-with-unmount 1265 1305 5000
Toggle mount 608 619 5000
buttonNative mount 198 197 5000

@Hotell Hotell merged commit 58cae14 into master Oct 24, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/fsevents-1.2.13 branch October 24, 2023 11:27
@Hotell
Copy link
Contributor

Hotell commented Oct 24, 2023

this also fixes one of critical alerts within CG
image

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 24, 2023
* master: (48 commits)
  fix(react-drawer): regression with mountNode prop not available after refactoring (microsoft#29524)
  feat(react-storybook-addon-codesandbox): support various providers for "export to" functionality (microsoft#29536)
  feat(TimePicker-compat): call onTimeSelect on blur (microsoft#29597)
  feat: (breadcrumb) Removed appearance prop (microsoft#29554)
  chore(deps): bump fsevents from 1.2.9 to 1.2.13 (microsoft#29476)
  Adding comment in Hovercard that we support cumulative area chart currently (microsoft#29395)
  applying package updates
  applying package updates
  chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app (microsoft#29603)
  docs: Add guidance for modifying textarea's height. (microsoft#29601)
  fix(react-calendar-compat): Classnames removed and added to day cells need to be split instead of providing a string with spaces (microsoft#29611)
  [Part 2] Changes to onboard charting to fluent docsite (microsoft#29608)
  chore: bump jest to 29.7.0 (microsoft#29298)
  applying package updates
  feat(react-infolabel, react-components): Release InfoLabel to stable (microsoft#29585)
  feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat (microsoft#29587)
  feat: adds motion to DialogSurface (microsoft#29391)
  fix: Use correct target windows for ResizeObserver (microsoft#29551)
  chg (microsoft#29592)
  Fix missing x callout custom callout (microsoft#29547)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants