fix(react-motion): sync internal value of canRender with presence #29394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 624 | 617 | 5000 | |
| Button | mount | 309 | 320 | 5000 | |
| Field | mount | 1130 | 1091 | 5000 | |
| FluentProvider | mount | 694 | 698 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 65 | 67 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 86 | 10 | |
| InfoButton | mount | 6 | 20 | 5000 | |
| MakeStyles | mount | 881 | 870 | 50000 | |
| Persona | mount | 1746 | 1711 | 5000 | |
| SpinButton | mount | 1375 | 1395 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6a52555:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 60a911e66db784521a35c1e1ac0362a3f2d8169f (build) |
bsunderhus
approved these changes
Oct 4, 2023
Hotell
reviewed
Oct 5, 2023
ValentinaKozlova
approved these changes
Oct 5, 2023
marcosmoura
deleted the
fix/react-motion/sync-presence-value-with-canRender
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
presencevalues would only sync withcanRenderafter a first render.New Behavior
presenceandcanRenderis now always synced