Skip to content

Export selection types from combobox #28054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
micahgodbolt merged 2 commits into from
May 30, 2023
Merged

Export selection types from combobox #28054

micahgodbolt merged 2 commits into from
May 30, 2023

Conversation

@micahgodbolt
Copy link
Member

@micahgodbolt micahgodbolt commented May 30, 2023

fixes #27996

@micahgodbolt micahgodbolt requested review from a team and smhigley as code owners May 30, 2023 19:27
@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 30, 2023
@size-auditor
Copy link

size-auditor bot commented May 30, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4da116adb29b9fb5b0a7f93d71cc52011591d64f (build)

@fabricteam
Copy link
Collaborator

fabricteam commented May 30, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 597 579 5000
Button mount 305 294 5000
Field mount 1034 1039 5000
FluentProvider mount 658 647 5000
FluentProviderWithTheme mount 80 91 10
FluentProviderWithTheme virtual-rerender 85 83 10
FluentProviderWithTheme virtual-rerender-with-unmount 84 83 10
InfoButton mount 20 17 5000
MakeStyles mount 882 849 50000
Persona mount 1642 1589 5000
SpinButton mount 1260 1200 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f12d32e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented May 30, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-combobox
Combobox (including child components)		 87.735 kB
28.243 kB
react-combobox
Dropdown (including child components)		 86.074 kB
27.848 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 64.899 kB
17.91 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 206.425 kB
57.914 kB
react-components
react-components: FluentProvider & webLightTheme		 36.132 kB
11.954 kB
react-portal-compat
PortalCompatProvider		 6.473 kB
2.196 kB
🤖 This report was generated against 4da116adb29b9fb5b0a7f93d71cc52011591d64f

@fabricteam
Copy link
Collaborator

fabricteam commented May 30, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@micahgodbolt micahgodbolt merged commit 17ca96c into microsoft:master May 30, 2023
@micahgodbolt micahgodbolt deleted the selection-type-export branch May 30, 2023 20:52
@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/babel-preset-global-context@v9.0.0-beta.29 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-aria@v9.3.22 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-context-selector@v9.1.22 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-data-grid-react-window@v9.0.0-beta.29 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot msft-fluent-ui-bot mentioned this pull request May 31, 2023
Closed
@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-jsx-runtime@v9.0.0-alpha.6 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-persona@v9.2.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-portal-compat@v9.0.60 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-portal@v9.2.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-progress@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-provider@v9.7.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-radio@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-select@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-skeleton@v9.0.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-slider@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-toolbar@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-tooltip@v9.2.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-tree@v9.0.0-beta.18 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-virtualizer@v9.0.0-alpha.22 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/global-context@v9.0.0-beta.29 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-accordion@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-alert@v9.0.0-beta.51 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-avatar@v9.5.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-badge@v9.1.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-button@v9.3.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-card@v9.0.14 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-checkbox@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-table@v9.3.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-datepicker-compat@v0.1.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-dialog@v9.5.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-divider@v9.2.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-drawer@v9.0.0-beta.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-field@v9.1.6 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-image@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-infobutton@v9.0.0-beta.34 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-input@v9.4.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-label@v9.1.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-link@v9.0.42 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-menu@v9.7.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-migration-v0-v9@v9.0.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-migration-v8-v9@v9.2.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-overflow@v9.0.19 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-combobox@v9.4.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 31, 2023

🎉@fluentui/react-components@v9.21.0 has been released which incorporates this pull request.:tada:

Handy links:

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 31, 2023
@marcosmoura
Merge branch 'master' into docs/react-drawer-best-practices
30720be 
* master:
  Added truncation and tooltips to the Breadcrumb (microsoft#27859)
  applying package updates
  applying package updates
  Export selection types from combobox (microsoft#28054)
  fix(react-datepicker-compat): Remove focus function from the deps to avoid constant move of focus (microsoft#28053)
  Updated poster for new stable components (microsoft#28051)
  Griffel/bump to 1.5.7 (microsoft#27925)
  feat(scripts): replace use of SWC CLI with SWC transform api (microsoft#27380)
  chore: Add positioning test for scroll jumps (microsoft#28043)
  chore: migrate to TS 4.5 (microsoft#27936)
  Fix toolbar divider styles (microsoft#28044)
  fix: createFocusOutlineStyle don't work with CSS variables (microsoft#27966)
  feat(react-tags): use simple button for TagButton content instead of aria button (microsoft#28033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smhigley smhigley smhigley approved these changes

Assignees

@micahgodbolt micahgodbolt

Labels

Component: Combobox

Projects

None yet

Milestone

May Project Cycle Q2 2023

Development

Successfully merging this pull request may close these issues.

Fluent v9: Types SelectionEvents and OptionOnSelectData are not surfaced to the user

4 participants

@micahgodbolt @fabricteam @msft-fluent-ui-bot @smhigley