feat(react-tags): use simple button for TagButton content instead of aria button #28033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 603293375d68e2288ef50990394f24b66e3d8250 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e74c8ba:
|
bsunderhus
requested changes
May 30, 2023
packages/react-components/react-tags/src/components/TagButton/TagButton.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags/src/components/TagButton/useTagButton.tsx
Show resolved
Hide resolved
…TagButton.types.ts Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
bsunderhus
approved these changes
May 30, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 31, 2023
* master: Added truncation and tooltips to the Breadcrumb (microsoft#27859) applying package updates applying package updates Export selection types from combobox (microsoft#28054) fix(react-datepicker-compat): Remove focus function from the deps to avoid constant move of focus (microsoft#28053) Updated poster for new stable components (microsoft#28051) Griffel/bump to 1.5.7 (microsoft#27925) feat(scripts): replace use of SWC CLI with SWC transform api (microsoft#27380) chore: Add positioning test for scroll jumps (microsoft#28043) chore: migrate to TS 4.5 (microsoft#27936) Fix toolbar divider styles (microsoft#28044) fix: createFocusOutlineStyle don't work with CSS variables (microsoft#27966) feat(react-tags): use simple button for TagButton content instead of aria button (microsoft#28033)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update TagButton
contentslot:content: NonNullable<ARIAButtonSlotProps<'div'>>;→content: NonNullable<Slot<'button'>>;I like simple button. I've no idea why I used
divwith aria button before 🤷♀️