Skip to content

Export selection types from combobox #28054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahgodbolt merged 2 commits into from
May 30, 2023
Merged

Export selection types from combobox #28054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
982fc89
export selection types from combobox
micahgodbolt May 30, 2023
f12d32e
change and api update
micahgodbolt May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-combobox-05c147ce-b714-4845-8ccd-ec6268ba92cf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "export selection types from combobox",
"packageName": "@fluentui/react-combobox",
"email": "mgodbolt@microsoft.com",
"dependentChangeType": "patch"
}
10 changes: 10 additions & 0 deletions packages/react-components/react-combobox/etc/react-combobox.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ export type OptionGroupSlots = {
// @public
export type OptionGroupState = ComponentState<OptionGroupSlots>;

// @public (undocumented)
export type OptionOnSelectData = {
optionValue: string | undefined;
optionText: string | undefined;
selectedOptions: string[];
};

// @public
export type OptionProps = ComponentProps<Partial<OptionSlots>> & {
disabled?: boolean;
Expand Down Expand Up @@ -185,6 +192,9 @@ export const renderOption_unstable: (state: OptionState) => JSX.Element;
// @public
export const renderOptionGroup_unstable: (state: OptionGroupState) => JSX.Element;

// @public (undocumented)
export type SelectionEvents = React_2.ChangeEvent<HTMLElement> | React_2.KeyboardEvent<HTMLElement> | React_2.MouseEvent<HTMLElement>;

// @public
export const useCombobox_unstable: (props: ComboboxProps, ref: React_2.Ref<HTMLInputElement>) => ComboboxState;

Expand Down
1 change: 1 addition & 0 deletions packages/react-components/react-combobox/src/Selection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './utils/Selection.types';
1 change: 1 addition & 0 deletions packages/react-components/react-combobox/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,4 @@ export {
useOptionGroup_unstable,
} from './OptionGroup';
export type { OptionGroupProps, OptionGroupSlots, OptionGroupState } from './OptionGroup';
export type { OptionOnSelectData, SelectionEvents } from './Selection';