fix: createFocusOutlineStyle don't work with CSS variables #27966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosmoura
commented
May 23, 2023
packages/react-components/react-card/src/components/Card/useCardStyles.styles.ts
Show resolved
Hide resolved
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 569 | 593 | 5000 | |
| Button | mount | 293 | 294 | 5000 | |
| Field | mount | 1002 | 1047 | 5000 | |
| FluentProvider | mount | 661 | 655 | 5000 | |
| FluentProviderWithTheme | mount | 71 | 73 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 65 | 67 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 92 | 74 | 10 | |
| InfoButton | mount | 13 | 13 | 5000 | |
| MakeStyles | mount | 851 | 869 | 50000 | |
| Persona | mount | 1661 | 1599 | 5000 | |
| SpinButton | mount | 1231 | 1266 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 433b3b0:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b26559befc42d4a6367cc1c7079b0afb16005b30 (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
packages/react-components/react-tabster/src/focus/createFocusOutlineStyle.ts
Outdated
Show resolved
Hide resolved
ling1726
approved these changes
May 29, 2023
Contributor
ling1726
left a comment
ling1726
left a comment
There was a problem hiding this comment.
Feel free to throw a bug on us to support css variables
ValentinaKozlova
approved these changes
May 29, 2023
Collaborator
|
🎉 Handy links: |
2 tasks
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 31, 2023
* master: Added truncation and tooltips to the Breadcrumb (microsoft#27859) applying package updates applying package updates Export selection types from combobox (microsoft#28054) fix(react-datepicker-compat): Remove focus function from the deps to avoid constant move of focus (microsoft#28053) Updated poster for new stable components (microsoft#28051) Griffel/bump to 1.5.7 (microsoft#27925) feat(scripts): replace use of SWC CLI with SWC transform api (microsoft#27380) chore: Add positioning test for scroll jumps (microsoft#28043) chore: migrate to TS 4.5 (microsoft#27936) Fix toolbar divider styles (microsoft#28044) fix: createFocusOutlineStyle don't work with CSS variables (microsoft#27966) feat(react-tags): use simple button for TagButton content instead of aria button (microsoft#28033)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for CSS Variables being passed to the
createFocusOutlineStyle.For more context, please refer to this bug: #27954
Fixes: #27954