feat(eslint-plugin): enables jsxTags on comment for react config #27571

bsunderhus · 2023-04-14T08:45:07Z

Previous Behavior

New Behavior

enables jsx tags on comments for react config https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.README/rules/check-tag-names.md#jsxtags

codesandbox-ci · 2023-04-14T08:56:11Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 376d9e5:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-04-14T08:56:39Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	727	724	5000
Button	mount	396	409	5000
Field	mount	1292	1263	5000
FluentProvider	mount	780	802	5000
FluentProviderWithTheme	mount	106	117	10
FluentProviderWithTheme	virtual-rerender	99	87	10
FluentProviderWithTheme	virtual-rerender-with-unmount	94	107	10
InfoButton	mount	19	23	5000
MakeStyles	mount	1226	1194	50000
Persona	mount	1999	1909	5000
SpinButton	mount	1497	1512	5000

size-auditor · 2023-04-14T08:57:36Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 92dd9470416805fedd2f4462102391e123b7fe76 (build)

fabricteam · 2023-04-14T09:00:45Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-04-14T09:03:34Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
IconMinimalPerf.default	663	594	1.12:1
TreeWith60ListItems.default	148	134	1.1:1
FlexMinimalPerf.default	264	243	1.09:1
PortalMinimalPerf.default	135	124	1.09:1
LabelMinimalPerf.default	378	349	1.08:1
MenuMinimalPerf.default	832	770	1.08:1
ChatWithPopoverPerf.default	309	289	1.07:1
AccordionMinimalPerf.default	136	128	1.06:1
ChatMinimalPerf.default	709	672	1.06:1
FormMinimalPerf.default	398	375	1.06:1
GridMinimalPerf.default	324	305	1.06:1
ProviderMinimalPerf.default	323	305	1.06:1
ReactionMinimalPerf.default	359	340	1.06:1
SkeletonMinimalPerf.default	329	309	1.06:1
ListNestedPerf.default	559	532	1.05:1
RadioGroupMinimalPerf.default	444	423	1.05:1
AnimationMinimalPerf.default	450	432	1.04:1
VideoMinimalPerf.default	724	697	1.04:1
AttachmentSlotsPerf.default	1071	1038	1.03:1
HeaderMinimalPerf.default	352	341	1.03:1
HeaderSlotsPerf.default	785	759	1.03:1
SegmentMinimalPerf.default	322	313	1.03:1
SliderMinimalPerf.default	1129	1094	1.03:1
TextAreaMinimalPerf.default	491	476	1.03:1
TreeMinimalPerf.default	763	744	1.03:1
ButtonOverridesMissPerf.default	1045	1025	1.02:1
CheckboxMinimalPerf.default	2046	2004	1.02:1
DividerMinimalPerf.default	355	347	1.02:1
DropdownManyItemsPerf.default	669	657	1.02:1
InputMinimalPerf.default	886	865	1.02:1
StatusMinimalPerf.default	651	637	1.02:1
TableManyItemsPerf.default	1916	1870	1.02:1
ButtonMinimalPerf.default	137	135	1.01:1
CarouselMinimalPerf.default	432	428	1.01:1
ListMinimalPerf.default	498	491	1.01:1
MenuButtonMinimalPerf.default	1621	1611	1.01:1
ProviderMergeThemesPerf.default	1129	1116	1.01:1
TextMinimalPerf.default	320	317	1.01:1
CustomToolbarPrototype.default	2193	2171	1.01:1
ToolbarMinimalPerf.default	846	837	1.01:1
DatepickerMinimalPerf.default	5716	5691	1:1
DropdownMinimalPerf.default	2158	2162	1:1
ItemLayoutMinimalPerf.default	1187	1182	1:1
LayoutMinimalPerf.default	339	338	1:1
ListCommonPerf.default	668	666	1:1
ListWith60ListItems.default	614	617	1:1
RosterPerf.default	2467	2478	1:1
SplitButtonMinimalPerf.default	3847	3848	1:1
TooltipMinimalPerf.default	2032	2041	1:1
AlertMinimalPerf.default	258	260	0.99:1
CardMinimalPerf.default	480	485	0.99:1
BoxMinimalPerf.default	317	323	0.98:1
EmbedMinimalPerf.default	2988	3034	0.98:1
ImageMinimalPerf.default	367	373	0.98:1
LoaderMinimalPerf.default	322	327	0.98:1
ChatDuplicateMessagesPerf.default	236	244	0.97:1
AttachmentMinimalPerf.default	129	134	0.96:1
DialogMinimalPerf.default	705	736	0.96:1
ButtonSlotsPerf.default	484	507	0.95:1
RefMinimalPerf.default	150	158	0.95:1
TableMinimalPerf.default	389	410	0.95:1
AvatarMinimalPerf.default	180	197	0.91:1
PopupMinimalPerf.default	537	611	0.88:1

fabricteam · 2023-04-14T09:04:23Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`560 B` `352 B`
`priority-overflow` createOverflowManager	`3.194 kB` `1.314 kB`
`react-accordion` Accordion (including children components)	`88.978 kB` `26.586 kB`
`react-alert` Alert	`95.877 kB` `23.104 kB`
`react-avatar` Avatar	`59.542 kB` `15.569 kB`
`react-avatar` AvatarGroup	`18.19 kB` `6.706 kB`
`react-avatar` AvatarGroupItem	`75.803 kB` `20.072 kB`
`react-badge` Badge	`26.075 kB` `7.629 kB`
`react-badge` CounterBadge	`27.058 kB` `7.938 kB`
`react-badge` PresenceBadge	`34.547 kB` `8.726 kB`
`react-button` Button	`39.845 kB` `10 kB`
`react-button` CompoundButton	`47.017 kB` `11.469 kB`
`react-button` MenuButton	`44.532 kB` `11.352 kB`
`react-button` SplitButton	`53.027 kB` `12.914 kB`
`react-button` ToggleButton	`58.217 kB` `11.922 kB`
`react-card` Card - All	`86.164 kB` `24.342 kB`
`react-card` Card	`80.983 kB` `22.881 kB`
`react-card` CardFooter	`9.122 kB` `3.832 kB`
`react-card` CardHeader	`11.048 kB` `4.537 kB`
`react-card` CardPreview	`9.927 kB` `4.18 kB`
`react-checkbox` Checkbox	`37.109 kB` `11.286 kB`
`react-combobox` Combobox (including child components)	`89.878 kB` `28.552 kB`
`react-combobox` Dropdown (including child components)	`88.562 kB` `28.275 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`68.093 kB` `18.424 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`207.629 kB` `57.6 kB`
`react-components` react-components: FluentProvider & webLightTheme	`38.833 kB` `12.37 kB`
`react-datepicker-compat` DatePicker Compat	`251.37 kB` `67.359 kB`
`react-dialog` Dialog (including children components)	`93.338 kB` `27.391 kB`
`react-divider` Divider	`19.958 kB` `6.736 kB`
`react-field` Field	`21.589 kB` `7.453 kB`
`react-image` Image	`14.023 kB` `5.008 kB`
`react-infobutton` InfoButton	`130.692 kB` `39.476 kB`
`react-infobutton` InfoLabel	`133.988 kB` `40.514 kB`
`react-input` Input	`26.796 kB` `8.148 kB`
`react-label` Label	`12.657 kB` `4.618 kB`
`react-link` Link	`12.313 kB` `5.081 kB`
`react-menu` Menu (including children components)	`131.151 kB` `39.687 kB`
`react-menu` Menu (including selectable components)	`134.287 kB` `40.226 kB`
`react-overflow` hooks only	`11.214 kB` `4.271 kB`
`react-persona` Persona	`66.568 kB` `17.513 kB`
`react-popover` Popover	`117.611 kB` `35.839 kB`
`react-portal` Portal	`11.649 kB` `4.263 kB`
`react-portal-compat` PortalCompatProvider	`6.446 kB` `2.185 kB`
`react-positioning` usePositioning	`24.008 kB` `8.798 kB`
`react-progress` ProgressBar	`16.409 kB` `5.855 kB`
`react-provider` FluentProvider	`20.78 kB` `7.135 kB`
`react-radio` Radio	`29.921 kB` `9.118 kB`
`react-radio` RadioGroup	`13.952 kB` `5.163 kB`
`react-select` Select	`28.004 kB` `9.223 kB`
`react-slider` Slider	`36.934 kB` `11.514 kB`
`react-spinbutton` SpinButton	`36.705 kB` `10.792 kB`
`react-spinner` Spinner	`23.515 kB` `7.226 kB`
`react-switch` Switch	`32.528 kB` `9.73 kB`
`react-table` DataGrid	`150.956 kB` `41.072 kB`
`react-table` Table (Primitives only)	`47.215 kB` `12.749 kB`
`react-table` Table as DataGrid	`133.551 kB` `33.685 kB`
`react-table` Table (Selection only)	`81.384 kB` `19.67 kB`
`react-table` Table (Sort only)	`80.714 kB` `19.479 kB`
`react-text` Text - Default	`15.03 kB` `5.339 kB`
`react-text` Text - Wrappers	`15.584 kB` `5.245 kB`
`react-textarea` Textarea	`30.203 kB` `9.519 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.33 kB` `6.764 kB`
`react-theme` Teams: Light theme	`17.895 kB` `5.162 kB`
`react-tooltip` Tooltip	`49.478 kB` `16.853 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against c0d55f77d73cdd700a6d5857995e8ffc3d4344f6}

fabricteam · 2023-04-14T09:09:08Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2023-04-14T09:14:29Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	792	794	5000
Breadcrumb	mount	2042	2050	1000
Checkbox	mount	2094	2106	5000
CheckboxBase	mount	1853	1842	5000
ChoiceGroup	mount	3571	3555	5000
ComboBox	mount	809	816	1000
CommandBar	mount	7820	7738	1000
ContextualMenu	mount	14154	13935	1000
DefaultButton	mount	944	953	5000
DetailsRow	mount	2653	2648	5000
DetailsRowFast	mount	2660	2650	5000
DetailsRowNoStyles	mount	2452	2432	5000
Dialog	mount	3191	3285	1000
DocumentCardTitle	mount	293	291	1000
Dropdown	mount	2451	2459	5000
FocusTrapZone	mount	1446	1433	5000
FocusZone	mount	1401	1380	5000
GroupedList	mount	45724	45580	2
GroupedList	virtual-rerender	22160	22128	2
GroupedList	virtual-rerender-with-unmount	62815	63021	2
GroupedListV2	mount	289	272	2
GroupedListV2	virtual-rerender	269	289	2
GroupedListV2	virtual-rerender-with-unmount	290	278	2
IconButton	mount	1326	1316	5000
Label	mount	468	447	5000
Layer	mount	3409	3380	5000
Link	mount	523	523	5000
MenuButton	mount	1174	1140	5000
MessageBar	mount	25931	26167	5000
Nav	mount	2354	2340	1000
OverflowSet	mount	1021	995	5000
Panel	mount	2175	2185	1000
Persona	mount	923	924	1000
Pivot	mount	1066	1066	1000
PrimaryButton	mount	1068	1035	5000
Rating	mount	5809	5763	5000
SearchBox	mount	1124	1104	5000
Shimmer	mount	2342	2368	5000
Slider	mount	1681	1673	5000
SpinButton	mount	3376	3435	5000
Spinner	mount	524	521	5000
SplitButton	mount	2194	2201	5000
Stack	mount	539	540	5000
StackWithIntrinsicChildren	mount	1068	1092	5000
StackWithTextChildren	mount	3430	3370	5000
SwatchColorPicker	mount	7424	7379	5000
TagPicker	mount	1743	1738	5000
Text	mount	495	488	5000
TextField	mount	1144	1146	5000
ThemeProvider	mount	1005	1011	5000
ThemeProvider	virtual-rerender	801	791	5000
ThemeProvider	virtual-rerender-with-unmount	1548	1559	5000
Toggle	mount	784	793	5000
buttonNative	mount	251	253	5000

change/@fluentui-eslint-plugin-4cb91116-336f-417b-b9d2-7f4cf3911568.json

…11568.json Co-authored-by: Tristan Watanabe <[email protected]>

fabricteam · 2023-04-14T17:25:44Z

🕵 fluentuiv9 No visual regressions between this PR and main

feat(eslint-plugin): enables jsxTags on comment for react config

376d9e5

bsunderhus added Fluent UI react-components (v9) Package: eslint-plugin labels Apr 14, 2023

bsunderhus self-assigned this Apr 14, 2023

msft-fluent-ui-bot added the Area: Build System label Apr 14, 2023

github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 14, 2023

bsunderhus mentioned this pull request Apr 14, 2023

chore(react-dialog): adopt custom JSX pragma #27475

Merged

bsunderhus marked this pull request as ready for review April 14, 2023 08:52

bsunderhus requested a review from a team as a code owner April 14, 2023 08:52

layershifter approved these changes Apr 14, 2023

View reviewed changes

TristanWatanabe approved these changes Apr 14, 2023

View reviewed changes

change/@fluentui-eslint-plugin-4cb91116-336f-417b-b9d2-7f4cf3911568.json Outdated Show resolved Hide resolved

Update change/@fluentui-eslint-plugin-4cb91116-336f-417b-b9d2-7f4cf39…

30fa762

…11568.json Co-authored-by: Tristan Watanabe <[email protected]>

bsunderhus enabled auto-merge (squash) April 14, 2023 17:02

bsunderhus disabled auto-merge April 15, 2023 08:28

bsunderhus merged commit bb758eb into microsoft:master Apr 15, 2023

bsunderhus deleted the eslint-plugin/enable-jsx-tags branch April 15, 2023 08:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(eslint-plugin): enables jsxTags on comment for react config #27571

feat(eslint-plugin): enables jsxTags on comment for react config #27571

Uh oh!

bsunderhus commented Apr 14, 2023 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Apr 14, 2023

Uh oh!

fabricteam commented Apr 14, 2023 •

edited

Loading

Uh oh!

size-auditor bot commented Apr 14, 2023 •

edited

Loading

Uh oh!

fabricteam commented Apr 14, 2023 •

edited

Loading

Uh oh!

fabricteam commented Apr 14, 2023 •

edited

Loading

Uh oh!

fabricteam commented Apr 14, 2023 •

edited

Loading

Uh oh!

fabricteam commented Apr 14, 2023 •

edited

Loading

Uh oh!

fabricteam commented Apr 14, 2023 •

edited

Loading

Uh oh!

Uh oh!

fabricteam commented Apr 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(eslint-plugin): enables jsxTags on comment for react config #27571

feat(eslint-plugin): enables jsxTags on comment for react config #27571

Uh oh!

Conversation

bsunderhus commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Uh oh!

codesandbox-ci bot commented Apr 14, 2023

Uh oh!

fabricteam commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor bot commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

fabricteam commented Apr 14, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bsunderhus commented Apr 14, 2023 •

edited

Loading

fabricteam commented Apr 14, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

size-auditor bot commented Apr 14, 2023 •

edited

Loading

fabricteam commented Apr 14, 2023 •

edited

Loading

fabricteam commented Apr 14, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Apr 14, 2023 •

edited

Loading

fabricteam commented Apr 14, 2023 •

edited

Loading

fabricteam commented Apr 14, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)