Skip to content

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Apr 13, 2023

New Behavior

Adopts react-jsx-runtime custom pragma on react-popover

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7200f00:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 13, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bb758eb9091e5c53f8d1d58baf50505aa2aa34cc (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.629 kB
57.6 kB
208.417 kB
57.925 kB
788 B
325 B
react-datepicker-compat
DatePicker Compat
251.37 kB
67.359 kB
252.153 kB
67.645 kB
783 B
286 B
react-infobutton
InfoButton
130.692 kB
39.476 kB
131.476 kB
39.787 kB
784 B
311 B
react-infobutton
InfoLabel
133.988 kB
40.514 kB
134.77 kB
40.807 kB
782 B
293 B
react-popover
Popover
117.611 kB
35.839 kB
117.751 kB
35.885 kB
140 B
46 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-alert
Alert
95.877 kB
23.104 kB
react-avatar
Avatar
59.542 kB
15.569 kB
react-avatar
AvatarGroup
18.19 kB
6.706 kB
react-avatar
AvatarGroupItem
75.803 kB
20.072 kB
react-components
react-components: Button, FluentProvider & webLightTheme
68.093 kB
18.424 kB
react-components
react-components: FluentProvider & webLightTheme
38.833 kB
12.37 kB
react-persona
Persona
66.568 kB
17.513 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
react-table
DataGrid
150.956 kB
41.072 kB
react-table
Table (Primitives only)
47.215 kB
12.749 kB
react-table
Table as DataGrid
133.551 kB
33.685 kB
react-table
Table (Selection only)
81.384 kB
19.67 kB
react-table
Table (Sort only)
80.714 kB
19.479 kB
🤖 This report was generated against bb758eb9091e5c53f8d1d58baf50505aa2aa34cc

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 19 21 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 701 705 5000
Button mount 390 380 5000
Field mount 1308 1286 5000
FluentProvider mount 891 904 5000
FluentProviderWithTheme mount 107 112 10
FluentProviderWithTheme virtual-rerender 98 91 10
FluentProviderWithTheme virtual-rerender-with-unmount 96 107 10
InfoButton mount 19 21 5000 Possible regression
MakeStyles mount 1121 1131 50000
Persona mount 2022 2008 5000
SpinButton mount 1605 1621 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus marked this pull request as ready for review April 13, 2023 12:51
@bsunderhus bsunderhus requested a review from a team as a code owner April 13, 2023 12:51
@bsunderhus bsunderhus force-pushed the react-popover/feat--adopt-custom-jsx-pragma branch from 990aed3 to 713b188 Compare April 14, 2023 09:01
@bsunderhus
Copy link
Contributor Author

I'll be waiting for #27571 before merging this PR

@bsunderhus bsunderhus added the Status: Blocked Resolution blocked by another issue label Apr 14, 2023
@bsunderhus bsunderhus force-pushed the react-popover/feat--adopt-custom-jsx-pragma branch from 713b188 to 7200f00 Compare April 15, 2023 09:10
@bsunderhus bsunderhus removed the Status: Blocked Resolution blocked by another issue label Apr 15, 2023
@bsunderhus bsunderhus enabled auto-merge (squash) April 15, 2023 09:10
@bsunderhus bsunderhus merged commit b415aef into microsoft:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants