Skip to content

Conversation

@bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-alert
  2. adds resolveShorthand to all slots (some root slots were missing it)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 416e7fc:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@bsunderhus bsunderhus marked this pull request as ready for review April 13, 2023 12:51
@bsunderhus bsunderhus requested a review from a team as a code owner April 13, 2023 12:51
@size-auditor
Copy link

size-auditor bot commented Apr 13, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bb758eb9091e5c53f8d1d58baf50505aa2aa34cc (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-alert
Alert
95.877 kB
23.104 kB
96.657 kB
23.331 kB
780 B
227 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
68.093 kB
18.424 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.629 kB
57.6 kB
react-components
react-components: FluentProvider & webLightTheme
38.833 kB
12.37 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against 2e1cf8928df3e4f0b64b7390408374db94ae9e2c

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 26 20 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 696 706 5000
Button mount 396 411 5000
Field mount 1258 1253 5000
FluentProvider mount 776 759 5000
FluentProviderWithTheme mount 107 106 10
FluentProviderWithTheme virtual-rerender 88 95 10
FluentProviderWithTheme virtual-rerender-with-unmount 100 101 10
InfoButton mount 26 20 5000 Possible regression
MakeStyles mount 1189 1193 50000
Persona mount 1958 1923 5000
SpinButton mount 1481 1495 5000

@bsunderhus bsunderhus force-pushed the react-alert/chore--adopt-custom-JSX-pragma branch from 940b3e6 to 064301a Compare April 14, 2023 09:13
@bsunderhus
Copy link
Contributor Author

I'll be waiting for #27571 before merging this PR

@bsunderhus bsunderhus added the Status: Blocked Resolution blocked by another issue label Apr 14, 2023
@bsunderhus bsunderhus force-pushed the react-alert/chore--adopt-custom-JSX-pragma branch from 064301a to 416e7fc Compare April 15, 2023 09:02
@bsunderhus bsunderhus removed the Status: Blocked Resolution blocked by another issue label Apr 15, 2023
@bsunderhus bsunderhus merged commit d055f16 into microsoft:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants