Skip to content

Conversation

@bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-table
  2. adds resolveShorthand to all slots (some root slots were missing it)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ffb72a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 21 14 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 723 690 5000
Button mount 394 396 5000
Field mount 1254 1262 5000
FluentProvider mount 769 761 5000
FluentProviderWithTheme mount 103 105 10
FluentProviderWithTheme virtual-rerender 92 87 10
FluentProviderWithTheme virtual-rerender-with-unmount 104 98 10
InfoButton mount 21 14 5000 Possible regression
MakeStyles mount 1200 1222 50000
Persona mount 1965 1907 5000
SpinButton mount 1469 1477 5000

@size-auditor
Copy link

size-auditor bot commented Apr 13, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bb758eb9091e5c53f8d1d58baf50505aa2aa34cc (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-table
DataGrid
150.956 kB
41.072 kB
151.536 kB
41.299 kB
580 B
227 B
react-table
Table (Primitives only)
47.215 kB
12.749 kB
47.143 kB
12.817 kB
-72 B
68 B
react-table
Table as DataGrid
133.551 kB
33.685 kB
134.099 kB
34.001 kB
548 B
316 B
react-table
Table (Selection only)
81.384 kB
19.67 kB
82.011 kB
20.028 kB
627 B
358 B
react-table
Table (Sort only)
80.714 kB
19.479 kB
81.341 kB
19.84 kB
627 B
361 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
68.093 kB
18.424 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.629 kB
57.6 kB
react-components
react-components: FluentProvider & webLightTheme
38.833 kB
12.37 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against 2e1cf8928df3e4f0b64b7390408374db94ae9e2c

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus marked this pull request as ready for review April 13, 2023 12:51
@bsunderhus bsunderhus requested a review from a team as a code owner April 13, 2023 12:51
@bsunderhus bsunderhus force-pushed the react-table/feat--adopt-custom-jsx-pragma branch from 2e317f1 to 61340e9 Compare April 14, 2023 09:11
@bsunderhus
Copy link
Contributor Author

I'll be waiting for #27571 before merging this PR

@bsunderhus bsunderhus added the Status: Blocked Resolution blocked by another issue label Apr 14, 2023
@bsunderhus bsunderhus force-pushed the react-table/feat--adopt-custom-jsx-pragma branch from 61340e9 to 3ffb72a Compare April 15, 2023 09:03
@bsunderhus bsunderhus removed the Status: Blocked Resolution blocked by another issue label Apr 15, 2023
@bsunderhus bsunderhus merged commit 82e7722 into microsoft:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants