Skip to content

chore: scaffolds react-trigger package #24887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bsunderhus merged 1 commit into from
Sep 22, 2022
Merged

chore: scaffolds react-trigger package #24887

bsunderhus merged 1 commit into from
Sep 22, 2022

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Sep 21, 2022

Scaffolds new package react-trigger to split trigger logics from react-utilities

@bsunderhus bsunderhus self-assigned this Sep 21, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 78.914 kB
24.06 kB
react-alert
Alert		 83.511 kB
20.921 kB
react-avatar
Avatar		 48.381 kB
13.696 kB
react-avatar
AvatarGroup		 14.95 kB
5.989 kB
react-avatar
AvatarGroupItem		 68.349 kB
19.039 kB
react-badge
Badge		 22.6 kB
7.205 kB
react-badge
CounterBadge		 23.503 kB
7.497 kB
react-badge
PresenceBadge		 24.05 kB
7.067 kB
react-button
Button		 36.119 kB
9.647 kB
react-button
CompoundButton		 43.144 kB
10.86 kB
react-button
MenuButton		 38.813 kB
10.551 kB
react-button
SplitButton		 46.228 kB
11.933 kB
react-button
ToggleButton		 51.888 kB
11.127 kB
react-card
Card - All		 67.002 kB
19.261 kB
react-card
Card		 62.684 kB
18.177 kB
react-card
CardFooter		 8.561 kB
3.601 kB
react-card
CardHeader		 9.604 kB
3.94 kB
react-card
CardPreview		 8.662 kB
3.656 kB
react-combobox
Combobox (including child components)		 74.636 kB
24.186 kB
react-combobox
Dropdown (including child components)		 74.236 kB
24.086 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 188.672 kB
52.359 kB
react-components
react-components: FluentProvider & webLightTheme		 33.394 kB
11.007 kB
react-dialog
Dialog (including children components)		 82.755 kB
24.581 kB
react-divider
Divider		 16.459 kB
5.902 kB
react-image
Image		 10.78 kB
4.264 kB
react-input
Input		 23.757 kB
7.704 kB
react-label
Label		 9.338 kB
3.86 kB
react-link
Link		 11.784 kB
4.867 kB
react-menu
Menu (including children components)		 116.572 kB
35.778 kB
react-menu
Menu (including selectable components)		 119.641 kB
36.297 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-popover
Popover		 102.963 kB
31.553 kB
react-portal
Portal		 10.576 kB
3.875 kB
react-portal-compat
PortalCompatProvider		 5.851 kB
1.964 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-provider
FluentProvider		 15.755 kB
5.883 kB
react-radio
Radio		 35.56 kB
11.929 kB
react-radio
RadioGroup		 14.248 kB
5.7 kB
react-select
Select		 20.846 kB
7.346 kB
react-slider
Slider		 31.526 kB
10.046 kB
react-spinbutton
SpinButton		 44.102 kB
12.425 kB
react-spinner
Spinner		 19.977 kB
6.438 kB
react-switch
Switch		 32.097 kB
10.27 kB
react-text
Text - Default		 11.782 kB
4.605 kB
react-text
Text - Wrappers		 15.092 kB
5.044 kB
react-textarea
Textarea		 25.013 kB
8.133 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.65 kB
6.444 kB
react-theme
Teams: Light theme		 17.486 kB
5.057 kB
react-tooltip
Tooltip		 41.535 kB
14.639 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 5ede3c878f0bc89e791314d5ac70e9449b6f06d2

@size-auditor
Copy link

size-auditor bot commented Sep 21, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5ede3c878f0bc89e791314d5ac70e9449b6f06d2 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1592 1566 5000
Button mount 1147 1106 5000
FluentProvider mount 1843 1895 5000
FluentProviderWithTheme mount 696 693 10
FluentProviderWithTheme virtual-rerender 640 643 10
FluentProviderWithTheme virtual-rerender-with-unmount 692 698 10
MakeStyles mount 2159 2179 50000
SpinButton mount 3062 3110 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 21, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6850413:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 184 165 1.12:1
SkeletonMinimalPerf.default 419 381 1.1:1
ChatWithPopoverPerf.default 445 409 1.09:1
DividerMinimalPerf.default 427 392 1.09:1
AttachmentSlotsPerf.default 1262 1170 1.08:1
AvatarMinimalPerf.default 209 196 1.07:1
ImageMinimalPerf.default 483 452 1.07:1
SegmentMinimalPerf.default 402 375 1.07:1
ChatMinimalPerf.default 846 795 1.06:1
LoaderMinimalPerf.default 748 709 1.06:1
PopupMinimalPerf.default 698 660 1.06:1
PortalMinimalPerf.default 183 172 1.06:1
CarouselMinimalPerf.default 523 497 1.05:1
IconMinimalPerf.default 767 732 1.05:1
AccordionMinimalPerf.default 155 149 1.04:1
BoxMinimalPerf.default 383 369 1.04:1
ButtonMinimalPerf.default 200 193 1.04:1
FlexMinimalPerf.default 312 300 1.04:1
FormMinimalPerf.default 442 425 1.04:1
LabelMinimalPerf.default 444 427 1.04:1
SliderMinimalPerf.default 1816 1751 1.04:1
TableManyItemsPerf.default 2192 2114 1.04:1
ChatDuplicateMessagesPerf.default 329 319 1.03:1
DialogMinimalPerf.default 853 829 1.03:1
HeaderMinimalPerf.default 406 396 1.03:1
LayoutMinimalPerf.default 406 396 1.03:1
MenuMinimalPerf.default 955 926 1.03:1
MenuButtonMinimalPerf.default 1911 1861 1.03:1
TextMinimalPerf.default 386 375 1.03:1
TreeWith60ListItems.default 183 177 1.03:1
ButtonSlotsPerf.default 639 628 1.02:1
DropdownMinimalPerf.default 2925 2857 1.02:1
HeaderSlotsPerf.default 896 880 1.02:1
ListNestedPerf.default 653 639 1.02:1
SplitButtonMinimalPerf.default 4877 4786 1.02:1
VideoMinimalPerf.default 845 826 1.02:1
AnimationMinimalPerf.default 572 569 1.01:1
DropdownManyItemsPerf.default 769 758 1.01:1
GridMinimalPerf.default 380 376 1.01:1
ListCommonPerf.default 708 700 1.01:1
ProviderMergeThemesPerf.default 1319 1302 1.01:1
RefMinimalPerf.default 234 231 1.01:1
TextAreaMinimalPerf.default 571 566 1.01:1
TreeMinimalPerf.default 913 905 1.01:1
ButtonOverridesMissPerf.default 1445 1441 1:1
CheckboxMinimalPerf.default 2320 2324 1:1
DatepickerMinimalPerf.default 6666 6643 1:1
EmbedMinimalPerf.default 4084 4067 1:1
ItemLayoutMinimalPerf.default 1337 1333 1:1
ListWith60ListItems.default 700 697 1:1
RosterPerf.default 2401 2404 1:1
ToolbarMinimalPerf.default 1055 1060 1:1
InputMinimalPerf.default 1239 1248 0.99:1
ListMinimalPerf.default 565 570 0.99:1
ReactionMinimalPerf.default 420 424 0.99:1
CustomToolbarPrototype.default 2851 2888 0.99:1
TooltipMinimalPerf.default 2558 2575 0.99:1
AlertMinimalPerf.default 305 311 0.98:1
ProviderMinimalPerf.default 417 424 0.98:1
RadioGroupMinimalPerf.default 504 516 0.98:1
CardMinimalPerf.default 608 630 0.97:1
StatusMinimalPerf.default 773 799 0.97:1
TableMinimalPerf.default 440 470 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1580 1591 5000
Breadcrumb mount 3715 3758 1000
Checkbox mount 3536 3465 5000
CheckboxBase mount 3116 3190 5000
ChoiceGroup mount 5923 6011 5000
ComboBox mount 1589 1626 1000
CommandBar mount 12255 12144 1000
ContextualMenu mount 13970 14034 1000
DefaultButton mount 1827 1828 5000
DetailsRow mount 4861 4806 5000
DetailsRowFast mount 4962 4808 5000
DetailsRowNoStyles mount 4624 4552 5000
Dialog mount 3960 3941 1000
DocumentCardTitle mount 738 758 1000
Dropdown mount 4426 4338 5000
FocusTrapZone mount 2590 2564 5000
FocusZone mount 2558 2484 5000
GroupedList mount 72210 82454 2
GroupedList virtual-rerender 33788 33704 2
GroupedList virtual-rerender-with-unmount 113912 113531 2
GroupedListV2 mount 729 703 2
GroupedListV2 virtual-rerender 670 676 2
GroupedListV2 virtual-rerender-with-unmount 729 724 2
IconButton mount 2590 2545 5000
Label mount 953 930 5000
Layer mount 5506 5448 5000
Link mount 1078 1062 5000
MenuButton mount 2256 2288 5000
MessageBar mount 3059 3007 5000
Nav mount 4380 4384 1000
OverflowSet mount 1804 1810 5000
Panel mount 3323 3243 1000
Persona mount 1687 1681 1000
Pivot mount 2110 2123 1000
PrimaryButton mount 2033 2036 5000
Rating mount 9709 9594 5000
SearchBox mount 2062 2042 5000
Shimmer mount 3813 3856 5000
Slider mount 2778 2766 5000
SpinButton mount 6133 6139 5000
Spinner mount 1033 1023 5000
SplitButton mount 4078 4075 5000
Stack mount 1098 1147 5000
StackWithIntrinsicChildren mount 3272 3310 5000
StackWithTextChildren mount 6765 6672 5000
SwatchColorPicker mount 13795 13844 5000
TagPicker mount 3552 3543 5000
TeachingBubble mount 111404 112228 5000
Text mount 1048 1025 5000
TextField mount 2129 2100 5000
ThemeProvider mount 1944 1938 5000
ThemeProvider virtual-rerender 1370 1354 5000
ThemeProvider virtual-rerender-with-unmount 2814 2748 5000
Toggle mount 1452 1451 5000
buttonNative mount 687 702 5000

@bsunderhus bsunderhus force-pushed the chore--scaffolds-react-trigger-package branch from be3b71e to 6850413 Compare September 21, 2022 12:52
@bsunderhus bsunderhus marked this pull request as ready for review September 21, 2022 13:18
@bsunderhus bsunderhus merged commit bc07875 into microsoft:master Sep 22, 2022
@bsunderhus bsunderhus deleted the chore--scaffolds-react-trigger-package branch September 22, 2022 11:54
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 24, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
bb44387 
* master: (29 commits)
  chore(react-tooltip): update package scaffold (microsoft#24927)
  chore(react-popover): update package scaffold (microsoft#24925)
  chore(react-overflow): update package scaffold (microsoft#24926)
  chore(react-menu): update package scaffold (microsoft#24924)
  applying package updates
  chore: Bump workspace-tools to 0.27.0 (microsoft#24914)
  fix: Make Menu openOnHover prop work again (microsoft#24899)
  stress test: convert cli scripts to typescript (microsoft#24915)
  update package manifest to only include v8 controls (microsoft#24839)
  Stress Test: add random tree (microsoft#24896)
  chore: Expand scope of dependency mismatch generator (microsoft#24880)
  chore: run dependency mismatch generator in release pipeline (microsoft#24881)
  chore: scaffolds react-trigger package (microsoft#24887)
  applying package updates
  chore: a11y docs structure update (microsoft#24871)
  feat: add popupProps to Modal component to allow override internal Popup props (microsoft#24693)
  fix: Set github user in nightly release pipeline (microsoft#24850)
  chore(react-aria): restructure folder organization (microsoft#24884)
  ci(github): fix invalid json string in issues.yml v2 (microsoft#24886)
  Add react-components/unstable to tsconfig aliases (microsoft#24878)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@bsunderhus @NotWoods
chore: scaffolds react-trigger package (microsoft#24887)
b7ef544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JustSlone JustSlone JustSlone approved these changes

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bsunderhus bsunderhus

Labels

Fluent UI react-components (v9)

Projects

None yet

Milestone

September Project Cycle Q1 2022

Development

Successfully merging this pull request may close these issues.

4 participants

@bsunderhus @fabricteam @ling1726 @JustSlone