update package manifest to only include v8 controls #24839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove non v8 packages from manifest
Member
Author
|
One valid question that comes up....do we need a manifest for v9 or any other packages? Or is this just a legacy v8 concern? |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1272 | 1268 | 5000 | |
| Button | mount | 926 | 938 | 5000 | |
| FluentProvider | mount | 1479 | 1494 | 5000 | |
| FluentProviderWithTheme | mount | 575 | 575 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 540 | 546 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 567 | 590 | 10 | |
| MakeStyles | mount | 1952 | 1935 | 50000 | |
| SpinButton | mount | 2340 | 2358 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 134 | 117 | 1.15:1 |
| AccordionMinimalPerf.default | 129 | 119 | 1.08:1 |
| ButtonMinimalPerf.default | 141 | 133 | 1.06:1 |
| ListCommonPerf.default | 531 | 501 | 1.06:1 |
| CarouselMinimalPerf.default | 360 | 342 | 1.05:1 |
| SegmentMinimalPerf.default | 312 | 297 | 1.05:1 |
| AvatarMinimalPerf.default | 163 | 159 | 1.03:1 |
| ButtonSlotsPerf.default | 433 | 421 | 1.03:1 |
| ChatWithPopoverPerf.default | 296 | 286 | 1.03:1 |
| TableMinimalPerf.default | 363 | 354 | 1.03:1 |
| BoxMinimalPerf.default | 294 | 289 | 1.02:1 |
| DropdownManyItemsPerf.default | 550 | 541 | 1.02:1 |
| FormMinimalPerf.default | 330 | 324 | 1.02:1 |
| ListNestedPerf.default | 474 | 466 | 1.02:1 |
| RefMinimalPerf.default | 187 | 183 | 1.02:1 |
| SkeletonMinimalPerf.default | 309 | 302 | 1.02:1 |
| TooltipMinimalPerf.default | 1878 | 1836 | 1.02:1 |
| AnimationMinimalPerf.default | 474 | 469 | 1.01:1 |
| EmbedMinimalPerf.default | 2653 | 2633 | 1.01:1 |
| HeaderSlotsPerf.default | 680 | 675 | 1.01:1 |
| ImageMinimalPerf.default | 346 | 342 | 1.01:1 |
| InputMinimalPerf.default | 862 | 856 | 1.01:1 |
| RosterPerf.default | 1689 | 1673 | 1.01:1 |
| RadioGroupMinimalPerf.default | 396 | 391 | 1.01:1 |
| ReactionMinimalPerf.default | 327 | 325 | 1.01:1 |
| StatusMinimalPerf.default | 608 | 604 | 1.01:1 |
| TextMinimalPerf.default | 301 | 298 | 1.01:1 |
| ToolbarMinimalPerf.default | 793 | 789 | 1.01:1 |
| TreeMinimalPerf.default | 691 | 682 | 1.01:1 |
| AlertMinimalPerf.default | 218 | 218 | 1:1 |
| ButtonOverridesMissPerf.default | 1015 | 1015 | 1:1 |
| CardMinimalPerf.default | 465 | 465 | 1:1 |
| CheckboxMinimalPerf.default | 1524 | 1520 | 1:1 |
| DatepickerMinimalPerf.default | 4703 | 4688 | 1:1 |
| DialogMinimalPerf.default | 692 | 691 | 1:1 |
| DividerMinimalPerf.default | 312 | 312 | 1:1 |
| DropdownMinimalPerf.default | 2172 | 2172 | 1:1 |
| GridMinimalPerf.default | 300 | 299 | 1:1 |
| ItemLayoutMinimalPerf.default | 984 | 984 | 1:1 |
| ListWith60ListItems.default | 492 | 494 | 1:1 |
| LoaderMinimalPerf.default | 514 | 512 | 1:1 |
| MenuMinimalPerf.default | 731 | 731 | 1:1 |
| PopupMinimalPerf.default | 560 | 558 | 1:1 |
| SliderMinimalPerf.default | 1238 | 1240 | 1:1 |
| SplitButtonMinimalPerf.default | 3277 | 3263 | 1:1 |
| IconMinimalPerf.default | 560 | 559 | 1:1 |
| CustomToolbarPrototype.default | 2160 | 2163 | 1:1 |
| VideoMinimalPerf.default | 619 | 620 | 1:1 |
| AttachmentSlotsPerf.default | 862 | 868 | 0.99:1 |
| ChatMinimalPerf.default | 638 | 646 | 0.99:1 |
| FlexMinimalPerf.default | 246 | 249 | 0.99:1 |
| LayoutMinimalPerf.default | 310 | 312 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1356 | 1363 | 0.99:1 |
| ProviderMergeThemesPerf.default | 979 | 988 | 0.99:1 |
| TableManyItemsPerf.default | 1562 | 1584 | 0.99:1 |
| TextAreaMinimalPerf.default | 407 | 410 | 0.99:1 |
| TreeWith60ListItems.default | 125 | 126 | 0.99:1 |
| HeaderMinimalPerf.default | 315 | 320 | 0.98:1 |
| LabelMinimalPerf.default | 337 | 344 | 0.98:1 |
| ProviderMinimalPerf.default | 309 | 314 | 0.98:1 |
| PortalMinimalPerf.default | 138 | 142 | 0.97:1 |
| ChatDuplicateMessagesPerf.default | 217 | 225 | 0.96:1 |
| ListMinimalPerf.default | 441 | 463 | 0.95:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8b00cf2:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9617a5a46ef4c5e310a066a5374ff2ed61db3c66 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1184 | 1181 | 5000 | |
| Breadcrumb | mount | 2776 | 2769 | 1000 | |
| Checkbox | mount | 2638 | 2643 | 5000 | |
| CheckboxBase | mount | 2367 | 2375 | 5000 | |
| ChoiceGroup | mount | 4255 | 4216 | 5000 | |
| ComboBox | mount | 1177 | 1174 | 1000 | |
| CommandBar | mount | 9273 | 9169 | 1000 | |
| ContextualMenu | mount | 10188 | 10188 | 1000 | |
| DefaultButton | mount | 1350 | 1359 | 5000 | |
| DetailsRow | mount | 3351 | 3356 | 5000 | |
| DetailsRowFast | mount | 3391 | 3367 | 5000 | |
| DetailsRowNoStyles | mount | 3232 | 3212 | 5000 | |
| Dialog | mount | 2976 | 2950 | 1000 | |
| DocumentCardTitle | mount | 583 | 574 | 1000 | |
| Dropdown | mount | 3144 | 3191 | 5000 | |
| FocusTrapZone | mount | 1966 | 1963 | 5000 | |
| FocusZone | mount | 1932 | 1885 | 5000 | |
| GroupedList | mount | 47702 | 53909 | 2 | |
| GroupedList | virtual-rerender | 23236 | 23003 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 82209 | 82304 | 2 | |
| GroupedListV2 | mount | 552 | 560 | 2 | |
| GroupedListV2 | virtual-rerender | 529 | 525 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 571 | 566 | 2 | |
| IconButton | mount | 1784 | 1769 | 5000 | |
| Label | mount | 752 | 752 | 5000 | |
| Layer | mount | 4113 | 4114 | 5000 | |
| Link | mount | 849 | 848 | 5000 | |
| MenuButton | mount | 1613 | 1636 | 5000 | |
| MessageBar | mount | 2313 | 2328 | 5000 | |
| Nav | mount | 3083 | 3040 | 1000 | |
| OverflowSet | mount | 1416 | 1399 | 5000 | |
| Panel | mount | 2490 | 2471 | 1000 | |
| Persona | mount | 1253 | 1242 | 1000 | |
| Pivot | mount | 1495 | 1510 | 1000 | |
| PrimaryButton | mount | 1488 | 1485 | 5000 | |
| Rating | mount | 6959 | 6956 | 5000 | |
| SearchBox | mount | 1499 | 1531 | 5000 | |
| Shimmer | mount | 2932 | 2896 | 5000 | |
| Slider | mount | 2106 | 2106 | 5000 | |
| SpinButton | mount | 4280 | 4332 | 5000 | |
| Spinner | mount | 828 | 835 | 5000 | |
| SplitButton | mount | 2814 | 2846 | 5000 | |
| Stack | mount | 891 | 903 | 5000 | |
| StackWithIntrinsicChildren | mount | 2232 | 2246 | 5000 | |
| StackWithTextChildren | mount | 4904 | 4911 | 5000 | |
| SwatchColorPicker | mount | 9543 | 9548 | 5000 | |
| TagPicker | mount | 2354 | 2290 | 5000 | |
| TeachingBubble | mount | 75815 | 75154 | 5000 | |
| Text | mount | 826 | 836 | 5000 | |
| TextField | mount | 1569 | 1578 | 5000 | |
| ThemeProvider | mount | 1442 | 1453 | 5000 | |
| ThemeProvider | virtual-rerender | 1135 | 1134 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1993 | 2009 | 5000 | |
| Toggle | mount | 1142 | 1118 | 5000 | |
| buttonNative | mount | 533 | 537 | 5000 |
github-actions
bot
modified the milestones:
July Project Cycle Q3 2022,
September Project Cycle Q1 2022
dmichon-msft
approved these changes
Sep 21, 2022
Contributor
|
We currently have no plans for repo-wide consumption of v9, though there are some packages that have started adopting said components, so it might be useful. |
Member
Author
|
@dmichon-msft Would you need a separate manifest that only includes the v9 packages? If so, can you open an issue describing that need? |
TristanWatanabe
approved these changes
Sep 22, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 24, 2022
* master: (29 commits) chore(react-tooltip): update package scaffold (microsoft#24927) chore(react-popover): update package scaffold (microsoft#24925) chore(react-overflow): update package scaffold (microsoft#24926) chore(react-menu): update package scaffold (microsoft#24924) applying package updates chore: Bump workspace-tools to 0.27.0 (microsoft#24914) fix: Make Menu openOnHover prop work again (microsoft#24899) stress test: convert cli scripts to typescript (microsoft#24915) update package manifest to only include v8 controls (microsoft#24839) Stress Test: add random tree (microsoft#24896) chore: Expand scope of dependency mismatch generator (microsoft#24880) chore: run dependency mismatch generator in release pipeline (microsoft#24881) chore: scaffolds react-trigger package (microsoft#24887) applying package updates chore: a11y docs structure update (microsoft#24871) feat: add popupProps to Modal component to allow override internal Popup props (microsoft#24693) fix: Set github user in nightly release pipeline (microsoft#24850) chore(react-aria): restructure folder organization (microsoft#24884) ci(github): fix invalid json string in issues.yml v2 (microsoft#24886) Add react-components/unstable to tsconfig aliases (microsoft#24878) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* chnage getAllPackageInfo to accept omitted path list, and use list to remove non v8 packages from manifest * add type * possible null omitted paths * revert getAllPackageInfo and just do logic in package manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24821