chore: a11y docs structure update #24871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3215b65:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1316 | 1295 | 5000 | |
| Button | mount | 960 | 953 | 5000 | |
| FluentProvider | mount | 1588 | 1584 | 5000 | |
| FluentProviderWithTheme | mount | 623 | 634 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 588 | 599 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 631 | 631 | 10 | |
| MakeStyles | mount | 1909 | 1913 | 50000 | |
| SpinButton | mount | 2507 | 2514 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 62aadfe9a8429fbc5c0660c1e741e5e8171f8f23 (build) |
|
|
||
| How this is read also depends on the screen reader used but a screen reader should read the displayed text consistently with how it would read it in other contexts (i.e., "$1" should be read as "one dollar"). | ||
|
|
||
| ### Styling |
Member
There was a problem hiding this comment.
is this just a stub for later? should we ommit empty areas for now.
Contributor
Author
There was a problem hiding this comment.
Yup, though that wasn’t added in this PR. For now I’m just moving the files and updating the docs nav structure, and sometime this week I plan to fill in these sections 😄
| parameters: { | ||
| docs: { | ||
| description: { | ||
| component: [descriptionMd, bestPracticesMd, accessibilityMd].join('\n'), |
Member
There was a problem hiding this comment.
How about linking from the SpinButton to the a11y docs
Contributor
Author
There was a problem hiding this comment.
Yup, it’s in the plan! I’m going to be adding an a11y authoring section next to best practices that will link to the full descriptive spec
micahgodbolt
approved these changes
Sep 20, 2022
Member
micahgodbolt
left a comment
micahgodbolt
left a comment
There was a problem hiding this comment.
Few nits, otherwise good.
behowell
approved these changes
Sep 20, 2022
khmakoto
approved these changes
Sep 20, 2022
spmonahan
approved these changes
Sep 20, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
sopranopillow
approved these changes
Sep 20, 2022
auto-merge was automatically disabled
September 21, 2022 21:25
Pull request was closed
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 24, 2022
* master: (29 commits) chore(react-tooltip): update package scaffold (microsoft#24927) chore(react-popover): update package scaffold (microsoft#24925) chore(react-overflow): update package scaffold (microsoft#24926) chore(react-menu): update package scaffold (microsoft#24924) applying package updates chore: Bump workspace-tools to 0.27.0 (microsoft#24914) fix: Make Menu openOnHover prop work again (microsoft#24899) stress test: convert cli scripts to typescript (microsoft#24915) update package manifest to only include v8 controls (microsoft#24839) Stress Test: add random tree (microsoft#24896) chore: Expand scope of dependency mismatch generator (microsoft#24880) chore: run dependency mismatch generator in release pipeline (microsoft#24881) chore: scaffolds react-trigger package (microsoft#24887) applying package updates chore: a11y docs structure update (microsoft#24871) feat: add popupProps to Modal component to allow override internal Popup props (microsoft#24693) fix: Set github user in nightly release pipeline (microsoft#24850) chore(react-aria): restructure folder organization (microsoft#24884) ci(github): fix invalid json string in issues.yml v2 (microsoft#24886) Add react-components/unstable to tsconfig aliases (microsoft#24878) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the SpinButton accessibility spec page to Concepts/Developer/Accessibility/Components. The goal is to have an a11y spec per component. There will also be a separate, more concise a11y author implementation section next to best practices.
There are some unrelated whitespace/formatting updates to the spinbutton a11y doc from running prettier.