Skip to content

Conversation

@ling1726
Copy link
Contributor

Runs the generator in both v8 and v9 releases
Fixes #24207

Runs the generator in both v8 and v9 releases
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a571a80:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 21, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0698ca13b3366a7443bcc4093a9ca1ef3fba4533 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1287 1261 5000
Button mount 929 940 5000
FluentProvider mount 1480 1506 5000
FluentProviderWithTheme mount 582 573 10
FluentProviderWithTheme virtual-rerender 557 546 10
FluentProviderWithTheme virtual-rerender-with-unmount 571 571 10
MakeStyles mount 1966 1973 50000
SpinButton mount 2330 2324 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
78.914 kB
24.06 kB
react-alert
Alert
83.511 kB
20.921 kB
react-avatar
Avatar
48.381 kB
13.696 kB
react-avatar
AvatarGroup
14.95 kB
5.989 kB
react-avatar
AvatarGroupItem
68.349 kB
19.039 kB
react-badge
Badge
22.6 kB
7.205 kB
react-badge
CounterBadge
23.503 kB
7.497 kB
react-badge
PresenceBadge
24.05 kB
7.067 kB
react-button
Button
36.119 kB
9.647 kB
react-button
CompoundButton
43.144 kB
10.86 kB
react-button
MenuButton
38.813 kB
10.551 kB
react-button
SplitButton
46.228 kB
11.933 kB
react-button
ToggleButton
51.888 kB
11.127 kB
react-card
Card - All
67.002 kB
19.261 kB
react-card
Card
62.684 kB
18.177 kB
react-card
CardFooter
8.561 kB
3.601 kB
react-card
CardHeader
9.604 kB
3.94 kB
react-card
CardPreview
8.662 kB
3.656 kB
react-combobox
Combobox (including child components)
74.636 kB
24.186 kB
react-combobox
Dropdown (including child components)
74.236 kB
24.086 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.672 kB
52.359 kB
react-components
react-components: FluentProvider & webLightTheme
33.394 kB
11.007 kB
react-dialog
Dialog (including children components)
82.755 kB
24.581 kB
react-divider
Divider
16.459 kB
5.902 kB
react-image
Image
10.78 kB
4.264 kB
react-input
Input
23.757 kB
7.704 kB
react-label
Label
9.338 kB
3.86 kB
react-link
Link
11.784 kB
4.867 kB
react-menu
Menu (including children components)
116.572 kB
35.778 kB
react-menu
Menu (including selectable components)
119.641 kB
36.297 kB
react-overflow
hooks only
10.685 kB
4.104 kB
react-popover
Popover
102.963 kB
31.553 kB
react-portal
Portal
10.576 kB
3.875 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
react-positioning
usePositioning
19.7 kB
7.404 kB
react-provider
FluentProvider
15.755 kB
5.883 kB
react-radio
Radio
35.56 kB
11.929 kB
react-radio
RadioGroup
14.248 kB
5.7 kB
react-select
Select
20.846 kB
7.346 kB
react-slider
Slider
31.526 kB
10.046 kB
react-spinbutton
SpinButton
44.102 kB
12.425 kB
react-spinner
Spinner
19.977 kB
6.438 kB
react-switch
Switch
32.097 kB
10.27 kB
react-text
Text - Default
11.782 kB
4.605 kB
react-text
Text - Wrappers
15.092 kB
5.044 kB
react-textarea
Textarea
25.013 kB
8.133 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.65 kB
6.444 kB
react-theme
Teams: Light theme
17.486 kB
5.057 kB
react-tooltip
Tooltip
41.535 kB
14.639 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 4dd18085b968e10d512c179705d31148e28148b4

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2022

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 133 122 1.09:1
RefMinimalPerf.default 201 185 1.09:1
AvatarMinimalPerf.default 174 162 1.07:1
FlexMinimalPerf.default 260 246 1.06:1
FormMinimalPerf.default 337 319 1.06:1
ImageMinimalPerf.default 344 324 1.06:1
SegmentMinimalPerf.default 318 301 1.06:1
IconMinimalPerf.default 573 540 1.06:1
DividerMinimalPerf.default 324 308 1.05:1
BoxMinimalPerf.default 307 295 1.04:1
TableMinimalPerf.default 368 354 1.04:1
ListMinimalPerf.default 467 452 1.03:1
LoaderMinimalPerf.default 528 512 1.03:1
PopupMinimalPerf.default 565 551 1.03:1
PortalMinimalPerf.default 146 142 1.03:1
ProviderMinimalPerf.default 321 313 1.03:1
ChatMinimalPerf.default 639 625 1.02:1
ChatWithPopoverPerf.default 292 287 1.02:1
GridMinimalPerf.default 307 300 1.02:1
LabelMinimalPerf.default 341 334 1.02:1
RadioGroupMinimalPerf.default 396 389 1.02:1
StatusMinimalPerf.default 606 597 1.02:1
TableManyItemsPerf.default 1593 1558 1.02:1
TextAreaMinimalPerf.default 414 407 1.02:1
ToolbarMinimalPerf.default 809 790 1.02:1
TreeMinimalPerf.default 695 679 1.02:1
TreeWith60ListItems.default 127 125 1.02:1
AnimationMinimalPerf.default 472 467 1.01:1
ButtonOverridesMissPerf.default 1024 1013 1.01:1
ItemLayoutMinimalPerf.default 973 964 1.01:1
ListCommonPerf.default 519 513 1.01:1
ListWith60ListItems.default 497 493 1.01:1
ReactionMinimalPerf.default 323 319 1.01:1
TooltipMinimalPerf.default 1879 1857 1.01:1
AttachmentSlotsPerf.default 873 875 1:1
CheckboxMinimalPerf.default 1538 1535 1:1
DialogMinimalPerf.default 683 680 1:1
DropdownMinimalPerf.default 2186 2176 1:1
HeaderMinimalPerf.default 314 314 1:1
MenuButtonMinimalPerf.default 1362 1360 1:1
RosterPerf.default 1712 1711 1:1
SplitButtonMinimalPerf.default 3258 3257 1:1
CustomToolbarPrototype.default 2158 2151 1:1
ButtonMinimalPerf.default 138 140 0.99:1
ButtonSlotsPerf.default 432 435 0.99:1
CardMinimalPerf.default 463 470 0.99:1
DatepickerMinimalPerf.default 4578 4645 0.99:1
DropdownManyItemsPerf.default 540 543 0.99:1
EmbedMinimalPerf.default 2626 2644 0.99:1
HeaderSlotsPerf.default 679 685 0.99:1
InputMinimalPerf.default 846 856 0.99:1
ListNestedPerf.default 463 469 0.99:1
MenuMinimalPerf.default 727 735 0.99:1
ProviderMergeThemesPerf.default 987 992 0.99:1
SkeletonMinimalPerf.default 300 304 0.99:1
SliderMinimalPerf.default 1240 1247 0.99:1
TextMinimalPerf.default 301 303 0.99:1
VideoMinimalPerf.default 624 631 0.99:1
AttachmentMinimalPerf.default 125 127 0.98:1
LayoutMinimalPerf.default 310 317 0.98:1
CarouselMinimalPerf.default 351 361 0.97:1
ChatDuplicateMessagesPerf.default 220 229 0.96:1
AlertMinimalPerf.default 220 231 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 21, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1191 1190 5000
Breadcrumb mount 2933 2906 1000
Checkbox mount 2654 2640 5000
CheckboxBase mount 2366 2377 5000
ChoiceGroup mount 4411 4386 5000
ComboBox mount 1259 1271 1000
CommandBar mount 9674 9576 1000
ContextualMenu mount 11056 11467 1000
DefaultButton mount 1385 1370 5000
DetailsRow mount 3651 3645 5000
DetailsRowFast mount 3655 3628 5000
DetailsRowNoStyles mount 3472 3490 5000
Dialog mount 3135 3164 1000
DocumentCardTitle mount 578 584 1000
Dropdown mount 3288 3283 5000
FocusTrapZone mount 2007 2026 5000
FocusZone mount 1990 1998 5000
GroupedList mount 54033 62215 2
GroupedList virtual-rerender 25458 25674 2
GroupedList virtual-rerender-with-unmount 95736 95092 2
GroupedListV2 mount 570 577 2
GroupedListV2 virtual-rerender 526 528 2
GroupedListV2 virtual-rerender-with-unmount 553 572 2
IconButton mount 1916 2083 5000
Label mount 725 734 5000
Layer mount 4240 4258 5000
Link mount 833 827 5000
MenuButton mount 1668 1677 5000
MessageBar mount 2302 2309 5000
Nav mount 3283 3278 1000
OverflowSet mount 1395 1381 5000
Panel mount 2616 2562 1000
Persona mount 1278 1287 1000
Pivot mount 1653 1667 1000
PrimaryButton mount 1516 1526 5000
Rating mount 6993 7092 5000
SearchBox mount 1519 1508 5000
Shimmer mount 2852 2954 5000
Slider mount 2105 2111 5000
SpinButton mount 4714 4716 5000
Spinner mount 810 815 5000
SplitButton mount 3067 3083 5000
Stack mount 865 865 5000
StackWithIntrinsicChildren mount 2353 2365 5000
StackWithTextChildren mount 4855 4805 5000
SwatchColorPicker mount 10511 10577 5000
TagPicker mount 2638 2665 5000
TeachingBubble mount 85996 85515 5000
Text mount 796 780 5000
TextField mount 1608 1593 5000
ThemeProvider mount 1525 1526 5000
ThemeProvider virtual-rerender 1087 1066 5000
ThemeProvider virtual-rerender-with-unmount 2152 2167 5000
Toggle mount 1122 1116 5000
buttonNative mount 534 544 5000

@ling1726 ling1726 merged commit 9cb2cba into microsoft:master Sep 22, 2022
ling1726 added a commit to ling1726/fluentui that referenced this pull request Sep 22, 2022
Follow up of microsoft#24881 which upated beachball to a version that required
^0.27.0. The API broke multiple times between our current version of
beachball and the one upgrade.

Fixes beachball in our repo
ling1726 added a commit that referenced this pull request Sep 23, 2022
* chore: Bump workspace-tools to 0.27.0

Follow up of #24881 which upated beachball to a version that required
^0.27.0. The API broke multiple times between our current version of
beachball and the one upgrade.

Fixes beachball in our repo

* remove resolution for workspace-tools
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 24, 2022
* master: (29 commits)
  chore(react-tooltip): update package scaffold (microsoft#24927)
  chore(react-popover): update package scaffold (microsoft#24925)
  chore(react-overflow): update package scaffold (microsoft#24926)
  chore(react-menu): update package scaffold (microsoft#24924)
  applying package updates
  chore: Bump workspace-tools to 0.27.0 (microsoft#24914)
  fix: Make Menu openOnHover prop work again (microsoft#24899)
  stress test: convert cli scripts to typescript (microsoft#24915)
  update package manifest to only include v8 controls (microsoft#24839)
  Stress Test: add random tree (microsoft#24896)
  chore: Expand scope of dependency mismatch generator (microsoft#24880)
  chore: run dependency mismatch generator in release pipeline (microsoft#24881)
  chore: scaffolds react-trigger package (microsoft#24887)
  applying package updates
  chore: a11y docs structure update (microsoft#24871)
  feat: add popupProps to Modal component to allow override internal Popup props (microsoft#24693)
  fix: Set github user in nightly release pipeline (microsoft#24850)
  chore(react-aria): restructure folder organization (microsoft#24884)
  ci(github): fix invalid json string in issues.yml v2 (microsoft#24886)
  Add react-components/unstable to tsconfig aliases (microsoft#24878)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
…ft#24881)

* chore: run dependency mismatch generator in release pipeline

Runs the generator in both v8 and v9 releases

* add comment

* update test
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
* chore: Bump workspace-tools to 0.27.0

Follow up of microsoft#24881 which upated beachball to a version that required
^0.27.0. The API broke multiple times between our current version of
beachball and the one upgrade.

Fixes beachball in our repo

* remove resolution for workspace-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate dependency mismatch generator to release pipeline

5 participants