chore(react-avatar): Adding unit and vr tests for AvatarGroup #23549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopranopillow
added
Fluent UI react-components (v9)
Component: AvatarGroup
sopranopillow
requested review from
a team,
behowell and
khmakoto
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d819130:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1369 | 1310 | 5000 | |
| Button | mount | 1017 | 1003 | 5000 | |
| FluentProvider | mount | 1724 | 1752 | 5000 | |
| FluentProviderWithTheme | mount | 696 | 686 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 633 | 670 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 717 | 682 | 10 | |
| MakeStyles | mount | 2091 | 2104 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2765b1f72c50c96e7f8e433d80762e9fa25d685f (build) |
spmonahan
reviewed
Jun 16, 2022
packages/react-components/react-avatar/src/components/AvatarGroup/AvatarGroup.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/components/AvatarGroup/AvatarGroup.test.tsx
Outdated
Show resolved
Hide resolved
khmakoto
reviewed
Jun 16, 2022
apps/vr-tests-react-components/src/stories/AvatarGroup.stories.tsx
Outdated
Show resolved
Hide resolved
…4e2e.json Co-authored-by: Makoto Morimoto <[email protected]>
….tsx Co-authored-by: Makoto Morimoto <[email protected]>
…oup/AvatarGroup.test.tsx Co-authored-by: Sean Monahan <[email protected]>
This was referenced Jun 21, 2022
khmakoto
approved these changes
Jun 28, 2022
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 29, 2022
…ect-amout-of-items * master: chore: improve error message in useIsSSR() (microsoft#23750) fix: Codesandbox exports should use ^9.0.0 (microsoft#23764) applying package updates Update BadgeColor.stories.tsx (microsoft#23762) chore(react-avatar): Adding unit and vr tests for AvatarGroup (microsoft#23549) docs(react-avatar): Adding readme and migration guide for AvatarGroup (microsoft#23758) update deps after 9.0.1 release (microsoft#23756) applying package updates fix: Use caret dependency range for Griffel (microsoft#23754) Theme designer: minor fixes (microsoft#23741) fix: Dependency mismatch after 9.0.0 release (microsoft#23752)
khmakoto
added a commit
to khmakoto/fluentui
that referenced
this pull request
Jul 13, 2022
…oft#23549) * adding testing to AvatarGroup * restore badge api file * change fileS * reverting api file * fixing interactive story in vr-tests * fixing cropping of interactive story * possible border radius fix * removing unnecessary div * reverting changes * possible fix * sync * reverting files to deal with issue in another PR * Update change/@fluentui-react-avatar-0ebe3e03-9d8f-48f7-a4c0-2a95b7014e2e.json Co-authored-by: Makoto Morimoto <[email protected]> * Update apps/vr-tests-react-components/src/stories/AvatarGroup.stories.tsx Co-authored-by: Makoto Morimoto <[email protected]> * Update packages/react-components/react-avatar/src/components/AvatarGroup/AvatarGroup.test.tsx Co-authored-by: Sean Monahan <[email protected]> * covering stack and pie for rtl+HCM+dark mode * updating vr-tests * updating classname tests for AvatarGroup * adding color to diviers Co-authored-by: Makoto Morimoto <[email protected]> Co-authored-by: Sean Monahan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
AvatarGroup has no unit and visual regression tests.
New Behavior
AvatarGroup has unit and visual regression tests.
Related Issue(s)
#22240