feat(react-conformance): Add getPortalElement to static classnames object test #23631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopranopillow
added
Fluent UI react-components (v9)
Component: AvatarGroup
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5606d1c:
|
…eact-conformance-portal
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 24ee79da3c6501507c1ab3a8feab0e5f173b0e8b (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1704 | 1648 | 5000 | |
| Button | mount | 1247 | 1248 | 5000 | |
| FluentProvider | mount | 2285 | 2248 | 5000 | |
| FluentProviderWithTheme | mount | 929 | 934 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 878 | 878 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 911 | 907 | 10 | |
| MakeStyles | mount | 2487 | 2533 | 50000 |
sopranopillow
requested review from
a team,
behowell and
khmakoto
as code owners
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 776 | 765 | 5000 | |
| Breadcrumb | mount | 2182 | 2352 | 1000 | |
| Checkbox | mount | 1294 | 1280 | 5000 | |
| CheckboxBase | mount | 1099 | 1024 | 5000 | |
| ChoiceGroup | mount | 3902 | 3845 | 5000 | |
| ComboBox | mount | 748 | 810 | 1000 | |
| CommandBar | mount | 8874 | 9044 | 1000 | |
| ContextualMenu | mount | 9944 | 9858 | 1000 | |
| DefaultButton | mount | 992 | 970 | 5000 | |
| DetailsRow | mount | 3288 | 3203 | 5000 | |
| DetailsRowFast | mount | 3096 | 3107 | 5000 | |
| DetailsRowNoStyles | mount | 3100 | 3124 | 5000 | |
| Dialog | mount | 2324 | 2394 | 1000 | |
| DocumentCardTitle | mount | 157 | 149 | 1000 | |
| Dropdown | mount | 2776 | 2757 | 5000 | |
| FocusTrapZone | mount | 1592 | 1450 | 5000 | |
| FocusZone | mount | 1560 | 1480 | 5000 | |
| IconButton | mount | 1438 | 1494 | 5000 | |
| Label | mount | 286 | 267 | 5000 | |
| Layer | mount | 2348 | 2548 | 5000 | |
| Link | mount | 407 | 405 | 5000 | |
| MenuButton | mount | 1265 | 1289 | 5000 | |
| MessageBar | mount | 1733 | 1734 | 5000 | |
| Nav | mount | 2737 | 2733 | 1000 | |
| OverflowSet | mount | 942 | 920 | 5000 | |
| Panel | mount | 1796 | 1717 | 1000 | |
| Persona | mount | 847 | 868 | 1000 | |
| Pivot | mount | 1171 | 1211 | 1000 | |
| PrimaryButton | mount | 1123 | 1031 | 5000 | |
| Rating | mount | 6248 | 6229 | 5000 | |
| SearchBox | mount | 1068 | 1065 | 5000 | |
| Shimmer | mount | 2076 | 2112 | 5000 | |
| Slider | mount | 1643 | 1658 | 5000 | |
| SpinButton | mount | 4192 | 4205 | 5000 | |
| Spinner | mount | 355 | 364 | 5000 | |
| SplitButton | mount | 2694 | 2586 | 5000 | |
| Stack | mount | 391 | 438 | 5000 | |
| StackWithIntrinsicChildren | mount | 1901 | 1945 | 5000 | |
| StackWithTextChildren | mount | 4403 | 4286 | 5000 | |
| SwatchColorPicker | mount | 9548 | 10008 | 5000 | |
| TagPicker | mount | 2173 | 2251 | 5000 | |
| TeachingBubble | mount | 89865 | 91516 | 5000 | |
| Text | mount | 330 | 365 | 5000 | |
| TextField | mount | 1222 | 1206 | 5000 | |
| ThemeProvider | mount | 966 | 1007 | 5000 | |
| ThemeProvider | virtual-rerender | 560 | 537 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1539 | 1586 | 5000 | |
| Toggle | mount | 637 | 702 | 5000 | |
| buttonNative | mount | 108 | 106 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TextMinimalPerf.default | 289 | 244 | 1.18:1 |
| DropdownManyItemsPerf.default | 569 | 492 | 1.16:1 |
| SegmentMinimalPerf.default | 290 | 251 | 1.16:1 |
| IconMinimalPerf.default | 542 | 484 | 1.12:1 |
| ProviderMergeThemesPerf.default | 1049 | 946 | 1.11:1 |
| CardMinimalPerf.default | 444 | 405 | 1.1:1 |
| LoaderMinimalPerf.default | 555 | 507 | 1.09:1 |
| HeaderMinimalPerf.default | 303 | 281 | 1.08:1 |
| AvatarMinimalPerf.default | 162 | 152 | 1.07:1 |
| PortalMinimalPerf.default | 131 | 123 | 1.07:1 |
| ButtonMinimalPerf.default | 139 | 131 | 1.06:1 |
| GridMinimalPerf.default | 286 | 270 | 1.06:1 |
| TooltipMinimalPerf.default | 945 | 891 | 1.06:1 |
| ChatMinimalPerf.default | 614 | 586 | 1.05:1 |
| AttachmentMinimalPerf.default | 126 | 121 | 1.04:1 |
| FlexMinimalPerf.default | 242 | 233 | 1.04:1 |
| ListWith60ListItems.default | 515 | 500 | 1.03:1 |
| SplitButtonMinimalPerf.default | 3624 | 3528 | 1.03:1 |
| TableMinimalPerf.default | 342 | 331 | 1.03:1 |
| ImageMinimalPerf.default | 304 | 298 | 1.02:1 |
| ListNestedPerf.default | 466 | 456 | 1.02:1 |
| SliderMinimalPerf.default | 1431 | 1398 | 1.02:1 |
| StatusMinimalPerf.default | 567 | 554 | 1.02:1 |
| AlertMinimalPerf.default | 223 | 221 | 1.01:1 |
| CarouselMinimalPerf.default | 396 | 394 | 1.01:1 |
| DialogMinimalPerf.default | 643 | 637 | 1.01:1 |
| EmbedMinimalPerf.default | 3451 | 3407 | 1.01:1 |
| MenuMinimalPerf.default | 714 | 706 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1416 | 1401 | 1.01:1 |
| ReactionMinimalPerf.default | 300 | 297 | 1.01:1 |
| TableManyItemsPerf.default | 1615 | 1604 | 1.01:1 |
| AnimationMinimalPerf.default | 450 | 450 | 1:1 |
| ButtonSlotsPerf.default | 458 | 458 | 1:1 |
| ChatWithPopoverPerf.default | 313 | 312 | 1:1 |
| DividerMinimalPerf.default | 290 | 290 | 1:1 |
| InputMinimalPerf.default | 1079 | 1083 | 1:1 |
| ListMinimalPerf.default | 421 | 423 | 1:1 |
| RadioGroupMinimalPerf.default | 370 | 369 | 1:1 |
| SkeletonMinimalPerf.default | 281 | 282 | 1:1 |
| CustomToolbarPrototype.default | 2225 | 2227 | 1:1 |
| TreeMinimalPerf.default | 680 | 677 | 1:1 |
| DropdownMinimalPerf.default | 2622 | 2657 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 975 | 980 | 0.99:1 |
| ListCommonPerf.default | 526 | 531 | 0.99:1 |
| TreeWith60ListItems.default | 128 | 129 | 0.99:1 |
| AttachmentSlotsPerf.default | 876 | 891 | 0.98:1 |
| HeaderSlotsPerf.default | 607 | 622 | 0.98:1 |
| LayoutMinimalPerf.default | 285 | 290 | 0.98:1 |
| ProviderMinimalPerf.default | 327 | 333 | 0.98:1 |
| ToolbarMinimalPerf.default | 773 | 792 | 0.98:1 |
| VideoMinimalPerf.default | 523 | 533 | 0.98:1 |
| DatepickerMinimalPerf.default | 4710 | 4832 | 0.97:1 |
| RosterPerf.default | 888 | 917 | 0.97:1 |
| PopupMinimalPerf.default | 505 | 519 | 0.97:1 |
| RefMinimalPerf.default | 187 | 192 | 0.97:1 |
| ChatDuplicateMessagesPerf.default | 232 | 242 | 0.96:1 |
| TextAreaMinimalPerf.default | 377 | 394 | 0.96:1 |
| CheckboxMinimalPerf.default | 2153 | 2258 | 0.95:1 |
| ButtonOverridesMissPerf.default | 1156 | 1249 | 0.93:1 |
| FormMinimalPerf.default | 299 | 326 | 0.92:1 |
| LabelMinimalPerf.default | 286 | 312 | 0.92:1 |
| BoxMinimalPerf.default | 247 | 274 | 0.9:1 |
| AccordionMinimalPerf.default | 104 | 119 | 0.87:1 |
spmonahan
requested changes
Jun 23, 2022
msft-fluent-ui-bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
spmonahan
requested changes
Jun 23, 2022
Co-authored-by: Sean Monahan <[email protected]>
spmonahan
approved these changes
Jun 23, 2022
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
…ject test (microsoft#23631) * feat: Adding getPortalElement option to static classnames object test. * change files * reverting lock file * restoring files * reverting yarn.lock * adding requested feedback * Update packages/react-conformance/src/defaultTests.tsx Co-authored-by: Sean Monahan <[email protected]> Co-authored-by: Sean Monahan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
component-has-static-classnames-objecttest, specifically thehas static classnames in rendered componentportion, doesn't handle internal portal elements. An example could be a popover that is only rendered when the trigger is clicked.New Behavior
The
has-static-classnamesoptions now have agetPortalElementto allow the user to find the element and check for the classnames inside the portal element.Related Issue(s)
#23549