fix(react-avatar): Make AvatarGroup's pie layout dividers white for HCM #23636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopranopillow
added
Fluent UI react-components (v9)
Component: AvatarGroup
sopranopillow
requested review from
a team,
behowell and
khmakoto
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f3e9415:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1663 | 1705 | 5000 | |
| Button | mount | 1170 | 1202 | 5000 | |
| FluentProvider | mount | 2250 | 2175 | 5000 | |
| FluentProviderWithTheme | mount | 882 | 843 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 803 | 820 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 865 | 917 | 10 | |
| MakeStyles | mount | 2430 | 2424 | 50000 |
Asset size changesUnable to find bundle size details for Baseline commit: 52f6f9d Possible causes
Recommendations
|
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
khmakoto
approved these changes
Jun 23, 2022
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
…CM (microsoft#23636) * fix:Make AvatarGroup's pie layout dividers white for HCM. * change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
New Behavior
Related Issue(s)
#23549