fix(react-avatar): Fix outline styles for stack layout in webkit browsers. #23576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopranopillow
added
Fluent UI react-components (v9)
Component: AvatarGroup
sopranopillow
requested review from
a team,
behowell and
khmakoto
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c422ba6:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ed08fb6d86fc74667a93db7d2cf43286aaa21faf (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 949 | 886 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1657 | 1693 | 5000 | |
| Button | mount | 1226 | 1243 | 5000 | |
| FluentProvider | mount | 2903 | 2865 | 5000 | |
| FluentProviderWithTheme | mount | 949 | 886 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 818 | 925 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 954 | 967 | 10 | |
| MakeStyles | mount | 2570 | 2505 | 50000 |
khmakoto
approved these changes
Jun 16, 2022
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
…sers. (microsoft#23576) * fix outlines for stack layout in webkit browsers * change files * found better fix * another way to fix this, looks like it will be the way to go * fixing focus ring * fixing focus ring * fixing double border issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Border radius is ignored for the stack layout's outline. This is due to a bug in webkit browser where
outlineignores both-webkit-border-radiusandborder-radius. For more details you can take a look at the bug filed in here.New Behavior
Outline for stack layouts now works correctly in webkit browsers. To accomplish this, a border has to be added in an
::afterpseudo-element. This affectsuseGroupChildClassNameby having to differentiate when the hook is used for the overflowButton. Mostly so that the width can be calculated correctly because the button is applied a border that is not picked up by settingwidth: 100%in the pseudo-element.Related Issue(s)
#23549 #22240