P1614R2 Adding Spaceship <=> To The Library #1678

StephanTLavavej · 2021-02-23T01:42:29Z

Fixes #62.

This merges feature/spaceship into main with one additional commit. That commit fixes the default template argument of take_view::sentinel to follow WG21-N4878 [range.take.sentinel], which was the only remaining work for Clause 24 Ranges. (Note that take_while_view::sentinel was already doing the right thing.)

I plan to mark this feature as complete after merging this PR, with a small amount of remaining work tracked by various issues:

STL: Compiler intrinsics for BUILTIN-PTR-XXX #489 tracks the need to request compiler intrinsics to support certain scenarios.
[P0980R1] constexpr std::string #1502 is implementing constexpr std::string; it will need to be extended to apply constexpr to std::string and std::string::iterator's spaceships, or we'll need to file a tracking issue.
<chrono>: C++20 clocks, clock_cast, tzdb::leap_seconds #1671 implements C++20 time zones along with spaceships for those types; I believe that this completes the <chrono> spaceships.
<optional>: Potential constraint recursion for operator<=>(const optional<T>&, const U&) #1674 tracks a potential LWG issue or compiler bug that needs to be reported; we've worked around this in our implementation.
<valarray>: P1614R2 added operator== for slice, but not gslice #1676 tracks an LEWG issue that should be reported; nothing to do for our implementation.
<vector>: Test constexpr spaceships #1677 tracks the need to test constexpr std::vector spaceships (when compiler fixes are available)
DevCom-1159401/VSO-1179422 reported by @statementreply tracks suboptimal codegen. @AnjuDel and @CaseyCarter have brought this to the compiler back-end team's attention; nothing to do for our implementation (as adding an escape hatch would increase configuration complexity).

This feature sets a record for the largest number of contributors in the STL's history! (The previous record-holder was C++17 <filesystem>.) Thanks to everyone who implemented spaceship machinery:

🚀 🛸 🪐

feature/spaceship: Merge microsoft#1049 (fix <compare> and simplify guards)

Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Merge VS 2019 16.8 Preview 1 toolset update

feature/spaceship: Merge Standard_D16as_v4 VM update

Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Curtis Bezault <[email protected]>

feature/spaceship: Merge fix for test timing assumption

feature/spaceship: Merge VS 2019 16.8 Preview 2 toolset update

Co-authored-by: Ahana Mukhopadhyay <[email protected]> Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Merge toolset update

feature/spaceship: Merge CI changes to pick up microsoft#1337. This is a clean merge with no additional edits.

feature/spaceship: Merge toolset update

feature/spaceship: Merge CI update

feature/spaceship: Merge toolset update

Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Merge LLVM update

…icrosoft#1593)

Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Merge toolset update

NOTE: there was much complicated conflict resolution in `<vector>` to reconcile the work on this branch with the `constexpr vector` work from main.

Feature/spaceship: Merge VMSS update

Co-authored-by: Anju Del Moral Gonzalez <[email protected]> Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

Co-authored-by: Stephan T. Lavavej <[email protected]>

Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

…icrosoft#1665) Co-authored-by: Stephan T. Lavavej <[email protected]>

…oft#1660) Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Merge duration/time_point tests from main

Co-authored-by: Stephan T. Lavavej <[email protected]>

microsoft#1672)

Co-authored-by: Ahana Mukhopadhyay <[email protected]> Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Curtis Bezault <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

StephanTLavavej · 2021-02-23T03:28:03Z

Mirrored to internal MSVC-PR-306138 after I had a successful x86chk build and stl compiler test run.

stl/inc/xstring

AnjuDel · 2021-02-23T18:58:15Z

I checked that all my work was correctly merged and it looks it is, with a small minor exception.

stl/inc/forward_list

stl/inc/list

stl/inc/map

stl/inc/ranges

stl/inc/set

stl/inc/vector

mnatsuhara

The only comments I could find were pathetic whitespace issues - feel free to ignore to avoid rerunning the tests! A monumental amount of work - looks good to me!

mnatsuhara · 2021-02-24T05:25:53Z

stl/inc/memory

+_NODISCARD strong_ordering operator<=>(const shared_ptr<_Ty1>& _Left, const shared_ptr<_Ty2>& _Right) noexcept {
+    return _Left.get() <=> _Right.get();
+}
+


Just so I can comment on something, do we need this blank line here? :)

I'll remove these lines in a followup PR 😺

mnatsuhara · 2021-02-24T05:27:19Z

stl/inc/memory

+_NODISCARD strong_ordering operator<=>(const shared_ptr<_Ty>& _Left, nullptr_t) noexcept {
+    return _Left.get() <=> static_cast<typename shared_ptr<_Ty>::element_type*>(nullptr);
+}
+


Ditto!

Suggested change

StephanTLavavej · 2021-02-25T00:21:38Z

Thanks everyone - we're now a warp-capable civilization!

🚀 🛸 ☄️

StephanTLavavej and others added 30 commits July 20, 2020 18:40

Merge pull request microsoft#1064 from microsoft/master

de04d41

feature/spaceship: Merge microsoft#1049 (fix <compare> and simplify guards)

feature/spaceship: Clause 22: Containers (microsoft#1046)

889b8c8

Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

Merge branch 'master' into update_spaceship

63db7c6

Merge pull request microsoft#1178 from StephanTLavavej/update_spaceship

a1e96f2

feature/spaceship: Merge VS 2019 16.8 Preview 1 toolset update

Merge pull request microsoft#1188 from microsoft/master

98c4f96

feature/spaceship: Merge Standard_D16as_v4 VM update

feature/spaceship: Clause 30: Regex (microsoft#1145)

fa344bf

Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Curtis Bezault <[email protected]>

Merge pull request microsoft#1212 from microsoft/master

b9642bf

feature/spaceship: Merge fix for test timing assumption

Merge pull request microsoft#1236 from microsoft/master

183945e

feature/spaceship: Merge VS 2019 16.8 Preview 2 toolset update

feature/spaceship: Clause 19: Diagnostics (microsoft#1180)

f0eb010

Co-authored-by: Ahana Mukhopadhyay <[email protected]> Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

Merge pull request microsoft#1298 from microsoft/master

fcbba69

feature/spaceship: Merge toolset update

Merge pull request microsoft#1360 from microsoft/master

de8ef2e

feature/spaceship: Merge CI changes to pick up microsoft#1337. This is a clean merge with no additional edits.

Merge pull request microsoft#1380 from microsoft/master

dc62c36

feature/spaceship: Merge toolset update

Merge branch 'master' into feature/spaceship

98ad286

Merge pull request microsoft#1404 from StephanTLavavej/merge_spaceship

24fbe3b

feature/spaceship: Merge toolset update

Merge pull request microsoft#1470 from microsoft/master

1d0c238

feature/spaceship: Merge toolset update

Merge branch 'master' into merge_spaceship

96ac4ff

Merge pull request microsoft#1526 from StephanTLavavej/merge_spaceship

939b933

feature/spaceship: Merge toolset update

Merge pull request microsoft#1537 from microsoft/master

8d2841f

feature/spaceship: Merge CI update

Merge branch 'master' into merge_spaceship

92bd4b9

if constexpr is always available now.

8285558

Merge pull request microsoft#1580 from StephanTLavavej/merge_spaceship

0f71986

feature/spaceship: Merge toolset update

feature/spaceship: Clause 32: Thread support (microsoft#1590)

091958d

Co-authored-by: Stephan T. Lavavej <[email protected]>

Merge branch 'main' into merge_spaceship

05a1c4f

Merge pull request microsoft#1615 from StephanTLavavej/merge_spaceship

b9ef974

feature/spaceship: Merge LLVM update

feature/spaceship: Clause 28: Localization, Clause 29: Input/output (m…

e68b14a

…icrosoft#1593)

feature/spaceship: Clause 26: Numerics (microsoft#1627)

5443c4a

Co-authored-by: Stephan T. Lavavej <[email protected]>

Merge branch 'main' into merge_spaceship

3c1da29

Merge pull request microsoft#1644 from StephanTLavavej/merge_spaceship

f27eaed

feature/spaceship: Merge toolset update

Merge branch 'main' into feature/spaceship

31a5d70

NOTE: there was much complicated conflict resolution in `<vector>` to reconcile the work on this branch with the `constexpr vector` work from main.

Merge pull request microsoft#1655 from CaseyCarter/feature/spaceship

ad6688c

Feature/spaceship: Merge VMSS update

StephanTLavavej and others added 12 commits February 17, 2021 19:16

feature/spaceship: Clause 23: Iterators (microsoft#1645)

250aa73

feature/spaceship: Clause 21: Strings (microsoft#1635)

bbedd7a

Co-authored-by: Anju Del Moral Gonzalez <[email protected]> Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Clause 20: variant, monostate (microsoft#1657)

55c2af9

Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Clause 22: Container Iterators (microsoft#1648)

eeed690

Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Clause 20: various synthesized equality operators (m…

88feca8

…icrosoft#1665) Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Clause 20: bitset, charconv, and typeindex (micros…

aad4417

…oft#1660) Co-authored-by: Stephan T. Lavavej <[email protected]>

Merge branch 'main' into merge_spaceship

aca45f6

Merge pull request microsoft#1669 from StephanTLavavej/merge_spaceship

467780d

feature/spaceship: Merge duration/time_point tests from main

feature/spaceship: Clause 20: unique_ptr/shared_ptr (microsoft#1666)

d22f916

Co-authored-by: Stephan T. Lavavej <[email protected]>

feature/spaceship: Clause 17: Feature-test macro, yvals_core.h comment (

0bed9f5

microsoft#1672)

feature/spaceship: Clause 20: pair, tuple, optional (microsoft#1206)

5547f0f

Co-authored-by: Ahana Mukhopadhyay <[email protected]> Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Curtis Bezault <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>

Fix take_view::sentinel, [range.take.sentinel].

1bcfc8d

StephanTLavavej added cxx20 C++20 feature spaceship C++20 operator <=> labels Feb 23, 2021

StephanTLavavej requested a review from a team as a code owner February 23, 2021 01:42

StephanTLavavej mentioned this pull request Feb 23, 2021

P0896R4 <ranges> #39

Closed

AnjuDel suggested changes Feb 23, 2021

View reviewed changes

stl/inc/xstring Show resolved Hide resolved

stl/inc/xstring Show resolved Hide resolved

AnjuDel suggested changes Feb 24, 2021

View reviewed changes

Make __cpp_lib_concepts preprocessor comments more consistent.

415b7aa

StephanTLavavej requested a review from AnjuDel February 24, 2021 03:25

AnjuDel approved these changes Feb 24, 2021

View reviewed changes

StephanTLavavej assigned mnatsuhara Feb 24, 2021

mnatsuhara approved these changes Feb 24, 2021

View reviewed changes

mnatsuhara removed their assignment Feb 24, 2021

StephanTLavavej merged commit b52c379 into microsoft:main Feb 25, 2021

StephanTLavavej deleted the land_the_spaceship branch February 25, 2021 00:20

StephanTLavavej mentioned this pull request Feb 25, 2021

Skip tr1/tests/thread, minor style cleanups #1697

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

P1614R2 Adding Spaceship <=> To The Library #1678

P1614R2 Adding Spaceship <=> To The Library #1678

Uh oh!

StephanTLavavej commented Feb 23, 2021

Uh oh!

StephanTLavavej commented Feb 23, 2021

Uh oh!

Uh oh!

Uh oh!

AnjuDel commented Feb 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnatsuhara left a comment

Uh oh!

mnatsuhara Feb 24, 2021

Uh oh!

StephanTLavavej Feb 25, 2021

Uh oh!

mnatsuhara Feb 24, 2021

Uh oh!

StephanTLavavej commented Feb 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

P1614R2 Adding Spaceship <=> To The Library #1678

P1614R2 Adding Spaceship <=> To The Library #1678

Uh oh!

Conversation

StephanTLavavej commented Feb 23, 2021

🚀 🛸 🪐

Uh oh!

StephanTLavavej commented Feb 23, 2021

Uh oh!

Uh oh!

Uh oh!

AnjuDel commented Feb 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnatsuhara left a comment

Choose a reason for hiding this comment

Uh oh!

mnatsuhara Feb 24, 2021

Choose a reason for hiding this comment

Uh oh!

StephanTLavavej Feb 25, 2021

Choose a reason for hiding this comment

Uh oh!

mnatsuhara Feb 24, 2021

Choose a reason for hiding this comment

Uh oh!

StephanTLavavej commented Feb 25, 2021

🚀 🛸 ☄️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants