feature/spaceship: Clause 19: Diagnostics #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug uncovered by fixed tests.
Co-authored-by: Casey Carter <[email protected]>
StephanTLavavej
requested changes
Aug 16, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! I think this will be ready to commit to the feature branch after one more iteration; I'd like to double-check after the regex changes are merged so the diff is simpler. 😺
cbezault
force-pushed
the
feature/spaceship/diagnostics
branch
from
002e21e to
d953a01
Compare
cbezault
force-pushed
the
feature/spaceship/diagnostics
branch
from
d953a01 to
3473a08
Compare
Co-authored-by: Stephan T. Lavavej <[email protected]>
cbezault
force-pushed
the
feature/spaceship/diagnostics
branch
from
129eb60 to
df07d1b
Compare
StephanTLavavej
changed the title
Member
|
This needs to be merged with the latest commits to |
…TL into feature/spaceship/diagnostics
Contributor
Author
|
The fact that most of the tests for spaceship don't need to get re-run for the extra coverage required for the |
StephanTLavavej
requested changes
Sep 1, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good, just one remaining issue! 😺
StephanTLavavej
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1145