Skip to content

feature/spaceship: Clause 28: Localization, Clause 29: Input/output #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2021
Merged

feature/spaceship: Clause 28: Localization, Clause 29: Input/output #1593

merged 3 commits into from
Feb 3, 2021
+81 −4

Conversation

@statementreply
Copy link
Contributor

@statementreply statementreply commented Jan 28, 2021

Works towards #62.

@statementreply statementreply requested a review from a team as a code owner January 28, 2021 16:12
@CaseyCarter CaseyCarter added cxx20 C++20 feature spaceship C++20 operator <=> labels Jan 28, 2021
CaseyCarter
CaseyCarter approved these changes Jan 28, 2021
View reviewed changes
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Jan 28, 2021
@CaseyCarter
Update LLVM submodule reference
5c2cde4 
... to get a test fix to support microsoft#1593.
@CaseyCarter CaseyCarter mentioned this pull request Jan 28, 2021
Merged
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Jan 28, 2021

FYI: the test failure is a libc++ test for directory_entry's comparison operators that expects actual member functions (e.g., operator<=) to be present. I've pushed a fix upstream, and opened #1594 to update our LLVM submodule reference to get the fixed test. Once #1594 merges, we'll need to merge it to feature/spaceship which we can then merge into this PR.

CaseyCarter
CaseyCarter suggested changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - I meant to "request changes" for my directory_entry::operator< comment.

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Jan 29, 2021

Moving this to final review despite the test failure which is addressed by #1594. If there is a problem with #1594 and we absolutely must merge this first, we can skip the failing libc++ test in this PR and re-enable in #1594.

StephanTLavavej
StephanTLavavej approved these changes Jan 30, 2021
View reviewed changes
stl/inc/filesystem
uintmax_t available;

#if _HAS_CXX20
_NODISCARD friend constexpr bool operator==(const space_info&, const space_info&) noexcept = default;
Copy link
Member

@StephanTLavavej StephanTLavavej Jan 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observe that this says constexpr and noexcept which are implied by the Standard but not depicted there. I think this is fine (I am somewhat torn between "generally avoid unnecessary code" and "this is a useful reminder"), no change requested.

@StephanTLavavej

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@StephanTLavavej

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@StephanTLavavej

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@StephanTLavavej

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@StephanTLavavej StephanTLavavej merged commit e68b14a into microsoft:feature/spaceship Feb 3, 2021
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 3, 2021

Thanks for spaceship-izing locales and I/O so we can properly communicate with aliens! 👽 💬 📡

@statementreply statementreply deleted the spaceship-clause-29 branch April 17, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cxx20 C++20 feature spaceship C++20 operator <=>

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@statementreply @CaseyCarter @StephanTLavavej