Skip to content

Comments

Add gnome, gtk-doc, and vala regression tests#9819

Merged
nirbheek merged 4 commits intomesonbuild:masterfrom
nirbheek:add-gnome-and-vala-tests
Jan 14, 2022
Merged

Add gnome, gtk-doc, and vala regression tests#9819
nirbheek merged 4 commits intomesonbuild:masterfrom
nirbheek:add-gnome-and-vala-tests

Conversation

@nirbheek
Copy link
Member

Regression tests for the following PRs: #9806 #9807 #9812 #9817

@nirbheek nirbheek added this to the 0.61.1 milestone Jan 13, 2022
@nirbheek nirbheek requested a review from jpakkane as a code owner January 13, 2022 08:18
@eli-schwartz
Copy link
Member

LGTM, but CI is refusing to run since no changes to meson build/ were made...

Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

LGTM as well, but i t would be nice if we could figure out how to get the CI to run...

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #9819 (37b40c9) into master (bda11fe) will decrease coverage by 2.96%.
The diff coverage is n/a.

❗ Current head 37b40c9 differs from pull request most recent head b1b1f0c. Consider uploading reports for the commit b1b1f0c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9819      +/-   ##
==========================================
- Coverage   67.46%   64.50%   -2.97%     
==========================================
  Files         400      200     -200     
  Lines       85516    42709   -42807     
  Branches    18859     9334    -9525     
==========================================
- Hits        57697    27549   -30148     
+ Misses      23287    12951   -10336     
+ Partials     4532     2209    -2323     
Impacted Files Coverage Δ
mesonbuild/dependencies/boost.py
mesonbuild/scripts/clangformat.py
mesonbuild/backend/backends.py
mesonbuild/compilers/mixins/xc16.py
mesonbuild/compilers/swift.py
mesonbuild/compilers/rust.py
mesonbuild/optinterpreter.py
mesonbuild/dependencies/dev.py
mesonbuild/compilers/mixins/gnu.py
mesonbuild/interpreter/primitives/dict.py
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda11fe...b1b1f0c. Read the comment docs.

@nirbheek nirbheek force-pushed the add-gnome-and-vala-tests branch 2 times, most recently from e3f9772 to e9217d3 Compare January 14, 2022 14:00
@nirbheek nirbheek force-pushed the add-gnome-and-vala-tests branch from e9217d3 to f76c35d Compare January 14, 2022 14:46
check: true is needed for an actual regression test, but that requires
a pedantically correct gtk-doc configuration, which I attempted to do
and failed. So let's just put check: false so we get *some* coverage:
just that typed_kwargs accepts the argument.

Related to mesonbuild#9807
@nirbheek nirbheek force-pushed the add-gnome-and-vala-tests branch from f76c35d to b1b1f0c Compare January 14, 2022 17:41
@nirbheek
Copy link
Member Author

Tests all passed, removed the test commit by eli.

@nirbheek nirbheek merged commit f35e2fc into mesonbuild:master Jan 14, 2022
@nirbheek nirbheek deleted the add-gnome-and-vala-tests branch January 14, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants