Merged
Conversation
Per the gdbus-codegen documentation, this "may be used several times", and it is: - a valid use case - used that way in the wild Fixes building at least geoclue2, gdm.
Fixes gtk3 build, which uses typesfile. All these arguments are processed by a function that explicitly handles both str and File, and converts them to absolute paths. They clearly need to handle File objects.
As soon as we check for args[1] we declare it is of type FileOrString, and the additional ones specified in the `sources` kwarg explicitly allow this. It makes no sense to not accept it as the posarg too. Fixes building tracker-miners.
Codecov Report
@@ Coverage Diff @@
## master #9812 +/- ##
==========================================
+ Coverage 64.35% 67.51% +3.15%
==========================================
Files 200 400 +200
Lines 42679 85474 +42795
Branches 9321 18839 +9518
==========================================
+ Hits 27468 57710 +30242
- Misses 13006 23251 +10245
- Partials 2205 4513 +2308
Continue to review full report at Codecov.
|
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 13, 2022
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 14, 2022
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 14, 2022
nirbheek
added a commit
that referenced
this pull request
Jan 14, 2022
nirbheek
added a commit
that referenced
this pull request
Jan 14, 2022
Dudemanguy
pushed a commit
to Dudemanguy/meson
that referenced
this pull request
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @paper42